From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F10DC00A8F for ; Tue, 24 Oct 2023 16:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234859AbjJXQOa (ORCPT ); Tue, 24 Oct 2023 12:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234820AbjJXQOa (ORCPT ); Tue, 24 Oct 2023 12:14:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91B73A1; Tue, 24 Oct 2023 09:14:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EE17C433CC; Tue, 24 Oct 2023 16:14:26 +0000 (UTC) Date: Tue, 24 Oct 2023 17:14:24 +0100 From: Catalin Marinas To: Ard Biesheuvel Cc: Stephen Rothwell , Will Deacon , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build warning after merge of the arm64 tree Message-ID: References: <20231024172409.7b519868@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, Oct 24, 2023 at 03:42:20PM +0200, Ard Biesheuvel wrote: > On Tue, 24 Oct 2023 at 11:55, Catalin Marinas wrote: > > > > + Ard > > > > On Tue, Oct 24, 2023 at 05:24:09PM +1100, Stephen Rothwell wrote: > > > After merging the arm64 tree, today's linux-next build (arm64 defconfig) > > > produced this warning: > > > > > > WARNING: modpost: vmlinux: section mismatch in reference: __pi_$x+0x38 (section: .text) -> __pi_map_range (section: .init.text) > > > > > > I don't know what caused this. > > > > For some reason, building linux-next doesn't inline all the functions in > > the map_range.c file and we end up with some of them in different > > sections. I didn't get this when building the arm64 for-next/core > > separately. > > > > Strange, I never ran into this before. > > I guess commit 24cc769d70d8bda055a028aa6a is implicated in this, if we > run into more trouble like this i'll look whether we can bring that > logic back in some way. > > The fix looks fine to me. Thanks. I applied this fix locally (will push it out in a bit). I added a fixes tag for a latter commit introducing map_segment() etc. -- Catalin