From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q8XGBh7i" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C9D51B3 for ; Fri, 1 Dec 2023 18:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701483744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iWacCUu2+jQgLRypYgT2he0mdkQUbsb+sKjSsZ4uLUY=; b=Q8XGBh7iejZysLro5KnGv9Fc5S19BMvIygrGch074v1YevRhkYFFLGLfLufr/cjDyKCyjf +CWhoJw9MAnIMqEIodMfVQvjNblVCpxZluT+XPxLq6n6dtqMpbSNMSChmoXhdiYpMbJuvZ yZAo7+NVeOevqyyF7O7acQGAkI//Yec= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-7v1jVeiSPby4hQqRPG56sw-1; Fri, 01 Dec 2023 21:22:21 -0500 X-MC-Unique: 7v1jVeiSPby4hQqRPG56sw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D6F5811E7D; Sat, 2 Dec 2023 02:22:20 +0000 (UTC) Received: from localhost (unknown [10.72.113.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 682152026D4C; Sat, 2 Dec 2023 02:22:19 +0000 (UTC) Date: Sat, 2 Dec 2023 10:22:15 +0800 From: Baoquan He To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , linux-riscv , kexec Subject: Re: linux-next: Tree for Dec 1 (riscv, crash_core) Message-ID: References: <20231201133726.4a4413dd@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 On 12/01/23 at 11:53am, Randy Dunlap wrote: > > > On 11/30/23 18:37, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20231130: > > > > on riscv 32-bit or 64-bit, with > # CONFIG_MMU is not set Can you provide your .config so that I reproduce it? Disabling CONFIG_MMU need find all places where it's selected by other config items. > > In file included from ../arch/riscv/kernel/crash_core.c:3: > ../arch/riscv/kernel/crash_core.c: In function 'arch_crash_save_vmcoreinfo': > ../arch/riscv/kernel/crash_core.c:8:27: error: 'VA_BITS' undeclared (first use in this function) > 8 | VMCOREINFO_NUMBER(VA_BITS); > | ^~~~~~~ > ../include/linux/crash_core.h:78:64: note: in definition of macro 'VMCOREINFO_NUMBER' > 78 | vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name) > | ^~~~ > ../arch/riscv/kernel/crash_core.c:8:27: note: each undeclared identifier is reported only once for each function it appears in > 8 | VMCOREINFO_NUMBER(VA_BITS); > | ^~~~~~~ > ../include/linux/crash_core.h:78:64: note: in definition of macro 'VMCOREINFO_NUMBER' > 78 | vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name) > | ^~~~ > ../arch/riscv/kernel/crash_core.c:12:58: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'int' [-Wformat=] > 12 | vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > | ~~^ > | | > | long unsigned int > | %x > ../arch/riscv/kernel/crash_core.c:14:64: error: 'VMEMMAP_START' undeclared (first use in this function) > 14 | vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START); > | ^~~~~~~~~~~~~ > ../arch/riscv/kernel/crash_core.c:15:62: error: 'VMEMMAP_END' undeclared (first use in this function); did you mean 'MEMREMAP_ENC'? > 15 | vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END); > | ^~~~~~~~~~~ > | MEMREMAP_ENC > > 64-bit only: > > ../arch/riscv/kernel/crash_core.c:17:64: error: 'MODULES_VADDR' undeclared (first use in this function) > 17 | vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR); > | ^~~~~~~~~~~~~ > ../arch/riscv/kernel/crash_core.c:18:62: error: 'MODULES_END' undeclared (first use in this function) > 18 | vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END); > | ^~~~~~~~~~~ > > > > -- > ~Randy >