linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the mux tree
@ 2023-12-21 21:47 Stephen Rothwell
  2023-12-21 21:49 ` Stephen Rothwell
  2023-12-22  6:54 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Rothwell @ 2023-12-21 21:47 UTC (permalink / raw)
  To: Peter Rosin
  Cc: Vinod Koul, Jan Kuliga, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi all,

In commit

  2e142cebb164 ("dmaengine: xilinx: xdma: Rework xdma_terminate_all()")

Fixes tag

  Fixes: 49a701d8dc1e ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: Fixes tag needs some work in the mux tree
  2023-12-21 21:47 linux-next: Fixes tag needs some work in the mux tree Stephen Rothwell
@ 2023-12-21 21:49 ` Stephen Rothwell
  2023-12-22  6:54 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2023-12-21 21:49 UTC (permalink / raw)
  To: Peter Rosin
  Cc: Vinod Koul, Jan Kuliga, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Hi all,

On Fri, 22 Dec 2023 08:47:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   2e142cebb164 ("dmaengine: xilinx: xdma: Rework xdma_terminate_all()")
> 
> Fixes tag
> 
>   Fixes: 49a701d8dc1e ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")
> 
> Also, please keep all the commit message tags together at the end of
> the commit message.

Sorry, that is in the dmaengine tree, not the mux tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: Fixes tag needs some work in the mux tree
  2023-12-21 21:47 linux-next: Fixes tag needs some work in the mux tree Stephen Rothwell
  2023-12-21 21:49 ` Stephen Rothwell
@ 2023-12-22  6:54 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-12-22  6:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Peter Rosin, Jan Kuliga, Linux Kernel Mailing List,
	Linux Next Mailing List

On 22-12-23, 08:47, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2e142cebb164 ("dmaengine: xilinx: xdma: Rework xdma_terminate_all()")
> 
> Fixes tag
> 
>   Fixes: 49a701d8dc1e ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

It should be Fixes: f5c392d106e7 ("dmaengine: xilinx: xdma: Add terminate_all/synchronize callbacks")

I have fixed that

> Also, please keep all the commit message tags together at the end of
> the commit message.

Yes this one too and pushed out

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-22  6:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-21 21:47 linux-next: Fixes tag needs some work in the mux tree Stephen Rothwell
2023-12-21 21:49 ` Stephen Rothwell
2023-12-22  6:54 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).