From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA6AD225CF for ; Thu, 28 Mar 2024 02:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711591216; cv=none; b=CZzWUaz1uKIe9e37o4lz5Usn/xkRBRgpKGwCHByYgW5Yb4A23qKmsNQq6vMtx3NNqtRUt8uq2e74vdujldZ06MOMgZPLvMZnGeLsiQWqeeAI2qucb5EIya4otV+VWE9ygQBIKPc5O+fTu+s+SGxRkbB14RI5oQx0g2qPm0pQTtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711591216; c=relaxed/simple; bh=WO6HUfry9BHwXmmmaocg9kjEOnGz8Oiuy+GYJJcQtWs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TaFqN88MJCRc/+9ADWSQN04o0BShFoBkbMyQcK4NcrorzLUYH25+63kb9U8CiK1E3GOMkngfVJ4X7+uXuoWGZs9T9W8GMDYOtxzXtpkVmPVvVRTBirJxX5yVc8fZTe8ROctUDKD3rE8t/7cc1MH9Mvlmzz+cy8ukkHs1tOTQav8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eTHXgyR5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eTHXgyR5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711591213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p5nqKfv3v+biAgyqBmGEVEdrEDuJ1P9xCB6+AquGT5s=; b=eTHXgyR5gXgRAvUuPYHpC8eV7fMc7QA75j3DoFjxWhST/7TE4jFaq52SITuUEVQNaWwsa+ DlutditSX86VRZvNO+gMud2bSI8Znd/O7vdRLUFtFduUbaZfQivN3Lp80I7I1jB3nZUj5E XMQCO41VyA8kevbWIaH4k8UAUb3NvR0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-daDXQqzoMI2v4zX4q8y23g-1; Wed, 27 Mar 2024 22:00:01 -0400 X-MC-Unique: daDXQqzoMI2v4zX4q8y23g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9FCE3879849; Thu, 28 Mar 2024 02:00:00 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C08F9492BD0; Thu, 28 Mar 2024 01:59:59 +0000 (UTC) Date: Thu, 28 Mar 2024 09:59:52 +0800 From: Baoquan He To: Stephen Rothwell Cc: Andrew Morton , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build warning after merge of the mm tree Message-ID: References: <20240328091337.03421187@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240328091337.03421187@canb.auug.org.au> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 On 03/28/24 at 09:13am, Stephen Rothwell wrote: > Hi all, > > After merging the mm tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > mm/page_alloc.c: In function 'build_zonelists': > mm/page_alloc.c:5324:13: warning: unused variable 'node' [-Wunused-variable] > 5324 | int node, local_node; > | ^~~~ > > Introduced by commit > > 95d0185255a3 ("mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists()") > > from the mm-unstable branch of the mm tree. Thanks. Below code change has been queued on mm-unstable branch to fix it. >From 6bb5aa700a6221248df150cba3d9c54cd95bed97 Mon Sep 17 00:00:00 2001 From: Baoquan He Date: Wed, 27 Mar 2024 20:06:45 +0800 Subject: [PATCH] mm-page_allocc-remove-unneeded-codes-in-numa-version-of-build_zonelists-v2 Content-type: text/plain remove unused locals Link: https://lkml.kernel.org/r/ZgQL1WOf9K88nLpQ@MiWiFi-R3L-srv Signed-off-by: Baoquan He Signed-off-by: Andrew Morton --- mm/page_alloc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index a4f6b5f308ea..9c591413ca04 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5285,12 +5285,9 @@ static void setup_min_slab_ratio(void); static void build_zonelists(pg_data_t *pgdat) { - int node, local_node; struct zoneref *zonerefs; int nr_zones; - local_node = pgdat->node_id; - zonerefs = pgdat->node_zonelists[ZONELIST_FALLBACK]._zonerefs; nr_zones = build_zonerefs_node(pgdat, zonerefs); zonerefs += nr_zones; -- 2.41.0