Re: linux-next: build warning after merge of the mm tree

Andrew Morton
2022-06-22T18:49:49Z

On Wed, 22 Jun 2022 09:39:46 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:

> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -6905,10 +6905,8 @@ unsigned long hugetlb_mask_last_page(struct hstate *h)
> > /* See description above. Architectures can provide their own version. */
> > __weak unsigned long hugetlb_mask_last_page(struct hstate *h)
> > {
> > - unsigned long hp_size = huge_page_size(h);
> > -
> > #ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE
> > - if (hp_size == PMD_SIZE)
> > + if (huge_page_size(h) == PMD_SIZE)
> > return PUD_SIZE - PMD_SIZE;
> > #endif
> > return 0UL;
> > --
>
> Thanks Stephen, my bad for not building !CONFIG_ARCH_WANT_HUGE_PMD_SHARE and,
> the error is pretty obvious. :(
>
> Andrew, do you want me to send an updated version of the patch? Or,
> would you prefer to include Stephen's fix?

I added Stephen's fix, thanks.