public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
* linux-next: build warning after merge of the workqueues tree
@ 2024-08-21  3:45 Stephen Rothwell
  2024-08-21 16:39 ` [PATCH wq/for-6.12] workqueue: Fix another htmldocs build warning Tejun Heo
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2024-08-21  3:45 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Matthew Brost, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

After merging the workqueues tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/workqueue.h:547: warning: Excess function parameter '...' description in 'alloc_ordered_workqueue_lockdep_map'

Presumably introduced by commit

  9b59a85a84dc ("workqueue: Don't call va_start / va_end twice")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH wq/for-6.12] workqueue: Fix another htmldocs build warning
  2024-08-21  3:45 linux-next: build warning after merge of the workqueues tree Stephen Rothwell
@ 2024-08-21 16:39 ` Tejun Heo
  2024-08-22  3:24   ` Matthew Brost
  0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2024-08-21 16:39 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Matthew Brost, Linux Kernel Mailing List, Linux Next Mailing List

From d156263e247c334a8872578118e0709ed63c4806 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Wed, 21 Aug 2024 06:37:39 -1000

Fix htmldocs build warning introduced by 9b59a85a84dc ("workqueue: Don't
call va_start / va_end twice").

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Matthew Brost <matthew.brost@intel.com>
---
 include/linux/workqueue.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index f3cc15940b4d..59c2695e12e7 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -534,7 +534,7 @@ alloc_workqueue_lockdep_map(const char *fmt, unsigned int flags, int max_active,
  * @fmt: printf format for the name of the workqueue
  * @flags: WQ_* flags (only WQ_FREEZABLE and WQ_MEM_RECLAIM are meaningful)
  * @lockdep_map: user-defined lockdep_map
- * @...: args for @fmt
+ * @args: args for @fmt
  *
  * Same as alloc_ordered_workqueue but with the a user-define lockdep_map.
  * Useful for workqueues created with the same purpose and to avoid leaking a
@@ -544,7 +544,8 @@ alloc_workqueue_lockdep_map(const char *fmt, unsigned int flags, int max_active,
  * Pointer to the allocated workqueue on success, %NULL on failure.
  */
 #define alloc_ordered_workqueue_lockdep_map(fmt, flags, lockdep_map, args...)	\
-	alloc_workqueue_lockdep_map(fmt, WQ_UNBOUND | __WQ_ORDERED | (flags), 1, lockdep_map, ##args)
+	alloc_workqueue_lockdep_map(fmt, WQ_UNBOUND | __WQ_ORDERED | (flags),	\
+				    1, lockdep_map, ##args)
 #endif
 
 /**
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH wq/for-6.12] workqueue: Fix another htmldocs build warning
  2024-08-21 16:39 ` [PATCH wq/for-6.12] workqueue: Fix another htmldocs build warning Tejun Heo
@ 2024-08-22  3:24   ` Matthew Brost
  0 siblings, 0 replies; 3+ messages in thread
From: Matthew Brost @ 2024-08-22  3:24 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Stephen Rothwell, Linux Kernel Mailing List,
	Linux Next Mailing List

On Wed, Aug 21, 2024 at 06:39:34AM -1000, Tejun Heo wrote:
> From d156263e247c334a8872578118e0709ed63c4806 Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@kernel.org>
> Date: Wed, 21 Aug 2024 06:37:39 -1000
> 
> Fix htmldocs build warning introduced by 9b59a85a84dc ("workqueue: Don't
> call va_start / va_end twice").
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  include/linux/workqueue.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
> index f3cc15940b4d..59c2695e12e7 100644
> --- a/include/linux/workqueue.h
> +++ b/include/linux/workqueue.h
> @@ -534,7 +534,7 @@ alloc_workqueue_lockdep_map(const char *fmt, unsigned int flags, int max_active,
>   * @fmt: printf format for the name of the workqueue
>   * @flags: WQ_* flags (only WQ_FREEZABLE and WQ_MEM_RECLAIM are meaningful)
>   * @lockdep_map: user-defined lockdep_map
> - * @...: args for @fmt
> + * @args: args for @fmt
>   *
>   * Same as alloc_ordered_workqueue but with the a user-define lockdep_map.
>   * Useful for workqueues created with the same purpose and to avoid leaking a
> @@ -544,7 +544,8 @@ alloc_workqueue_lockdep_map(const char *fmt, unsigned int flags, int max_active,
>   * Pointer to the allocated workqueue on success, %NULL on failure.
>   */
>  #define alloc_ordered_workqueue_lockdep_map(fmt, flags, lockdep_map, args...)	\
> -	alloc_workqueue_lockdep_map(fmt, WQ_UNBOUND | __WQ_ORDERED | (flags), 1, lockdep_map, ##args)
> +	alloc_workqueue_lockdep_map(fmt, WQ_UNBOUND | __WQ_ORDERED | (flags),	\
> +				    1, lockdep_map, ##args)
>  #endif
>  
>  /**
> -- 
> 2.46.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-22  3:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21  3:45 linux-next: build warning after merge of the workqueues tree Stephen Rothwell
2024-08-21 16:39 ` [PATCH wq/for-6.12] workqueue: Fix another htmldocs build warning Tejun Heo
2024-08-22  3:24   ` Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox