linux-next: Fixes tag needs some work in the perf-current tree

linux-next: Fixes tag needs some work in the perf-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi all,

In commit

  5c34aea341b1 ("perf test: Fix DWARF unwind for optimized builds.")

Fixes tag

  Fixes: 9ae1e990f1ab ("perf tools: Remove broken __no_tail_call

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more then one line.  Also keep all
the commit message tags together at the end fo the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the perf-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Hi all,

In commit

  387ad33e5410 ("perf test pmu: Set uninitialized PMU alias to null")

Fixes tag

  Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")

has these problem(s):

  - Target SHA1 does not exist

Actually, the quoted SHA1 is too short and is ambiguous in my tree:

$ git show 3e0bf9
error: short object ID 3e0bf9 is ambiguous
hint: The candidates are:
hint:   3e0bf9fde298 commit 2024-06-26 - perf pmu: Restore full PMU name wildcard support
hint:   3e0bf93e0354 tree
fatal: ambiguous argument '3e0bf9': unknown revision or path not in the working tree.

so you should use

Fixes: 3e0bf9fde298 ("perf pmu: Restore full PMU name wildcard support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the perf-current tree

[Arnaldo Carvalho de Melo]

On Mon, Sep 02, 2024 at 08:18:37AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   387ad33e5410 ("perf test pmu: Set uninitialized PMU alias to null")
> 
> Fixes tag
> 
>   Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")

In the perf-tools-next I have it as:

commit 37e2a19c98bf99747ca997be876dfc13f9165e0a
Author: Veronika Molnarova <vmolnaro@redhat.com>
Date:   Thu Aug 8 12:37:49 2024 +0200

    perf test pmu: Set uninitialized PMU alias to null
    
    Commit 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard
    support") adds a test case "PMU cmdline match" that covers PMU name
    wildcard support provided by function perf_pmu__match().
<SNIP>
    Fixes: 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard support")
    Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
    Cc: James Clark <james.clark@linaro.org>
    Cc: Michael Petlan <mpetlan@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Radostin Stoyanov <rstoyano@redhat.com>
    Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

As I have:

⬢[acme@toolbox perf-tools-next]$ git config core.abbrev
16
⬢[acme@toolbox perf-tools-next]$

And scripts to make sure we get enough resolution to avoid such problems

I just checked and yeah, on perf-tools/perf-tools it is:

    Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
    Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
    Cc: james.clark@arm.com
    Cc: mpetlan@redhat.com
    Cc: rstoyano@redhat.com
    Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
    Signed-off-by: Namhyung Kim <namhyung@kernel.org>

So I suggest Namhyung fixes up the Fixes tag to have a longer prefix for
the sha and Veronica to run:

⬢[acme@toolbox perf-tools]$ git config core.abbrev 16
⬢[acme@toolbox perf-tools]$ git config core.abbrev
16
⬢[acme@toolbox perf-tools]$ 

- Arnaldo

 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Actually, the quoted SHA1 is too short and is ambiguous in my tree:
> 
> $ git show 3e0bf9
> error: short object ID 3e0bf9 is ambiguous
> hint: The candidates are:
> hint:   3e0bf9fde298 commit 2024-06-26 - perf pmu: Restore full PMU name wildcard support
> hint:   3e0bf93e0354 tree
> fatal: ambiguous argument '3e0bf9': unknown revision or path not in the working tree.
> 
> so you should use
> 
> Fixes: 3e0bf9fde298 ("perf pmu: Restore full PMU name wildcard support")
> 
> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the perf-current tree

[Namhyung Kim]

On Mon, Sep 2, 2024 at 11:42 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Mon, Sep 02, 2024 at 08:18:37AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   387ad33e5410 ("perf test pmu: Set uninitialized PMU alias to null")
> >
> > Fixes tag
> >
> >   Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
>
> In the perf-tools-next I have it as:
>
> commit 37e2a19c98bf99747ca997be876dfc13f9165e0a
> Author: Veronika Molnarova <vmolnaro@redhat.com>
> Date:   Thu Aug 8 12:37:49 2024 +0200
>
>     perf test pmu: Set uninitialized PMU alias to null
>
>     Commit 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard
>     support") adds a test case "PMU cmdline match" that covers PMU name
>     wildcard support provided by function perf_pmu__match().
> <SNIP>
>     Fixes: 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard support")
>     Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
>     Cc: James Clark <james.clark@linaro.org>
>     Cc: Michael Petlan <mpetlan@redhat.com>
>     Cc: Namhyung Kim <namhyung@kernel.org>
>     Cc: Radostin Stoyanov <rstoyano@redhat.com>
>     Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
>     Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Ok, you only updated perf-tools-next.  I thought you did it on
perf-tools too.  I'll update perf-tools soon.

>
> As I have:
>
> ⬢[acme@toolbox perf-tools-next]$ git config core.abbrev
> 16
> ⬢[acme@toolbox perf-tools-next]$
>
> And scripts to make sure we get enough resolution to avoid such problems

Sure, will do.

>
> I just checked and yeah, on perf-tools/perf-tools it is:
>
>     Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
>     Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
>     Cc: james.clark@arm.com
>     Cc: mpetlan@redhat.com
>     Cc: rstoyano@redhat.com
>     Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
>     Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> So I suggest Namhyung fixes up the Fixes tag to have a longer prefix for
> the sha and Veronica to run:
>
> ⬢[acme@toolbox perf-tools]$ git config core.abbrev 16
> ⬢[acme@toolbox perf-tools]$ git config core.abbrev
> 16
> ⬢[acme@toolbox perf-tools]$

Yep, thanks!
Namhyung

>
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Actually, the quoted SHA1 is too short and is ambiguous in my tree:
> >
> > $ git show 3e0bf9
> > error: short object ID 3e0bf9 is ambiguous
> > hint: The candidates are:
> > hint:   3e0bf9fde298 commit 2024-06-26 - perf pmu: Restore full PMU name wildcard support
> > hint:   3e0bf93e0354 tree
> > fatal: ambiguous argument '3e0bf9': unknown revision or path not in the working tree.
> >
> > so you should use
> >
> > Fixes: 3e0bf9fde298 ("perf pmu: Restore full PMU name wildcard support")
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>

Re: linux-next: Fixes tag needs some work in the perf-current tree

[Veronika Molnarova]

On 9/2/24 20:42, Arnaldo Carvalho de Melo wrote:
> On Mon, Sep 02, 2024 at 08:18:37AM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>   387ad33e5410 ("perf test pmu: Set uninitialized PMU alias to null")
>>
>> Fixes tag
>>
>>   Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
> 
> In the perf-tools-next I have it as:
> 
> commit 37e2a19c98bf99747ca997be876dfc13f9165e0a
> Author: Veronika Molnarova <vmolnaro@redhat.com>
> Date:   Thu Aug 8 12:37:49 2024 +0200
> 
>     perf test pmu: Set uninitialized PMU alias to null
>     
>     Commit 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard
>     support") adds a test case "PMU cmdline match" that covers PMU name
>     wildcard support provided by function perf_pmu__match().
> <SNIP>
>     Fixes: 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard support")
>     Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
>     Cc: James Clark <james.clark@linaro.org>
>     Cc: Michael Petlan <mpetlan@redhat.com>
>     Cc: Namhyung Kim <namhyung@kernel.org>
>     Cc: Radostin Stoyanov <rstoyano@redhat.com>
>     Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
>     Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> As I have:
> 
> ⬢[acme@toolbox perf-tools-next]$ git config core.abbrev
> 16
> ⬢[acme@toolbox perf-tools-next]$
> 
> And scripts to make sure we get enough resolution to avoid such problems
> 
> I just checked and yeah, on perf-tools/perf-tools it is:
> 
>     Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
>     Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
>     Cc: james.clark@arm.com
>     Cc: mpetlan@redhat.com
>     Cc: rstoyano@redhat.com
>     Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@redhat.com
>     Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> So I suggest Namhyung fixes up the Fixes tag to have a longer prefix for
> the sha and Veronica to run:
> 
> ⬢[acme@toolbox perf-tools]$ git config core.abbrev 16
> ⬢[acme@toolbox perf-tools]$ git config core.abbrev
> 16
> ⬢[acme@toolbox perf-tools]$ 
> 
> - Arnaldo
> 
Sure, will do.

Sorry for the inconvenience.
Thanks,
Veronika

>  
>> has these problem(s):
>>
>>   - Target SHA1 does not exist
>>
>> Actually, the quoted SHA1 is too short and is ambiguous in my tree:
>>
>> $ git show 3e0bf9
>> error: short object ID 3e0bf9 is ambiguous
>> hint: The candidates are:
>> hint:   3e0bf9fde298 commit 2024-06-26 - perf pmu: Restore full PMU name wildcard support
>> hint:   3e0bf93e0354 tree
>> fatal: ambiguous argument '3e0bf9': unknown revision or path not in the working tree.
>>
>> so you should use
>>
>> Fixes: 3e0bf9fde298 ("perf pmu: Restore full PMU name wildcard support")
>>
>> -- 
>> Cheers,
>> Stephen Rothwell
> 
>