linux-next: Signed-off-by missing for commit in the gfs2 tree

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Hi all,

Commit

  507da2cb5d8a ("KMSAN: uninit-value in inode_go_dump (5)")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Qianqiang Liu]

Hi Stephen,

> Commit
> 
>  507da2cb5d8a ("KMSAN: uninit-value in inode_go_dump (5)")
> 
> is missing a Signed-off-by from its author.
> 
> --
> Cheers,
> Stephen Rothwell
> <mime-attachment>

Yes, you’re right!

Do you how to solve this? The commit is already in linux-next tree.

—
Best,
Qianqiang Liu

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Andreas Gruenbacher]

On Tue, Oct 22, 2024 at 1:23 PM Qianqiang Liu <qianqiang.liu@163.com> wrote:
> Hi Stephen,
>
> > Commit
> >
> >  507da2cb5d8a ("KMSAN: uninit-value in inode_go_dump (5)")
> >
> > is missing a Signed-off-by from its author.
> >
> > --
> > Cheers,
> > Stephen Rothwell
> > <mime-attachment>
>
> Yes, you’re right!
>
> Do you how to solve this? The commit is already in linux-next tree.

Can you resend the patch with a Signed-off-by tag?

Thanks,
Andreas

[PATCH v2] KMSAN: uninit-value in inode_go_dump (5)

[Qianqiang Liu]

When mounting of a corrupted disk image fails, the error message printed
can reference uninitialized inode fields.  To prevent that from happening,
always initialize those fields.

Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
Reported-by: syzbot+aa0730b0a42646eb1359@syzkaller.appspotmail.com
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 Changes since v1:
 - Add Signed-off-by tag
---
 fs/gfs2/super.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 23e3a85ab7ef..aadb83e38c17 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -1553,11 +1553,13 @@ static struct inode *gfs2_alloc_inode(struct super_block *sb)
 	if (!ip)
 		return NULL;
 	ip->i_no_addr = 0;
+	ip->i_no_formal_ino = 0;
 	ip->i_flags = 0;
 	ip->i_gl = NULL;
 	gfs2_holder_mark_uninitialized(&ip->i_iopen_gh);
 	memset(&ip->i_res, 0, sizeof(ip->i_res));
 	RB_CLEAR_NODE(&ip->i_res.rs_node);
+	ip->i_diskflags = 0;
 	ip->i_rahead = 0;
 	return &ip->i_inode;
 }
-- 
2.47.0