From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Tao Zhou <tao.zhou1@amd.com>,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
hawking.zhang@amd.com, dennis.li@amd.com, broonie@kernel.org
Cc: linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-build-reports@lists.linaro.org
Subject: Re: [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH
Date: Tue, 6 Aug 2019 13:26:35 +0200 [thread overview]
Message-ID: <a19ac490-a803-84c0-5598-e78edbb3447b@gmail.com> (raw)
In-Reply-To: <20190806103156.3778-1-tao.zhou1@amd.com>
Am 06.08.19 um 12:31 schrieb Tao Zhou:
> readq/writeq can't be found on arm architecture, implement them
> with 32 bits operations
Mhm, wasn't the whole point about using readq/writeq that we needed
64bit atomic operations?
Christian.
>
> Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index f62d4f30e810..aaf7f31cf8df 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -29,6 +29,7 @@
> #include <linux/kthread.h>
> #include <linux/console.h>
> #include <linux/slab.h>
> +#include <linux/io-64-nonatomic-lo-hi.h>
> #include <drm/drmP.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_probe_helper.h>
next prev parent reply other threads:[~2019-08-06 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 10:31 [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH Tao Zhou
2019-08-06 11:26 ` Christian König [this message]
2019-08-06 19:45 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19ac490-a803-84c0-5598-e78edbb3447b@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=broonie@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dennis.li@amd.com \
--cc=hawking.zhang@amd.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=tao.zhou1@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox