* [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH
@ 2019-08-06 10:31 Tao Zhou
2019-08-06 11:26 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Tao Zhou @ 2019-08-06 10:31 UTC (permalink / raw)
To: amd-gfx, alexander.deucher, hawking.zhang, dennis.li, broonie
Cc: kernel-build-reports, linux-arm-kernel, linux-next, Tao Zhou
readq/writeq can't be found on arm architecture, implement them
with 32 bits operations
Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index f62d4f30e810..aaf7f31cf8df 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -29,6 +29,7 @@
#include <linux/kthread.h>
#include <linux/console.h>
#include <linux/slab.h>
+#include <linux/io-64-nonatomic-lo-hi.h>
#include <drm/drmP.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_probe_helper.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH
2019-08-06 10:31 [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH Tao Zhou
@ 2019-08-06 11:26 ` Christian König
2019-08-06 19:45 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2019-08-06 11:26 UTC (permalink / raw)
To: Tao Zhou, amd-gfx, alexander.deucher, hawking.zhang, dennis.li,
broonie
Cc: linux-next, linux-arm-kernel, kernel-build-reports
Am 06.08.19 um 12:31 schrieb Tao Zhou:
> readq/writeq can't be found on arm architecture, implement them
> with 32 bits operations
Mhm, wasn't the whole point about using readq/writeq that we needed
64bit atomic operations?
Christian.
>
> Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index f62d4f30e810..aaf7f31cf8df 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -29,6 +29,7 @@
> #include <linux/kthread.h>
> #include <linux/console.h>
> #include <linux/slab.h>
> +#include <linux/io-64-nonatomic-lo-hi.h>
> #include <drm/drmP.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_probe_helper.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH
2019-08-06 11:26 ` Christian König
@ 2019-08-06 19:45 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2019-08-06 19:45 UTC (permalink / raw)
To: Christian Koenig
Cc: Tao Zhou, amd-gfx list, Deucher, Alexander, Hawking Zhang,
Dennis Li, Mark Brown, Linux-Next Mailing List, linux-arm-kernel,
kernel-build-reports
On Tue, Aug 6, 2019 at 7:26 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 06.08.19 um 12:31 schrieb Tao Zhou:
> > readq/writeq can't be found on arm architecture, implement them
> > with 32 bits operations
>
> Mhm, wasn't the whole point about using readq/writeq that we needed
> 64bit atomic operations?
It might be better to use atomic64_read/atomic64_set like we do for doorbells.
Alex
>
> Christian.
>
> >
> > Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index f62d4f30e810..aaf7f31cf8df 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -29,6 +29,7 @@
> > #include <linux/kthread.h>
> > #include <linux/console.h>
> > #include <linux/slab.h>
> > +#include <linux/io-64-nonatomic-lo-hi.h>
> > #include <drm/drmP.h>
> > #include <drm/drm_atomic_helper.h>
> > #include <drm/drm_probe_helper.h>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-06 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06 10:31 [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH Tao Zhou
2019-08-06 11:26 ` Christian König
2019-08-06 19:45 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox