From: Brian King <brking@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the scsi-mkp tree
Date: Fri, 6 Mar 2020 09:30:42 -0600 [thread overview]
Message-ID: <a2fdf25f-5ec1-5997-ad6f-33b1c000d6a8@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200306155209.34e85ab2@canb.auug.org.au>
On 3/5/20 10:52 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 2 Mar 2020 08:36:20 -0600 Brian King <brking@linux.vnet.ibm.com> wrote:
>>
>> On 3/1/20 8:35 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the scsi-mkp tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>>
>>> In file included from include/uapi/linux/posix_types.h:5,
>>> from include/uapi/linux/types.h:14,
>>> from include/linux/types.h:6,
>>> from include/linux/list.h:5,
>>> from include/linux/module.h:12,
>>> from drivers/scsi/ibmvscsi/ibmvfc.c:10:
>>> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
>>> include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
>>> 8 | #define NULL ((void *)0)
>>> | ^
>>> drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
>>> 3644 | return NULL;
>>> | ^~~~
>>> drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
>>> 3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Introduced by commit
>>>
>>> 54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
>>
>> Thanks. I'll send the one line fix.
>
> I am still getting this warning, but it is now after the merge of the
> scsi tree.
>
I sent the fix to the list, waiting for it to get pulled in:
https://marc.info/?l=linux-scsi&m=158315998321290&w=2
--
Brian King
Power Linux I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2020-03-06 15:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 2:35 linux-next: build warning after merge of the scsi-mkp tree Stephen Rothwell
2020-03-02 14:36 ` Brian King
2020-03-06 4:52 ` Stephen Rothwell
2020-03-06 15:30 ` Brian King [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-28 3:13 Stephen Rothwell
2023-07-24 4:04 Stephen Rothwell
2023-07-26 2:13 ` Martin K. Petersen
2023-05-23 3:38 Stephen Rothwell
2023-05-23 6:38 ` Damien Le Moal
2023-05-23 7:49 ` Damien Le Moal
2021-10-18 20:41 Stephen Rothwell
2021-11-08 0:06 ` Stephen Rothwell
2021-11-08 14:36 ` James Bottomley
2018-12-20 6:34 Stephen Rothwell
2018-10-12 5:10 Stephen Rothwell
2018-07-11 4:17 Stephen Rothwell
2018-07-12 4:30 ` Stephen Rothwell
2018-07-12 6:10 ` Hannes Reinecke
2017-09-26 4:09 Stephen Rothwell
2017-09-27 3:27 ` Stephen Rothwell
2017-08-24 5:57 Stephen Rothwell
2017-08-24 5:59 ` Stephen Rothwell
2016-11-14 5:16 Stephen Rothwell
2016-11-14 12:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2fdf25f-5ec1-5997-ad6f-33b1c000d6a8@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).