linux-next: build failure after merge of the kvm-fixes tree

linux-next: build failure after merge of the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Hi all,

After merging the kvm-fixes tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "kvm_arch_has_irq_bypass" [arch/x86/kvm/kvm-amd.ko] undefined!

Caused by commit

  73e0c567c24a ("KVM: SVM: Don't update IRTEs if APICv/AVIC is disabled")

I have used the kvm-fixes tree from next-20250417 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Hi all,

On Tue, 22 Apr 2025 12:43:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the kvm-fixes tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: "kvm_arch_has_irq_bypass" [arch/x86/kvm/kvm-amd.ko] undefined!
> 
> Caused by commit
> 
>   73e0c567c24a ("KVM: SVM: Don't update IRTEs if APICv/AVIC is disabled")
> 
> I have used the kvm-fixes tree from next-20250417 for today.

I also had to use the kvm tree from next-20250417.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kvm-fixes tree

[Sean Christopherson]

On Tue, Apr 22, 2025, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 22 Apr 2025 12:43:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the kvm-fixes tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > ERROR: modpost: "kvm_arch_has_irq_bypass" [arch/x86/kvm/kvm-amd.ko] undefined!
> > 
> > Caused by commit
> > 
> >   73e0c567c24a ("KVM: SVM: Don't update IRTEs if APICv/AVIC is disabled")
> > 
> > I have used the kvm-fixes tree from next-20250417 for today.
> 
> I also had to use the kvm tree from next-20250417.

It's a known issue[*], just waiting on Paolo to resurface.  :-/

[*] https://lore.kernel.org/all/20250418171609.231588-1-pbonzini@redhat.com

Re: linux-next: build failure after merge of the kvm-fixes tree

[Paolo Bonzini]

On 4/22/25 16:00, Sean Christopherson wrote:
> On Tue, Apr 22, 2025, Stephen Rothwell wrote:
>> Hi all,
>>
>> On Tue, 22 Apr 2025 12:43:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> After merging the kvm-fixes tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> ERROR: modpost: "kvm_arch_has_irq_bypass" [arch/x86/kvm/kvm-amd.ko] undefined!
>>>
>>> Caused by commit
>>>
>>>    73e0c567c24a ("KVM: SVM: Don't update IRTEs if APICv/AVIC is disabled")
>>>
>>> I have used the kvm-fixes tree from next-20250417 for today.
>>
>> I also had to use the kvm tree from next-20250417.
> 
> It's a known issue[*], just waiting on Paolo to resurface.  :-/

*bubbles noise*

Done, pushed to kvm/master and will resend the PR to Linus as soon as 
Stephen updates linux-next.

Paolo

> [*] https://lore.kernel.org/all/20250418171609.231588-1-pbonzini@redhat.com
> 

linux-next: build failure after merge of the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

Hi all,

After merging the kvm-fixes tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from arch/powerpc/include/asm/kvm_ppc.h:19,
                 from arch/powerpc/include/asm/dbell.h:17,
                 from arch/powerpc/kernel/asm-offsets.c:38:
include/linux/kvm_host.h: In function 'kvm_vcpu_can_poll':
include/linux/kvm_host.h:270:9: error: implicit declaration of function 'single_task_running' [-Werror=implicit-function-declaration]
  270 |  return single_task_running() && !need_resched() && ktime_before(cur, stop);
      |         ^~~~~~~~~~~~~~~~~~~

Caused by commit

  85d4c3baeb45 ("KVM: PPC: exit halt polling on need_resched()")

I have used the kvm-fixes tree from next-20210524 again today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kvm-fixes tree

[Wanpeng Li]

On Thu, 27 May 2021 at 10:50, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kvm-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from arch/powerpc/include/asm/kvm_ppc.h:19,
>                  from arch/powerpc/include/asm/dbell.h:17,
>                  from arch/powerpc/kernel/asm-offsets.c:38:
> include/linux/kvm_host.h: In function 'kvm_vcpu_can_poll':
> include/linux/kvm_host.h:270:9: error: implicit declaration of function 'single_task_running' [-Werror=implicit-function-declaration]
>   270 |  return single_task_running() && !need_resched() && ktime_before(cur, stop);
>       |         ^~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   85d4c3baeb45 ("KVM: PPC: exit halt polling on need_resched()")
>
> I have used the kvm-fixes tree from next-20210524 again today.

The kvm/master is broken by several patches.

diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
index 0f6f394..e851671 100644
--- a/arch/x86/kvm/hyperv.c
+++ b/arch/x86/kvm/hyperv.c
@@ -1659,7 +1659,7 @@ struct kvm_hv_hcall {

 static u64 kvm_hv_flush_tlb(struct kvm_vcpu *vcpu, struct
kvm_hv_hcall *hc, bool ex)
 {
-    int i, j;
+    int i;
     gpa_t gpa;
     struct kvm *kvm = vcpu->kvm;
     struct kvm_vcpu_hv *hv_vcpu = to_hv_vcpu(vcpu);
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 9d095bed..feb9611 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -3604,7 +3604,7 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu,
struct msr_data *msr_info)
          * to ensure backwards-compatible behavior for migration.
          */
         if (msr_info->host_initiated &&
-            kvm_check_has_quirk(vcpu->kvm, KVM_X86_QUIRK_TSC_HOST_ACCESS))
+            kvm_check_has_quirk(vcpu->kvm, KVM_X86_QUIRK_TSC_HOST_ACCESS)) {
             offset = vcpu->arch.l1_tsc_offset;
             ratio = vcpu->arch.l1_tsc_scaling_ratio;
         } else {
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 18905c9..4273e04 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -10,6 +10,7 @@
 #include <linux/spinlock.h>
 #include <linux/signal.h>
 #include <linux/sched.h>
+#include <linux/sched/stat.h>
 #include <linux/bug.h>
 #include <linux/minmax.h>
 #include <linux/mm.h>

Re: linux-next: build failure after merge of the kvm-fixes tree

[Paolo Bonzini]

On 27/05/21 06:56, Wanpeng Li wrote:
> On Thu, 27 May 2021 at 10:50, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> After merging the kvm-fixes tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> In file included from arch/powerpc/include/asm/kvm_ppc.h:19,
>>                   from arch/powerpc/include/asm/dbell.h:17,
>>                   from arch/powerpc/kernel/asm-offsets.c:38:
>> include/linux/kvm_host.h: In function 'kvm_vcpu_can_poll':
>> include/linux/kvm_host.h:270:9: error: implicit declaration of function 'single_task_running' [-Werror=implicit-function-declaration]
>>    270 |  return single_task_running() && !need_resched() && ktime_before(cur, stop);
>>        |         ^~~~~~~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>>    85d4c3baeb45 ("KVM: PPC: exit halt polling on need_resched()")
>>
>> I have used the kvm-fixes tree from next-20210524 again today.
> 
> The kvm/master is broken by several patches.

I made a mess and pushed a bunch of 5.13 patches to it.  Apologies 
everyone, I will rewind kvm/master.  If you had checked it out 
yesterday, be careful to remove anything not belonging to your tree.

Paolo

> diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
> index 0f6f394..e851671 100644
> --- a/arch/x86/kvm/hyperv.c
> +++ b/arch/x86/kvm/hyperv.c
> @@ -1659,7 +1659,7 @@ struct kvm_hv_hcall {
> 
>   static u64 kvm_hv_flush_tlb(struct kvm_vcpu *vcpu, struct
> kvm_hv_hcall *hc, bool ex)
>   {
> -    int i, j;
> +    int i;
>       gpa_t gpa;
>       struct kvm *kvm = vcpu->kvm;
>       struct kvm_vcpu_hv *hv_vcpu = to_hv_vcpu(vcpu);
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 9d095bed..feb9611 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3604,7 +3604,7 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu,
> struct msr_data *msr_info)
>            * to ensure backwards-compatible behavior for migration.
>            */
>           if (msr_info->host_initiated &&
> -            kvm_check_has_quirk(vcpu->kvm, KVM_X86_QUIRK_TSC_HOST_ACCESS))
> +            kvm_check_has_quirk(vcpu->kvm, KVM_X86_QUIRK_TSC_HOST_ACCESS)) {
>               offset = vcpu->arch.l1_tsc_offset;
>               ratio = vcpu->arch.l1_tsc_scaling_ratio;
>           } else {
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 18905c9..4273e04 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -10,6 +10,7 @@
>   #include <linux/spinlock.h>
>   #include <linux/signal.h>
>   #include <linux/sched.h>
> +#include <linux/sched/stat.h>
>   #include <linux/bug.h>
>   #include <linux/minmax.h>
>   #include <linux/mm.h>
> 

linux-next: build failure after merge of the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

After merging the kvm-fixes tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: modpost: ".kvm_vcpu_can_poll" [arch/powerpc/kvm/kvm-hv.ko] undefined!

Caused by commit

  0fee89fbc44b ("KVM: PPC: exit halt polling on need_resched()")

I have used the kvm-fixes tree from next-20210524 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kvm-fixes tree

[Wanpeng Li]

On Tue, 25 May 2021 at 07:33, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kvm-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ERROR: modpost: ".kvm_vcpu_can_poll" [arch/powerpc/kvm/kvm-hv.ko] undefined!
>
> Caused by commit
>
>   0fee89fbc44b ("KVM: PPC: exit halt polling on need_resched()")

This is my fault.

From b2a6d98b48fc6b22a0b47f57a98dc3203c678195 Mon Sep 17 00:00:00 2001
From: Wanpeng Li <wanpengli@tencent.com>
Date: Tue, 25 May 2021 07:50:08 +0800
Subject: [PATCH] KVM: Fix ERROR: modpost: .kvm_vcpu_can_poll undefined!

From: Wanpeng Li <wanpengli@tencent.com>

Export kvm_vcpu_can_poll to fix ERROR: modpost: .kvm_vcpu_can_poll undefined!

Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
---
 virt/kvm/kvm_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 62522c1..8eaec42 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -2949,6 +2949,7 @@ bool kvm_vcpu_can_poll(ktime_t cur, ktime_t stop)
 {
     return single_task_running() && !need_resched() && ktime_before(cur, stop);
 }
+EXPORT_SYMBOL_GPL(kvm_vcpu_can_poll);

 /*
  * The vCPU has executed a HLT instruction with in-kernel mode enabled.
--
2.7.4