From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Greg KH <greg@kroah.com>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the char-misc tree
Date: Thu, 1 May 2025 07:15:09 -0300 [thread overview]
Message-ID: <aBNJrYN1ThMwsLYT@quatroqueijos> (raw)
In-Reply-To: <20250501164501.0fc0ab68@canb.auug.org.au>
On Thu, May 01, 2025 at 04:45:01PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the char-misc tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: warning: discarding dynamic section .glink
> ld: warning: discarding dynamic section .plt
> ld: linkage table error against `__kunit_do_failed_assertion'
> ld: stubs don't match calculated size
> ld: can not build stubs: bad value
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_duplicate_minor':
> misc_minor_kunit.c:(.text+0x180): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.text+0x1e4): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.text+0x240): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_twice':
> misc_minor_kunit.c:(.text+0x3e8): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.text+0x458): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o:misc_minor_kunit.c:(.text+0x4c4): more undefined references to `__kunit_do_failed_assertion' follow
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_find_minors':
> misc_minor_kunit.c:(.text+0xb3c): undefined reference to `kunit_log_append'
> ld: misc_minor_kunit.c:(.text+0xbac): undefined reference to `kunit_log_append'
> ld: misc_minor_kunit.c:(.text+0xc1c): undefined reference to `kunit_log_append'
> ld: misc_minor_kunit.c:(.text+0xc88): undefined reference to `kunit_log_append'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_duplicate_name':
> misc_minor_kunit.c:(.text+0xee4): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.text+0xf40): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.text+0xf90): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_duplicate_error':
> misc_minor_kunit.c:(.text+0x11b4): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.text+0x1210): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o:misc_minor_kunit.c:(.text+0x1264): more undefined references to `__kunit_do_failed_assertion' follow
> ld: drivers/misc/misc_minor_kunit.o:(.toc+0x0): undefined reference to `kunit_binary_assert_format'
> ld: drivers/misc/misc_minor_kunit.o:(.toc+0x8): undefined reference to `kunit_fail_assert_format'
> ld: drivers/misc/misc_minor_kunit.o:(.toc+0x10): undefined reference to `kunit_unary_assert_format'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_can_open':
> misc_minor_kunit.c:(.init.text+0xc0): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x134): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_static_basic':
> misc_minor_kunit.c:(.init.text+0x25c): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x2b4): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_conflict_reverse':
> misc_minor_kunit.c:(.init.text+0x408): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x414): undefined reference to `__kunit_abort'
> ld: misc_minor_kunit.c:(.init.text+0x46c): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x4d8): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x530): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x590): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x5e4): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o:misc_minor_kunit.c:(.init.text+0x63c): more undefined references to `__kunit_do_failed_assertion' follow
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_conflict':
> misc_minor_kunit.c:(.init.text+0x7a0): undefined reference to `__kunit_abort'
> ld: misc_minor_kunit.c:(.init.text+0x7f8): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x85c): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_dynamic_basic':
> misc_minor_kunit.c:(.init.text+0x994): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x9ec): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_collision_reverse':
> misc_minor_kunit.c:(.init.text+0xb20): undefined reference to `kunit_kmalloc_array'
> ld: misc_minor_kunit.c:(.init.text+0xba8): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0xc00): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0xc64): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0xcc0): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_collision':
> misc_minor_kunit.c:(.init.text+0xe30): undefined reference to `kunit_kmalloc_array'
> ld: misc_minor_kunit.c:(.init.text+0xe98): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0xea4): undefined reference to `__kunit_abort'
> ld: misc_minor_kunit.c:(.init.text+0xf04): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0xfac): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x1058): undefined reference to `__kunit_do_failed_assertion'
> ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_dynamic_only_range':
> misc_minor_kunit.c:(.init.text+0x1174): undefined reference to `kunit_kmalloc_array'
> ld: misc_minor_kunit.c:(.init.text+0x1200): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x1248): undefined reference to `__kunit_do_failed_assertion'
> ld: misc_minor_kunit.c:(.init.text+0x12ec): undefined reference to `__kunit_do_failed_assertion'
>
> Caused by commit
>
> 20acf4dd46e4 ("char: misc: make miscdevice unit test built-in only")
>
> $ grep CONFIG_KUNIT .config
> CONFIG_KUNIT=m
> CONFIG_KUNIT_DEBUGFS=y
> CONFIG_KUNIT_FAULT_TEST=y
> CONFIG_KUNIT_TEST=m
> CONFIG_KUNIT_EXAMPLE_TEST=m
> CONFIG_KUNIT_ALL_TESTS=m
> CONFIG_KUNIT_DEFAULT_ENABLED=y
> CONFIG_KUNIT_AUTORUN_ENABLED=y
> $ grep CONFIG_TEST_MINOR .config
> $
>
> I have used the char-misc tree from next-20250428 again.
>
> --
> Cheers,
> Stephen Rothwell
This should fix it. I am sorry for still breaking all these builds. I have
tested this with the ppc64_defconfig (though that had required me to "fix" a
couple of warnings-turned-to-errors under arch/powerpc/). As I am trying to fix
this quickly, I haven't checked other configs. Again, I am sorry for the trouble.
Greg, I understand this may have caused you concern about merging this. Let
me know if you want to apply the fix below and have me submit it properly
or if we should wait for another cycle before applying a v5 after further
testing.
Cascardo.
From 9e3150cb663e17b748cce6373c2f2b491a14b1a3 Mon Sep 17 00:00:00 2001
From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Date: Wed, 30 Apr 2025 08:30:47 -0300
Subject: [PATCH] char: misc: make miscdevice unit test require CONFIG_KUNIT=y
Otherwise, it allows for CONFIG_KUNIT=m, and that leads to build failures
like:
ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_duplicate_minor':
misc_minor_kunit.c:(.text+0x180): undefined reference to `__kunit_do_failed_assertion'
ld: misc_minor_kunit.c:(.text+0x1e4): undefined reference to `__kunit_do_failed_assertion'
ld: misc_minor_kunit.c:(.text+0x240): undefined reference to `__kunit_do_failed_assertion'
ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_test_twice':
misc_minor_kunit.c:(.text+0x3e8): undefined reference to `__kunit_do_failed_assertion'
ld: misc_minor_kunit.c:(.text+0x458): undefined reference to `__kunit_do_failed_assertion'
ld: drivers/misc/misc_minor_kunit.o:misc_minor_kunit.c:(.text+0x4c4): more undefined references to `__kunit_do_failed_assertion' follow
ld: drivers/misc/misc_minor_kunit.o: in function `miscdev_find_minors':
misc_minor_kunit.c:(.text+0xb3c): undefined reference to `kunit_log_append'
ld: misc_minor_kunit.c:(.text+0xbac): undefined reference to `kunit_log_append'
ld: misc_minor_kunit.c:(.text+0xc1c): undefined reference to `kunit_log_append'
ld: misc_minor_kunit.c:(.text+0xc88): undefined reference to `kunit_log_append'
[...]
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/linux-next/20250501164501.0fc0ab68@canb.auug.org.au/
Fixes: 45f0de4f8dc3 ("char: misc: add test cases")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 0117b852bd13..4049851e5115 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2513,7 +2513,7 @@ config TEST_IDA
config TEST_MISC_MINOR
bool "miscdevice KUnit test" if !KUNIT_ALL_TESTS
- depends on KUNIT
+ depends on KUNIT=y
default KUNIT_ALL_TESTS
help
Kunit test for miscdevice API, specially its behavior in respect to
--
2.47.2
next prev parent reply other threads:[~2025-05-01 10:15 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 6:45 linux-next: build failure after merge of the char-misc tree Stephen Rothwell
2025-05-01 7:26 ` Greg KH
2025-05-01 10:15 ` Thadeu Lima de Souza Cascardo [this message]
2025-05-01 14:20 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2025-07-03 11:20 回复: 回复: 回复: " Greg KH
2025-07-04 1:32 ` Lizhi Xu
2025-07-03 7:10 Stephen Rothwell
2025-07-03 8:30 ` Greg KH
2025-05-05 6:08 Stephen Rothwell
2025-05-05 6:12 ` Stephen Rothwell
2025-05-05 7:14 ` Stephen Rothwell
2025-05-05 7:39 ` Thomas Weißschuh
2025-05-05 8:28 ` Stephen Rothwell
2025-04-29 5:54 Stephen Rothwell
2025-04-29 10:58 ` Thadeu Lima de Souza Cascardo
2025-04-30 12:16 ` Thadeu Lima de Souza Cascardo
2025-04-30 14:09 ` Greg Kroah-Hartman
2023-06-26 4:25 Stephen Rothwell
2023-06-26 9:06 ` Greg KH
2022-05-20 9:46 Stephen Rothwell
2022-05-20 19:08 ` Greg KH
2022-06-12 17:23 ` Samuel Thibault
2022-02-25 20:40 broonie
2022-02-26 15:08 ` Greg KH
2022-03-01 5:14 ` Stephen Rothwell
2022-03-01 21:27 ` Greg KH
2021-10-27 4:48 Stephen Rothwell
2021-10-27 6:51 ` Greg KH
2020-07-27 8:08 Stephen Rothwell
2020-07-27 9:24 ` Greg KH
2020-07-27 9:28 ` Oded Gabbay
2020-07-27 10:05 ` Greg KH
2020-07-27 10:59 ` Oded Gabbay
2020-07-28 7:33 ` Stephen Rothwell
2020-07-28 7:53 ` Greg KH
2020-07-28 8:23 ` Stephen Rothwell
2020-07-28 17:17 ` Greg KH
2020-07-28 17:19 ` Greg KH
2020-07-29 9:55 ` Oded Gabbay
2020-05-04 1:46 Stephen Rothwell
2020-05-04 1:47 ` Stephen Rothwell
2020-05-04 7:14 ` Greg KH
[not found] ` <BYAPR02MB394115C2C80B1169D282A646B7A60@BYAPR02MB3941.namprd02.prod.outlook.com>
2020-05-04 7:31 ` Greg KH
2019-07-08 9:23 Stephen Rothwell
2019-07-12 0:44 ` Stephen Rothwell
2019-07-12 7:59 ` Greg KH
2017-04-12 5:18 Stephen Rothwell
2017-04-12 10:33 ` Greg KH
2017-03-20 2:44 Stephen Rothwell
2017-03-20 12:23 ` Arnd Bergmann
2017-03-21 0:18 ` Benjamin Herrenschmidt
2017-03-21 0:36 ` Cyril Bur
2017-03-21 2:58 ` Joel Stanley
2015-08-07 6:32 Stephen Rothwell
2015-05-27 5:52 Stephen Rothwell
2015-05-27 7:08 ` Winkler, Tomas
2015-05-27 12:36 ` Greg KH
2014-02-21 5:47 Stephen Rothwell
2014-02-26 6:47 ` Stephen Rothwell
2014-02-27 3:37 ` Greg KH
2014-02-27 5:48 ` Stephen Rothwell
2013-09-27 7:10 Stephen Rothwell
2013-09-28 1:04 ` Greg KH
2013-04-02 6:29 Stephen Rothwell
2013-04-02 6:49 ` Richard Weinberger
2013-03-26 4:18 Stephen Rothwell
2013-03-18 2:56 Stephen Rothwell
2013-03-18 8:58 ` Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBNJrYN1ThMwsLYT@quatroqueijos \
--to=cascardo@igalia.com \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).