From: Herbert Xu <herbert@gondor.apana.org.au>
To: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Cc: Thorsten Leemhuis <linux@leemhuis.info>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Eric Biggers <ebiggers@google.com>,
Danny Tsen <dtsen@linux.ibm.com>
Subject: Re: [PATCH] crypto: powerpc/poly1305 - Add missing poly1305_emit_arch
Date: Thu, 8 May 2025 17:45:28 +0800 [thread overview]
Message-ID: <aBx9OAyiDx7MYAVs@gondor.apana.org.au> (raw)
In-Reply-To: <37cf099e-d5c2-40d8-bc31-77e1f9623b1c@linux.ibm.com>
On Thu, May 08, 2025 at 02:46:06PM +0530, Venkat Rao Bagalkote wrote:
>
> I tested this patch by applying on next-20250507, though it fixes the build
> issue, it has introduced a boot warning.
Looking at the history of this code it was never used as lib/crypto
prior to commit 378a337ab40f88d63ba71d68ff578ead7f5ac8f1. So either
this code simply doesn't work as lib/crypto for some reason, or my
subsequent blockhash change broke it.
Could you please revert back to commit 378a337ab40f and see if the
lib/crypto chacha20poly1305 self-test passes with that?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-05-08 9:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1745815528.git.herbert@gondor.apana.org.au>
[not found] ` <915c874caf5451d560bf26ff59f58177aa8b7c17.1745815528.git.herbert@gondor.apana.org.au>
2025-05-07 11:03 ` [v4 PATCH 11/11] crypto: lib/poly1305 - Use block-only interface Thorsten Leemhuis
2025-05-07 11:36 ` [PATCH] crypto: powerpc/poly1305 - Add missing poly1305_emit_arch Herbert Xu
2025-05-07 12:25 ` Thorsten Leemhuis
2025-05-08 9:16 ` Venkat Rao Bagalkote
2025-05-08 9:31 ` Herbert Xu
2025-05-08 10:01 ` Venkat Rao Bagalkote
2025-05-08 11:10 ` Herbert Xu
2025-05-08 9:45 ` Herbert Xu [this message]
2025-05-08 16:29 ` Eric Biggers
2025-05-09 0:53 ` Herbert Xu
2025-05-08 9:49 ` Herbert Xu
2025-05-08 11:39 ` Herbert Xu
2025-05-08 11:57 ` Venkat Rao Bagalkote
2025-05-08 11:59 ` Herbert Xu
2025-05-08 12:23 ` [PATCH] crypto: powerpc/poly1305 - Restore crypto_simd_usable test Herbert Xu
2025-05-08 15:05 ` Venkat Rao Bagalkote
2025-05-09 12:29 ` [PATCH] crypto: powerpc/poly1305 - Fix input mixup in poly1305_emit_arch Herbert Xu
2025-05-10 4:44 ` Eric Biggers
2025-05-10 5:10 ` [v2 PATCH] crypto: powerpc/poly1305 - Add poly1305_emit_arch wrapper Herbert Xu
2025-05-10 5:33 ` Eric Biggers
2025-05-10 5:49 ` Herbert Xu
2025-05-10 5:50 ` Herbert Xu
2025-05-10 6:02 ` Eric Biggers
2025-05-10 9:13 ` [PATCH] crypto: powerpc/poly1305 - Add SIMD fallback Herbert Xu
2025-05-10 22:34 ` [v2 PATCH] crypto: powerpc/poly1305 - Add poly1305_emit_arch wrapper Segher Boessenkool
2025-05-10 23:19 ` Eric Biggers
2025-05-11 2:10 ` Herbert Xu
2025-05-12 5:13 ` Venkat Rao Bagalkote
2025-05-09 14:16 ` [PATCH] crypto: powerpc/poly1305 - Restore crypto_simd_usable test Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBx9OAyiDx7MYAVs@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dtsen@linux.ibm.com \
--cc=ebiggers@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=maddy@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox