From: Randy Dunlap <rdunlap@infradead.org>
To: John Garry <john.garry@huawei.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: linux-mtd@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Joe Perches <joe@perches.com>, Mark Brown <broonie@kernel.org>
Subject: Re: linux-next: Tree for Mar 10 (mtd/spi-nor/)
Date: Tue, 10 Mar 2020 13:36:54 -0700 [thread overview]
Message-ID: <aa3b19cd-e043-e5ea-5d77-38b53bda2e60@infradead.org> (raw)
In-Reply-To: <f9d33b09-fe9f-2c26-96dc-b2eaa53c614b@huawei.com>
On 3/10/20 10:14 AM, John Garry wrote:
> +
>
> On 10/03/2020 14:37, Randy Dunlap wrote:
>> On 3/10/20 2:19 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20200306:
>>>
>>> Removed tree: nfc-next (abanboned)
>>
>> doned
>>
>>
>> on i386:
>>
>> WARNING: unmet direct dependencies detected for MTD_SPI_NOR
>
> Uh, so kbuild honors a "select" of a config option which has unmet dependencies:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.rst?h=v5.6-rc5#n143
Yes.
> So this looks introduced by:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/spi/Kconfig?h=next-20200310&id=e14572c52546c16e159c4c1814984843a119e823
>
>> Depends on [m]: MTD [=m] && SPI_MASTER [=y] > Selected by [y]:
>> - SPI_HISI_SFC_V3XX [=y] && SPI [=y] && SPI_MASTER [=y] && (ARM64 && ACPI [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
Would it be acceptable to move the Kconfig entry for this:
config SPI_HISI_SFC_V3XX
tristate "HiSilicon SPI-NOR Flash Controller for Hi16XX chipsets"
depends on (ARM64 && ACPI) || COMPILE_TEST
depends on HAS_IOMEM
select MTD_SPI_NOR
into drivers/mtd/spi-nor/Kconfig, say after this one:
config SPI_HISI_SFC
tristate "Hisilicon FMC SPI-NOR Flash Controller(SFC)"
depends on ARCH_HISI || COMPILE_TEST
depends on HAS_IOMEM
and drop the "select MTD_SPI_NOR" because when it's in drivers/mtd/spi-nor/Kconfig,
it will depend on MTD_SPI_NOR.
>> ERROR: "spi_nor_scan" [drivers/mtd/spi-nor/intel-spi.ko] undefined!
>> ERROR: "spi_nor_scan" [drivers/mtd/spi-nor/mtk-quadspi.ko] undefined!
>> ERROR: "spi_nor_scan" [drivers/mtd/spi-nor/hisi-sfc.ko] undefined!
>> ERROR: "spi_nor_scan" [drivers/mtd/spi-nor/aspeed-smc.ko] undefined!
>>
>>
>> Full randconfig file is attached.
>>
--
~Randy
next prev parent reply other threads:[~2020-03-10 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 9:19 linux-next: Tree for Mar 10 Stephen Rothwell
2020-03-10 14:37 ` linux-next: Tree for Mar 10 (mtd/spi-nor/) Randy Dunlap
2020-03-10 17:14 ` John Garry
2020-03-10 20:36 ` Randy Dunlap [this message]
2020-03-11 2:20 ` Randy Dunlap
2020-03-11 7:12 ` Tudor.Ambarus
2020-03-11 7:56 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa3b19cd-e043-e5ea-5d77-38b53bda2e60@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox