Fixes tags need work in the block tree

Fixes tags need work in the block tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

In commit

  7a9ffcf2cbf88 ("io_uring/zcrx: use dma_len for chunk size calculation")

Fixes tag

  Fixes: 8c0cab0b7bf76 ("always dma map in advance")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Fixes tags need work in the block tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

In commit

  5c34e65e5678f ("io_uring/zcrx: don't clear not allocated niovs")

Fixes tag

  Fixes: 8c0cab0b7bf76 ("always dma map in advance")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fixes tags need work in the block tree

[Jens Axboe]

On 4/2/26 5:34 AM, Mark Brown wrote:
> In commit
> 
>   7a9ffcf2cbf88 ("io_uring/zcrx: use dma_len for chunk size calculation")
> 
> Fixes tag
> 
>   Fixes: 8c0cab0b7bf76 ("always dma map in advance")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Fixed this and the other one. Pavel, JFYI. What I usually say is
add:

[pretty]
	fixes = Fixes: %h (\"%s\")

[alias]
	fixes = log -1 --format=fixes

to your ~/.gitconfig so you can just run:

$ git fixes 8c0cab0b7bf768594e8efc73f7b8f3d5abeb74f1
Fixes: 8c0cab0b7bf7 ("io_uring/zcrx: always dma map in advance")

and it does the right thing for you. Nobody remembers that full git log
line, and then people try and do it manually, and invariably mess up the
formatting. git fixes <sha> is the way.

-- 
Jens Axboe