* linux-next: build failure after merge of the fs-next tree
@ 2026-03-09 14:29 Mark Brown
2026-03-09 23:08 ` Namjae Jeon
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2026-03-09 14:29 UTC (permalink / raw)
To: Namjae Jeon
Cc: Lorenzo Stoakes, David Hildenbrand, Andrew Morton,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]
Hi all,
After merging the fs-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
/tmp/next/build/fs/ntfs/file.c: In function 'ntfs_file_mmap_prepare':
/tmp/next/build/fs/ntfs/file.c:657:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
657 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
| ^~~~~~~~~~~~~~~~~~~
| vma_desc_set_flags
Caused by an interaction with commit:
2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)
from one of the mm trees, I've fixed it up as below and can carry as
needed.
commit 8cbd256f4ac9d0b08b6fc30b305cfcb51b9de9f7
Author: Mark Brown <broonie@kernel.org>
Date: Mon Mar 9 13:24:55 2026 +0000
ntfs: Fix up mm merge
/tmp/next/build/fs/ntfs/file.c: In function 'ntfs_file_mmap_prepare':
/tmp/next/build/fs/ntfs/file.c:657:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
657 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
| ^~~~~~~~~~~~~~~~~~~
Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index 2735780159999..e5b897a6c1e15 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -654,7 +654,7 @@ static int ntfs_file_mmap_prepare(struct vm_area_desc *desc)
if (NInoCompressed(NTFS_I(inode)))
return -EOPNOTSUPP;
- if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
+ if (vma_desc_test(desc, VMA_WRITE_BIT)) {
struct inode *inode = file_inode(file);
loff_t from, to;
int err;
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fs-next tree
2026-03-09 14:29 Mark Brown
@ 2026-03-09 23:08 ` Namjae Jeon
2026-03-10 7:21 ` Lorenzo Stoakes (Oracle)
0 siblings, 1 reply; 6+ messages in thread
From: Namjae Jeon @ 2026-03-09 23:08 UTC (permalink / raw)
To: Mark Brown
Cc: Lorenzo Stoakes, David Hildenbrand, Andrew Morton,
Linux Kernel Mailing List, Linux Next Mailing List
On Mon, Mar 9, 2026 at 11:29 PM Mark Brown <broonie@kernel.org> wrote:
>
> Hi all,
Hi Mark,
>
> After merging the fs-next tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> /tmp/next/build/fs/ntfs/file.c: In function 'ntfs_file_mmap_prepare':
> /tmp/next/build/fs/ntfs/file.c:657:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> 657 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> | ^~~~~~~~~~~~~~~~~~~
> | vma_desc_set_flags
>
> Caused by an interaction with commit:
>
> 2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)
>
> from one of the mm trees, I've fixed it up as below and can carry as
> needed.
>
> commit 8cbd256f4ac9d0b08b6fc30b305cfcb51b9de9f7
> Author: Mark Brown <broonie@kernel.org>
> Date: Mon Mar 9 13:24:55 2026 +0000
>
> ntfs: Fix up mm merge
>
> /tmp/next/build/fs/ntfs/file.c: In function 'ntfs_file_mmap_prepare':
> /tmp/next/build/fs/ntfs/file.c:657:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> 657 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> | ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
>
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index 2735780159999..e5b897a6c1e15 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -654,7 +654,7 @@ static int ntfs_file_mmap_prepare(struct vm_area_desc *desc)
> if (NInoCompressed(NTFS_I(inode)))
> return -EOPNOTSUPP;
>
> - if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> + if (vma_desc_test(desc, VMA_WRITE_BIT)) {
> struct inode *inode = file_inode(file);
> loff_t from, to;
> int err;
Looks good to me:)
Thanks for fixing it up and carrying the patch!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fs-next tree
2026-03-09 23:08 ` Namjae Jeon
@ 2026-03-10 7:21 ` Lorenzo Stoakes (Oracle)
0 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Stoakes (Oracle) @ 2026-03-10 7:21 UTC (permalink / raw)
To: Namjae Jeon
Cc: Mark Brown, David Hildenbrand, Andrew Morton,
Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Mar 10, 2026 at 08:08:22AM +0900, Namjae Jeon wrote:
> On Mon, Mar 9, 2026 at 11:29 PM Mark Brown <broonie@kernel.org> wrote:
> >
> > Hi all,
> Hi Mark,
> >
> > After merging the fs-next tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > /tmp/next/build/fs/ntfs/file.c: In function 'ntfs_file_mmap_prepare':
> > /tmp/next/build/fs/ntfs/file.c:657:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> > 657 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> > | ^~~~~~~~~~~~~~~~~~~
> > | vma_desc_set_flags
> >
> > Caused by an interaction with commit:
> >
> > 2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)
> >
> > from one of the mm trees, I've fixed it up as below and can carry as
> > needed.
> >
> > commit 8cbd256f4ac9d0b08b6fc30b305cfcb51b9de9f7
> > Author: Mark Brown <broonie@kernel.org>
> > Date: Mon Mar 9 13:24:55 2026 +0000
> >
> > ntfs: Fix up mm merge
> >
> > /tmp/next/build/fs/ntfs/file.c: In function 'ntfs_file_mmap_prepare':
> > /tmp/next/build/fs/ntfs/file.c:657:13: error: implicit declaration of function 'vma_desc_test_flags'; did you mean 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> > 657 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> > | ^~~~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Mark Brown <broonie@kernel.org>
> >
> > diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> > index 2735780159999..e5b897a6c1e15 100644
> > --- a/fs/ntfs/file.c
> > +++ b/fs/ntfs/file.c
> > @@ -654,7 +654,7 @@ static int ntfs_file_mmap_prepare(struct vm_area_desc *desc)
> > if (NInoCompressed(NTFS_I(inode)))
> > return -EOPNOTSUPP;
> >
> > - if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> > + if (vma_desc_test(desc, VMA_WRITE_BIT)) {
> > struct inode *inode = file_inode(file);
> > loff_t from, to;
> > int err;
> Looks good to me:)
> Thanks for fixing it up and carrying the patch!
Me too, thanks guys, and sorry for the noise!
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build failure after merge of the fs-next tree
@ 2026-03-27 19:22 Mark Brown
2026-03-27 19:27 ` Lorenzo Stoakes (Oracle)
2026-03-28 1:16 ` Namjae Jeon
0 siblings, 2 replies; 6+ messages in thread
From: Mark Brown @ 2026-03-27 19:22 UTC (permalink / raw)
To: Namjae Jeon, Lorenzo Stoakes, Andrew Morton, David Hildenbrand
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1969 bytes --]
Hi all,
After merging the fs-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
/tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
/tmp/next/build/fs/exfat/file.c:842:13: error: implicit
declaration of function 'vma_desc_test_flags'; did you mean
'vma_desc_set_flags'? [-Wimplicit-function-declaration]
842 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
| ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
Caused by commit
9b373eacd6e6c4 (exfat: add iomap buffered I/O support)
from the exfat tree interacting with
2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)
from one of the mm trees. I have applied a fixup which I can carry as
needed.
From c4935dbc4b15a9119616ac73b17eff29a7e2ec87 Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@kernel.org>
Date: Fri, 27 Mar 2026 19:08:13 +0000
Subject: [PATCH] exfat: Fix up merge with mm
/tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
/tmp/next/build/fs/exfat/file.c:842:13: error: implicit
declaration of function 'vma_desc_test_flags'; did you mean
'vma_desc_set_flags'? [-Wimplicit-function-declaration]
842 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
| ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
Signed-off-by: Mark Brown <broonie@kernel.org>
---
fs/exfat/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 9a30c32b3a0526..82db5ebaaad7b7 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -839,7 +839,7 @@ static int exfat_file_mmap_prepare(struct vm_area_desc *desc)
if (unlikely(exfat_forced_shutdown(file_inode(desc->file)->i_sb)))
return -EIO;
- if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
+ if (vma_desc_test(desc, VMA_WRITE_BIT)) {
struct inode *inode = file_inode(file);
loff_t from, to;
int err;
--
2.47.3
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fs-next tree
2026-03-27 19:22 linux-next: build failure after merge of the fs-next tree Mark Brown
@ 2026-03-27 19:27 ` Lorenzo Stoakes (Oracle)
2026-03-28 1:16 ` Namjae Jeon
1 sibling, 0 replies; 6+ messages in thread
From: Lorenzo Stoakes (Oracle) @ 2026-03-27 19:27 UTC (permalink / raw)
To: Mark Brown
Cc: Namjae Jeon, Andrew Morton, David Hildenbrand,
Linux Kernel Mailing List, Linux Next Mailing List
On Fri, Mar 27, 2026 at 07:22:12PM +0000, Mark Brown wrote:
> Hi all,
>
> After merging the fs-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> /tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
> /tmp/next/build/fs/exfat/file.c:842:13: error: implicit
> declaration of function 'vma_desc_test_flags'; did you mean
> 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> 842 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> | ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
>
> Caused by commit
>
> 9b373eacd6e6c4 (exfat: add iomap buffered I/O support)
>
> from the exfat tree interacting with
>
> 2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)
>
> from one of the mm trees. I have applied a fixup which I can carry as
> needed.
>
> From c4935dbc4b15a9119616ac73b17eff29a7e2ec87 Mon Sep 17 00:00:00 2001
> From: Mark Brown <broonie@kernel.org>
> Date: Fri, 27 Mar 2026 19:08:13 +0000
> Subject: [PATCH] exfat: Fix up merge with mm
>
> /tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
> /tmp/next/build/fs/exfat/file.c:842:13: error: implicit
> declaration of function 'vma_desc_test_flags'; did you mean
> 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> 842 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> | ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> fs/exfat/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
> index 9a30c32b3a0526..82db5ebaaad7b7 100644
> --- a/fs/exfat/file.c
> +++ b/fs/exfat/file.c
> @@ -839,7 +839,7 @@ static int exfat_file_mmap_prepare(struct vm_area_desc *desc)
> if (unlikely(exfat_forced_shutdown(file_inode(desc->file)->i_sb)))
> return -EIO;
>
> - if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> + if (vma_desc_test(desc, VMA_WRITE_BIT)) {
LGTM, Cheers!
> struct inode *inode = file_inode(file);
> loff_t from, to;
> int err;
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fs-next tree
2026-03-27 19:22 linux-next: build failure after merge of the fs-next tree Mark Brown
2026-03-27 19:27 ` Lorenzo Stoakes (Oracle)
@ 2026-03-28 1:16 ` Namjae Jeon
1 sibling, 0 replies; 6+ messages in thread
From: Namjae Jeon @ 2026-03-28 1:16 UTC (permalink / raw)
To: Mark Brown
Cc: Lorenzo Stoakes, Andrew Morton, David Hildenbrand,
Linux Kernel Mailing List, Linux Next Mailing List
> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
> index 9a30c32b3a0526..82db5ebaaad7b7 100644
> --- a/fs/exfat/file.c
> +++ b/fs/exfat/file.c
> @@ -839,7 +839,7 @@ static int exfat_file_mmap_prepare(struct vm_area_desc *desc)
> if (unlikely(exfat_forced_shutdown(file_inode(desc->file)->i_sb)))
> return -EIO;
>
> - if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> + if (vma_desc_test(desc, VMA_WRITE_BIT)) {
> struct inode *inode = file_inode(file);
> loff_t from, to;
> int err;
Looks good to me:)
Thank you, Mark!
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-03-28 1:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-27 19:22 linux-next: build failure after merge of the fs-next tree Mark Brown
2026-03-27 19:27 ` Lorenzo Stoakes (Oracle)
2026-03-28 1:16 ` Namjae Jeon
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 14:29 Mark Brown
2026-03-09 23:08 ` Namjae Jeon
2026-03-10 7:21 ` Lorenzo Stoakes (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox