From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files. Date: Wed, 29 Sep 2010 12:21:14 -0700 Message-ID: References: <20100929141112.26944.21931.stgit@build.ogc.int> <201009292117.54828.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <201009292117.54828.arnd-r2nGTMty4D4@public.gmane.org> (Arnd Bergmann's message of "Wed, 29 Sep 2010 21:17:54 +0200") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Steve Wise , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-next.vger.kernel.org > The main difference between default_llseek and generic_file_llseek > is that default_llseek doesn't care about the maximum file size > of the underlying file system, which is ULONG_MAX on debugfs, > so they are equivalent. I thought default_llseek also takes the BKL still? > In general, the preferred one is no_llseek for those files where > you know you do not need to seek. If you do, I'd use default_llseek > for character devices and generic_file_llseek for file systems > that set the s_maxbytes. The case in question is for debugfs files, so we should use generic_file_llseek, right? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html