From: Roland Dreier <rdreier@cisco.com>
To: Steve Wise <swise@opengridcomputing.com>
Cc: randy.dunlap@oracle.com, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: Re: [ofa-general] [PATCH 2.6.30] RDMA/cxgb3: Remove modulo math.
Date: Wed, 11 Feb 2009 10:12:09 -0800 [thread overview]
Message-ID: <adatz70972e.fsf@cisco.com> (raw)
In-Reply-To: <4992F26A.4030800@opengridcomputing.com> (Steve Wise's message of "Wed, 11 Feb 2009 09:44:42 -0600")
> Note that wr->sg_list[i].addr was being cast to a u32. That was wrong.
Is it possible for the page to be bigger than 4GB? If so then yes you
might be chopping off high-order bits or something.
Anyway please send me this change as a separate patch with a changelog
explaining that you're avoiding the div etc.... I don't want to roll it
in with the other unrelated fix (which changes code that was never
upstream anyway).
next prev parent reply other threads:[~2009-02-11 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 18:44 [ofa-general] [PATCH 2.6.30] RDMA/cxgb3: Remove modulo math Steve Wise
2009-02-10 19:04 ` [ofa-general] " Randy Dunlap
2009-02-10 19:10 ` Steve Wise
2009-02-10 19:12 ` Randy Dunlap
2009-02-11 0:38 ` [ofa-general] " Roland Dreier
2009-02-11 1:03 ` Steve Wise
[not found] ` <499223F8.1010204@opengridcomputing.com>
2009-02-11 1:07 ` David Miller
2009-02-11 1:18 ` Roland Dreier
2009-02-11 1:23 ` David Miller
2009-02-11 7:20 ` Roland Dreier
2009-02-11 8:00 ` David Miller
2009-02-11 15:44 ` Steve Wise
2009-02-11 18:12 ` Roland Dreier [this message]
2009-02-11 18:32 ` Steve Wise
2009-02-11 18:36 ` Roland Dreier
2009-02-11 18:44 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adatz70972e.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).