From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: [ofa-general] Re: linux-next: origin tree build failure Date: Mon, 29 Dec 2008 08:13:36 -0800 Message-ID: References: <20081229114321.4b6baea5.sfr@canb.auug.org.au> <1230544737.4261.33.camel@alst60> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1230544737.4261.33.camel@alst60> (Aleksey Senin's message of "Mon, 29 Dec 2008 11:58:57 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: general-bounces@lists.openfabrics.org Errors-To: general-bounces@lists.openfabrics.org To: Aleksey Senin Cc: Stephen Rothwell , linux-next@vger.kernel.org, Linus , LKML , "general@lists.openfabrics.org" List-Id: linux-next.vger.kernel.org > After another investigation of this problem, I think that proposed > solution is #ifdef as good for a first stage. IPv6 support is mandatory > when we are talking about running linux in some organization. But, of > course, the way how it implemented in IB stack should be changed. So on > the second stage, I'd like drop out these "defines" and at the time of > module initialization obtain addresses of IPv6 functions and in the case > if they are present at the runtime, call them. It should be nice > solution for RMDA_CM and IPoIB modules. I don't think this second stage sounds like a good idea. Suppose someone loads the RDMA CM first, so it doesn't find the ipv6 functions, and then later loads and configures ipv6. You'll end up in a situation where trying to make an IPv6 connection fails spuriously. (And just the ugliness of looking up function pointers isn't very nice either) - R.