From: Mark Brown <broonie@kernel.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: Missing signoff in the hid tree
Date: Mon, 6 Apr 2026 17:43:40 +0100 [thread overview]
Message-ID: <af1cf86b-c2a7-4b75-bbb3-dff151bf4edd@sirena.org.uk> (raw)
In-Reply-To: <61868409-rs8p-rq71-q852-5296pnp42srs@xreary.bet>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On Mon, Apr 06, 2026 at 06:38:14PM +0200, Jiri Kosina wrote:
> On Mon, 6 Apr 2026, Mark Brown wrote:
> > > > 142068281f513 ("HID: input: use __free(kfree) to clean up temporary buffers")
> > > > is missing a Signed-off-by from its committer
> > > This issue is still present today.
> > And today.
> Yeah, this happened because Benjamin rebased a tree with commit a that I
> originally comitted and SOBed (the tree has a shared maintainership).
This is a common way people mess up signoffs.
> If you strongly believe that this is worth another rebase, I can happily
> do that, but given the fact that it contains signoff of one of the
> co-maintainers, I wouldn't lose sleep over it (but I can be probably
> easily convinced otherwise).
That's more a question for Linus than for me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-06 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 12:30 Missing signoff in the hid tree Mark Brown
2026-03-30 22:12 ` Mark Brown
2026-04-06 16:23 ` Mark Brown
2026-04-06 16:38 ` Jiri Kosina
2026-04-06 16:43 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-23 12:18 Mark Brown
2026-02-23 12:20 ` Jiri Kosina
2026-02-23 18:08 ` Julius Lehmann
2026-02-24 8:42 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af1cf86b-c2a7-4b75-bbb3-dff151bf4edd@sirena.org.uk \
--to=broonie@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox