From: Ingo Molnar <mingo@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Guenter Roeck <linux@roeck-us.net>,
Juergen Gross <jgross@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Roman Bakshansky <bakshansky.lists@gmail.com>
Subject: Re: linux-next: manual merge of the tip tree with the hwmon-staging tree
Date: Tue, 9 Jun 2026 09:06:46 +0200 [thread overview]
Message-ID: <aie7hggt74Qa8jSg@gmail.com> (raw)
In-Reply-To: <aibSXki-s7geOFFn@sirena.org.uk>
* Mark Brown <broonie@kernel.org> wrote:
> Hi all,
>
> Today's linux-next merge of the tip tree got a conflict in:
>
> drivers/hwmon/coretemp.c
>
> between commit:
>
> 1b16a26e79433 ("hwmon: (coretemp) fix coding style issues")
>
> from the hwmon-staging tree and commit:
>
> 91660aae2f864 ("x86/msr: Switch rdmsr_safe_on_cpu() users to rdmsrq_safe_on_cpu()")
>
> from the tip tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> diff --cc drivers/hwmon/coretemp.c
> index 02b4e46d965b9,70711a7cca123..0000000000000
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@@ -220,13 -220,14 +220,13 @@@ static int adjust_tjmax(struct cpuinfo_
> * http://softwarecommunity.intel.com/Wiki/Mobility/720.htm
> * For Core2 cores, check MSR 0x17, bit 28 1 = Mobile CPU
> */
> - err = rdmsr_safe_on_cpu(id, 0x17, &eax, &edx);
> + err = rdmsrq_safe_on_cpu(id, 0x17, &val);
> - err = rdmsr_safe_on_cpu(id, 0xee, &eax, &edx);
> + err = rdmsrq_safe_on_cpu(id, 0xee, &val);
> - u32 eax, edx;
> + struct msr val;
> - u32 eax, edx;
> + struct msr val;
Looks good, thank you!
Ingo
next prev parent reply other threads:[~2026-06-09 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 14:31 linux-next: manual merge of the tip tree with the hwmon-staging tree Mark Brown
2026-06-09 7:06 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-01 7:15 Stephen Rothwell
2019-07-09 0:17 ` Stephen Rothwell
2019-07-09 1:21 ` Guenter Roeck
2018-12-11 3:30 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aie7hggt74Qa8jSg@gmail.com \
--to=mingo@kernel.org \
--cc=bakshansky.lists@gmail.com \
--cc=broonie@kernel.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox