Re: Next March 27 : s390 defconfig build failure

Heiko Carstens
2009-03-27T14:40:32Z

On Fri, 27 Mar 2009 19:27:04 +0530
Sachin Sant <sachinp@in.ibm.com> wrote:

> Today's Next defconfig s390 build failed with
>
> arch/s390/hypfs/hypfs_diag.c: In function diag204_free_buffer:
> arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function free_pages
> arch/s390/hypfs/hypfs_diag.c: In function diag204_alloc_rbuf:
> arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function __get_free_pages
> arch/s390/hypfs/hypfs_diag.c:384: error: GFP_KERNEL undeclared (first use in this function)

Thanks for reporting. Ingo, could you pick up the patch below please?

Subject: [PATCH] s390/hypfs: fix build breakage

From: Heiko Carstens <heiko.carstens@de.ibm.com>

Fix build breakage below which probably was introduced with
("rcu: don't include unnecessary headers, allow kmemtrace w/ tracepoints").

CC arch/s390/hypfs/hypfs_diag.o
arch/s390/hypfs/hypfs_diag.c: In function 'diag204_free_buffer':
arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function 'free_pages'
arch/s390/hypfs/hypfs_diag.c: In function 'diag204_alloc_rbuf':
arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function '__get_free_pages'
arch/s390/hypfs/hypfs_diag.c:384: error: 'GFP_KERNEL' undeclared (first use in this function)
arch/s390/hypfs/hypfs_diag.c:384: error: (Each undeclared identifier is reported only once
arch/s390/hypfs/hypfs_diag.c:384: error: for each function it appears in.)

Reported-by: Sachin Sant <sachinp@in.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
arch/s390/hypfs/hypfs_diag.c | 2 ++
1 file changed, 2 insertions(+)

Index: linux-next/arch/s390/hypfs/hypfs_diag.c
===================================================================
--- linux-next.orig/arch/s390/hypfs/hypfs_diag.c
+++ linux-next/arch/s390/hypfs/hypfs_diag.c
@@ -12,6 +12,8 @@

#include <linux/types.h>
#include <linux/errno.h>
+#include <linux/gfp.h>
+#include <linux/slab.h>
#include <linux/string.h>
#include <linux/vmalloc.h>
#include <asm/ebcdic.h>