From: "Matwey V. Kornilov" <matwey@sai.msu.ru>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Greg KH <greg@kroah.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, linux-serial@vger.kernel.org
Subject: [PATCH] tty: mxser: Fix build warning introduced by dfc7b837c7f9 (Re: linux-next: build warning after merge of the tty.current tree)
Date: Wed, 22 May 2013 11:13:38 +0400 (MSK) [thread overview]
Message-ID: <alpine.LRH.2.00.1305221109110.10829@lnfm1.sai.msu.ru> (raw)
In-Reply-To: <20130522133722.d52b827e455275dfdecf12dd@canb.auug.org.au>
From: Matwey V. Kornilov <matwey@sai.msu.ru>
Fix build warning at mxser.c introduced by dfc7b837c7f9
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index f97b196..4c4a236 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -1674,15 +1674,15 @@ static int mxser_ioctl(struct tty_struct *tty,
return mxser_ioctl_special(cmd, argp);
if (cmd == MOXA_SET_OP_MODE || cmd == MOXA_GET_OP_MODE) {
- if (info->board->chip_flag != MOXA_MUST_MU860_HWID)
- return -EFAULT;
-
int p;
unsigned long opmode;
static unsigned char ModeMask[] = { 0xfc, 0xf3, 0xcf, 0x3f };
int shiftbit;
unsigned char val, mask;
+ if (info->board->chip_flag != MOXA_MUST_MU860_HWID)
+ return -EFAULT;
+
p = tty->index % 4;
if (cmd == MOXA_SET_OP_MODE) {
if (get_user(opmode, (int __user *) argp))
next prev parent reply other threads:[~2013-05-22 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 3:37 linux-next: build warning after merge of the tty.current tree Stephen Rothwell
2013-05-22 7:13 ` Matwey V. Kornilov [this message]
2013-05-22 15:35 ` [PATCH] tty: mxser: Fix build warning introduced by dfc7b837c7f9 (Re: linux-next: build warning after merge of the tty.current tree) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.00.1305221109110.10829@lnfm1.sai.msu.ru \
--to=matwey@sai.msu.ru \
--cc=greg@kroah.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox