Linux-Next discussions
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Muchun Song <muchun.song@linux.dev>,
	Muchun Song <songmuchun@bytedance.com>
Subject: Re: linux-next: manual merge of the liveupdate tree with the mm-unstable tree
Date: Tue, 28 Jul 2026 20:38:54 +0300	[thread overview]
Message-ID: <amjpLoJbHsqIAqJO@kernel.org> (raw)
In-Reply-To: <amjYWetl6_WVyumg@sirena.org.uk>

On Tue, Jul 28, 2026 at 05:27:05PM +0100, Mark Brown wrote:
> Hi all,
> 
> Today's linux-next merge of the liveupdate tree got a conflict in:
> 
>   mm/hugetlb.c
>   mm/mm_init.c
> 
> between at least commit:
> 
>   7b558c2570017 ("mm/hugetlb: refactor early boot gigantic hugepage allocation")
> 
> from the mm-unstable tree and commit:
> 
>   7c967e2d549dc ("memblock: make HugeTLB bootmem allocation work with KHO")
>   f476132a8999e ("mm/mm_init: don't rely on memblock to get KHO scratch migratetype")
> 
> from the liveupdate tree.
> 
> I stared at the conflict for a bit but with my minimal familiarity with
> this code I have absolutely no confidence in my ability to do a working
> resolution for this in a timely fashion so instead I merged the version
> of liveupdate from next-20260727, I'll have another look tomorrow but
> would really appreciate it if someone could help out here.

I've got this for merging mm-unstable into liveupdate/next:

diff --cc mm/hugetlb.c
index ab4afc818e8cb,a77c3c1cb8943..0000000000000
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@@ -3027,51 -3076,23 +3076,16 @@@ out_end_reservation
  
  static __init void *alloc_bootmem(struct hstate *h, int nid, bool node_exact)
  {
- 	struct huge_bootmem_page *m;
- 	int listnode = nid;
- 
  	if (hugetlb_early_cma(h))
- 		m = hugetlb_cma_alloc_bootmem(h, &listnode, node_exact);
- 	else {
- 		m = memblock_alloc_hugetlb(huge_page_size(h), nid, node_exact);
- 		if (m) {
- 			m->flags = 0;
- 			m->cma = NULL;
+ 		return hugetlb_cma_alloc_bootmem(h, nid, node_exact);
  
- 			/*
- 			 * For pre-HVO to work correctly, pages need to be on
- 			 * the list for the node they were actually allocated
- 			 * from. That node may be different in the case of
- 			 * fallback by memblock_alloc_hugetlb_bootmem. So,
- 			 * extract the actual node first.
- 			 */
- 			if (!node_exact)
- 				listnode = early_pfn_to_nid(PHYS_PFN(__pa(m)));
- 		}
- 	}
- 
- 	if (m) {
- 		/*
- 		 * Use the beginning of the huge page to store the
- 		 * huge_bootmem_page struct (until gather_bootmem
- 		 * puts them into the mem_map).
- 		 *
- 		 * Put them into a private list first because mem_map
- 		 * is not up yet.
- 		 */
- 		INIT_LIST_HEAD(&m->list);
- 		list_add(&m->list, &huge_boot_pages[listnode]);
- 		m->hstate = h;
- 	}
 -	if (node_exact)
 -		return memblock_alloc_exact_nid_raw(huge_page_size(h),
 -				huge_page_size(h), 0,
 -				MEMBLOCK_ALLOC_ACCESSIBLE, nid);
--
- 	return m;
 -	return memblock_alloc_try_nid_raw(huge_page_size(h),
 -				huge_page_size(h), 0,
 -				MEMBLOCK_ALLOC_ACCESSIBLE, nid);
++	return memblock_alloc_hugetlb(huge_page_size(h), nid, node_exact);
  }
  
- int alloc_bootmem_huge_page(struct hstate *h, int nid)
+ void *__init arch_alloc_bootmem_huge_page(struct hstate *h, int nid)
  	__attribute__ ((weak, alias("__alloc_bootmem_huge_page")));
- int __alloc_bootmem_huge_page(struct hstate *h, int nid)
+ void *__init __alloc_bootmem_huge_page(struct hstate *h, int nid)
  {
- 	struct huge_bootmem_page *m = NULL; /* initialize for clang */
  	int nr_nodes, node = nid;
  
  	/* do node specific alloc */
diff --cc mm/mm_init.c
index dc20d6814e48b,711f821f7b3c7..0000000000000
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@@ -2683,7 -2683,8 +2682,9 @@@ void __init __weak mem_init(void
  
  void __init mm_core_init_early(void)
  {
 +	kho_memory_init_early();
+ 	free_area_init();
+ 
  	hugetlb_cma_reserve();
  	hugetlb_bootmem_alloc();



-- 
Sincerely yours,
Mike.

  reply	other threads:[~2026-07-28 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 16:27 linux-next: manual merge of the liveupdate tree with the mm-unstable tree Mark Brown
2026-07-28 17:38 ` Mike Rapoport [this message]
2026-07-28 17:56   ` Mark Brown
2026-07-28 20:43   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amjpLoJbHsqIAqJO@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox