From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 962A959574A for ; Tue, 8 Sep 2026 17:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788890266; cv=none; b=hzN/huLXXAq3o2KvwPC8miC9guuaUZ0opZm7xw19XBVsPzaFKZEXL6afxB+Qpm5WgSFZlQqgPCdGAtGwNGnjedoRK2BgMe/ykPPoRHyQsoIZ1SlBncbpuPogqr+4PUUpqTVaaYCRcsXob1NXmHMAiV39/tSXF3JbuIu3C1CrvkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788890266; c=relaxed/simple; bh=LK98Ep7X4xlOo4JMZD4weYKrKFvfB/L2QK6C3Rc3ofM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P/z+vjjXwLG8rU08b7mtDOEPxsNtG/hufjO/eDZnHYJh4A9vHZcFaQqMh3pP0Pd2I3jGcgcuYDrPErhDwKfIGJlEbph6riQykbasmq6TuYBdUNUPnn2VTpIPiEnGS4qs9GvAWxuOdenbo0x/ytAGaqcFmFXm3xISVGGyS8PoLeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GlqQfwdz; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GlqQfwdz" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-3a1e9f55e03so45330701fa.1 for ; Tue, 08 Sep 2026 10:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788890262; x=1789495062; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YqvYHjfMGh1MW54/g0K1Oez4luMXjAhsckidP9l0mRI=; b=GlqQfwdzg7iGl2s8M/PvnVcKt8rh/HbLEyK9oNUizI5zePW3SUEmtld/5tHN8lEofW 6hEAgG1VfAhSI+tzSBu2qnfy0D0BOnqeBYmY6zOdosixTTzVl0Ckt95SobPBgG4IC/96 Hip1qXMbOn+j8GzU6x2az50gZ34ON2Y3ehAGezmI6bgakqAOfjc/9FLJnomurnj6Bz05 zqT0g1Xxz3xF7Lu3dYj6hFPM5ONXQ4orqCh0wPcPxwyIfTt3sA1UHgrBMljrOFYGdgOC iMhDZ1t30bMaaIguUv+rg5dy6oB2eSyY2npSN7uker1ZVxlucP+1iS6shbx2C2qqS+x2 PXmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788890262; x=1789495062; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=YqvYHjfMGh1MW54/g0K1Oez4luMXjAhsckidP9l0mRI=; b=Iv5ZrKj2YS22jorBTHW0zX1iX0ADq6tfMYBQi/EvmfKJi6kfkoNO+NWqHgp3lBr1JG vgZDIwYx+D01mE6eCvntYsXwjcYCGQpgmNQN56hW+U7Qww2Me3orfPPfi48/6+OmH/20 NpOq9QfuNSYTCUrRndGP1Gic4vthcvm89TxxRepnHiNCSuNI7E/WemR2VoTuIQfK6yP1 T+mRP2VbIRzghiSHvkDlP17qV5DyfCWjVdy1961e4vgMcWs9UB7mz5PLNvF75etmQfkj 4YEsddn+m43XLnek/XmGBo8eOzlaW/t73lrZuE3G1YDM2ohdYorm+Cnn9m+neIhp1vvx Tm8w== X-Forwarded-Encrypted: i=1; AKwUvByps4Dorxu8Esw9sJ0we00uwwrD2qi9Z+7+HGtzlFlRdMYSiJtDNhrntSEHpF89fzKD0bw/Sb9ySLZ/@vger.kernel.org X-Gm-Message-State: AFuF++k4oG2mekLMsACdm2Tx+5YzKZy+aOoYWzKCMumdL+DswtuF30/2 22DDkV+q90KzdDsn6m3KkVvxZ2N1aCFZgHUZ8Ekoapo8IMnaLShe/4mr X-Gm-Gg: AYBFou1BoT/ID8PraXxjp8nVDGYXdnk9eRgsJDleqgtSijEcCYZFIPz2QtSdvwH5inh Hz/ivJ5avFBW+/mLAY002lDuSmouXsffIt1NP8LmEQS/bUiaAWaoAiO3ChhHDOdxDkb4hVAFj4G MtQN4eNy1BTbFjuGTA9KBmfGsGSmZTvQWCr3hRUVNSH+ORjD9mI7+VvRkETZvaTENwZpZyxH60Q bfjGgyVhS+AvG2mZLrS+6SYetYqV4q/qmwKDg0na7qot81eqgGloo3qjLYv+8uo3P6CbXbs/oTL Tm5VENXziEJEq2tbAQyHYZ2xcPWFOmOS5aEn6U5myZkAkMY/cOqSZYDq7oJxl1q2KZ3XS6DyAUJ z7mIxsgYQSF2Q7gn5gVIaB1oJ2IHPyvk2+lyEDTBA5iLTTNnjbQ6ERoHWwaZBNjdZjOip44KPtl FK7gTM02UsnC7apiA9/RIBJaxxuAnyw+oUCn4nmrYszLEyj4SUerXAtt7psHrufevkCWpkEF54W 38= X-Received: by 2002:a05:651c:543:b0:3a1:8dd6:aaf9 with SMTP id 38308e7fff4ca-3a371b871c6mr31427461fa.8.1788890262340; Tue, 08 Sep 2026 10:57:42 -0700 (PDT) Received: from localhost (soda.int.kasm.eu. [2001:678:a5c:1202:7b92:9ac1:b9ef:5287]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a3c2a44f1dsm34401741fa.33.2026.09.08.10.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 10:57:41 -0700 (PDT) Date: Tue, 8 Sep 2026 19:57:41 +0200 From: Klara Modin To: Alex Deucher Cc: Manuel Ebner , Thorsten Leemhuis , Alex Deucher , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Felix.Kuehling@amd.com, Mukul Joshi , Christian =?utf-8?B?S8O2bmln?= , Mark Brown , Miguel Ojeda , rust-for-linux@vger.kernel.org, Linux Next Mailing List Subject: Re: [PATCH 1/3] drm/gem: Add callback for when handle count goes to 0 Message-ID: References: <20260831183311.1090131-1-alexander.deucher@amd.com> <20260831183311.1090131-2-alexander.deucher@amd.com> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-09-08 12:03:57 -0400, Alex Deucher wrote: > On Mon, Sep 7, 2026 at 3:25 AM Klara Modin wrote: > > > > On 2026-09-05 11:31:41 +0200, Manuel Ebner wrote: > > > On Sat, 2026-09-05 at 07:36 +0200, Thorsten Leemhuis wrote: > > > > On 8/31/26 20:33, Alex Deucher wrote: > > > > > From: Mukul Joshi > > > > > ... > > > > ... > > > > > > > > > > error[E0063]: missing field `handle_free` in initializer of `drm_gem_object_funcs` > > > > > > --> rust/kernel/drm/gem/mod.rs:265:58 > > > > > > | > > > > > > 265 | const OBJECT_FUNCS: bindings::drm_gem_object_funcs = bindings::drm_gem_object_funcs { > > > > > > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `handle_free` > > > > > > > > > > > > error: aborting due to 1 previous error > > > > > > > > > > > > For more information about this error, try `rustc --explain E0063`. > > > > > > make[2]: *** [rust/Makefile:799: rust/kernel.o] Error 1 > > > > > > make[1]: *** [/builddir/build/BUILD/kernel-7.3.0-build/kernel-next-20260904/linux-7.3.0-0.0.next.20260904.221.vanilla.fc43.aarch64/Makefile:1442: prepare] Error 2 > > > > > > make: *** [Makefile:256: __sub-make] Error 2 > > > > """ > > > > Full log: > > > > https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-43-aarch64/10951622-next-next-all/builder-live.log.gz > > > > > > > > Reverting this change and 2/3 from this set fixed the problem for me. > > > > That leaves only the documentation without the feature so might as well > > drop 3/3 too in that case? > > > > Otherwise, the following also fixes it for me: > > > > diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs > > index e1ebad77ebe2..847e0ee38863 100644 > > --- a/rust/kernel/drm/gem/mod.rs > > +++ b/rust/kernel/drm/gem/mod.rs > > @@ -278,6 +278,7 @@ impl Object { > > vm_ops: core::ptr::null_mut(), > > evict: None, > > rss: None, > > + handle_free: None, > > }; > > > > /// Returns the `Device` that owns this GEM object. > > > > Can you send this as a proper patch? Here: https://lore.kernel.org/lkml/20260908175427.47207-1-klarasmodin@gmail.com I liked Gary's suggestion so went with that instead. > > Thanks, > > Alex Regards, Klara Modin > > > > > > > Verified. > > > > > > Thanks > > > Manuel > > > > > > > > Ciao, Thorsten > > > > > ... > > > > Regards, > > Klara Modin