Linux-Next discussions
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Manivannan Sadhasivam" <mani@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Lukas Wunner <lukas@wunner.de>,
	Priyank Rathod <rathodpriyank@google.com>
Subject: linux-next: manual merge of the pci tree with the pci-current tree
Date: Fri, 9 Oct 2026 21:27:14 +0200	[thread overview]
Message-ID: <aslAEm5Qsgp-9xD9@sirena.co.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 2571 bytes --]

Hi all,

Today's linux-next merge of the pci tree got a conflict in:

  drivers/pci/pcie/aer.c

between commit:

  79c168e2aa957 ("PCI/AER: Skip error recovery on false alarms")

from the pci-current tree and commit:

  d4c842c3af5bc ("PCI/AER: Fix memory leak in aer_recover_work_func() when pci_dev is missing")

from the pci tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

diff --cc drivers/pci/pcie/aer.c
index 922a726a52a50,c376c3adbefd2..0000000000000
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@@ -1373,16 -1370,9 +1372,15 @@@ static void aer_recover_work_func(struc
  					   entry.domain, entry.bus,
  					   PCI_SLOT(entry.devfn),
  					   PCI_FUNC(entry.devfn));
- 			continue;
- 		}
- 		pci_print_aer(pdev, entry.severity, entry.regs);
+ 		else
+ 			pci_print_aer(pdev, entry.severity, entry.regs);
  
 +		regs = entry.regs;
 +		if (entry.severity == AER_CORRECTABLE)
 +			err = regs->cor_status & ~regs->cor_mask;
 +		else
 +			err = regs->uncor_status & ~regs->uncor_mask;
 +
  		/*
  		 * Memory for aer_capability_regs(entry.regs) is being
  		 * allocated from the ghes_estatus_pool to protect it from
@@@ -1393,15 -1383,15 +1391,21 @@@
  		ghes_estatus_pool_region_free((unsigned long)entry.regs,
  					    sizeof(struct aer_capability_regs));
  
- 		if (err) {
- 			if (entry.severity == AER_NONFATAL)
- 				pcie_do_recovery(pdev, pci_channel_io_normal,
- 						 aer_root_reset);
- 			else if (entry.severity == AER_FATAL)
- 				pcie_do_recovery(pdev, pci_channel_io_frozen,
- 						 aer_root_reset);
+ 		if (pdev) {
 -			if (entry.severity == AER_NONFATAL)
 -				pcie_do_recovery(pdev, pci_channel_io_normal,
 -						 aer_root_reset);
 -			else if (entry.severity == AER_FATAL)
 -				pcie_do_recovery(pdev, pci_channel_io_frozen,
 -						 aer_root_reset);
++			if (err) {
++				if (entry.severity == AER_NONFATAL)
++					pcie_do_recovery(pdev,
++							 pci_channel_io_normal,
++							 aer_root_reset);
++				else if (entry.severity == AER_FATAL)
++					pcie_do_recovery(pdev,
++							 pci_channel_io_frozen,
++							 aer_root_reset);
++				}
++			}
++
+ 			pci_dev_put(pdev);
  		}
- 		pci_dev_put(pdev);
  	}
  }
  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

             reply	other threads:[~2026-10-09 19:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 19:27 Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-01-05  0:55 linux-next: manual merge of the pci tree with the pci-current tree Stephen Rothwell
2024-10-24  0:25 Stephen Rothwell
2024-10-24  6:56 ` Bartosz Golaszewski
2024-10-24 18:50   ` Bjorn Helgaas
2024-06-03  0:24 Stephen Rothwell
2018-08-01  0:42 Stephen Rothwell
2016-02-24  0:02 Stephen Rothwell
2014-03-12 13:00 Mark Brown
2010-03-26  0:57 Stephen Rothwell
2010-03-26  2:10 ` Jesse Barnes
2010-03-26  2:48   ` Stephen Rothwell
2010-03-26 16:03     ` Jesse Barnes
2010-03-26 14:43 ` Bjorn Helgaas
2009-02-06  2:50 Stephen Rothwell
2009-02-06 17:09 ` Jesse Barnes
2009-02-06 23:49   ` Rafael J. Wysocki
2009-02-07  0:07   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aslAEm5Qsgp-9xD9@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=lukas@wunner.de \
    --cc=mani@kernel.org \
    --cc=rathodpriyank@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox