From mboxrd@z Thu Jan 1 00:00:00 1970 From: simon@mungewell.org Subject: Re: [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS Date: Wed, 7 Dec 2011 16:07:38 -0500 Message-ID: References: <4EDFD23D.4030703@xenotime.net> <1323290039-28073-1-git-send-email-dh.herrmann@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: <1323290039-28073-1-git-send-email-dh.herrmann@googlemail.com> Sender: linux-input-owner@vger.kernel.org Cc: linux-input@vger.kernel.org, rdunlap@xenotime.net, linux-next@vger.kernel.org, jkosina@suse.cz, linux-kernel@vger.kernel.org, David Herrmann List-Id: linux-next.vger.kernel.org > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index edf2b2b..dae04a0 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -591,6 +591,7 @@ config HID_WIIMOTE > depends on BT_HIDP > depends on LEDS_CLASS > select POWER_SUPPLY > + select INPUT_FF_MEMLESS > ---help--- > Support for the Nintendo Wii Remote bluetooth device. I don't mean to be a complainer, but shouldn't the WiiMote module depend on FF_MEMLESS rather than just forcing it on. The module could also #define the appropriate bits so that FF_MEMLESS was only used when available, the rumble motor is a very small part of the WiiMote's feature set. Some people might not want FF_MEMLESS enabled. Simon.