From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 370E9C43603 for ; Thu, 12 Dec 2019 20:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06BF421556 for ; Thu, 12 Dec 2019 20:25:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VzOVCQ4I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730807AbfLLUZH (ORCPT ); Thu, 12 Dec 2019 15:25:07 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:56722 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730707AbfLLUZH (ORCPT ); Thu, 12 Dec 2019 15:25:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=v7N6TDWydEgKBMdMLfZYQErjn8bLk8UMDaEjHAUpiQU=; b=VzOVCQ4IFNcy/bhV5GSKmI5WV 7li6sfO9oXpUy2FVHTBP3eIZz1FgpS3DjEEWpNdMFTWcEMJv82pF6uB8OybwyFXcVNh08c9jrJbuQ 2wk+haDHeZ1WwfwWqviW7RZIoHknKKc3fCtC+f/5O3DlANsWCrhDX2LS3a11dHHBHJe8EMe0YjlH6 Q3tLvjGtpV7b85+9VlEmnp9dh6fVFGnKgbmJrK6Qm4qmXT4E/xTu8bzu5FIKLV8I/gUzdeQFs9RU3 89z2E2+zRtwxj2Ubq0KcUsUh6QTxinFes01SMFcTN6gWu7RRjUaqJDIm292dNhbddSMMnuKYzPHO+ LJGCFAhSg==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifV1H-0007YF-0S; Thu, 12 Dec 2019 20:25:07 +0000 Subject: Re: linux-next: Tree for Dec 6 (objtool, lots in btrfs) To: Josh Poimboeuf Cc: dsterba@suse.cz, Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Linux Btrfs , Peter Zijlstra References: <20191206135406.563336e7@canb.auug.org.au> <20191211134929.GL3929@twin.jikos.cz> <20191212184725.db3ost7rcopotr5u@treble> From: Randy Dunlap Message-ID: Date: Thu, 12 Dec 2019 12:25:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191212184725.db3ost7rcopotr5u@treble> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 12/12/19 10:47 AM, Josh Poimboeuf wrote: > On Wed, Dec 11, 2019 at 08:21:38AM -0800, Randy Dunlap wrote: >> [oops, forgot to add Josh and PeterZ] >> >> On 12/11/19 5:49 AM, David Sterba wrote: >>> On Fri, Dec 06, 2019 at 08:17:30AM -0800, Randy Dunlap wrote: >>>> On 12/5/19 6:54 PM, Stephen Rothwell wrote: >>>>> Hi all, >>>>> >>>>> Please do not add any material for v5.6 to your linux-next included >>>>> trees until after v5.5-rc1 has been released. >>>>> >>>>> Changes since 20191204: >>>>> >>>> >>>> on x86_64: >>>> >>>> fs/btrfs/ctree.o: warning: objtool: btrfs_search_slot()+0x2d4: unreachable instruction >>> >>> Can somebody enlighten me what is one supposed to do to address the >>> warnings? Function names reported in the list contain our ASSERT macro >>> that conditionally calls BUG() that I believe is what could cause the >>> unreachable instructions but I don't see how. >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/btrfs/ctree.h#n3113 >>> >>> __cold >>> static inline void assfail(const char *expr, const char *file, int line) >>> { >>> if (IS_ENABLED(CONFIG_BTRFS_ASSERT)) { >>> pr_err("assertion failed: %s, in %s:%d\n", expr, file, line); >>> BUG(); >>> } >>> } >>> >>> #define ASSERT(expr) \ >>> (likely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__)) >>> > > Randy, can you share one of the btrfs .o files? I'm not able to > recreate. > Hm. I'll have to try to recreate this. I no longer have files from 20191206 (lack of space). I'll let you know if/when I can recreate it. -- ~Randy