linux-next: build failure after merge of the i2c-host tree

linux-next: build failure after merge of the i2c-host tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

Hi all,

After merging the i2c-host tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/i2c/busses/i2c-qcom-geni.c: In function 'i2c_gpi_cb_result':
drivers/i2c/busses/i2c-qcom-geni.c:493:18: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
  493 |         status = FIELD_GET(I2C_DMA_TX_IRQ_MASK, i2c_res->status);
      |                  ^~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  313d6aa4c648 ("i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode")

I have used the i2c-host tree from next-20240308 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the i2c-host tree

[Andi Shyti]

Hi Stephen,

> After merging the i2c-host tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/i2c/busses/i2c-qcom-geni.c: In function 'i2c_gpi_cb_result':
> drivers/i2c/busses/i2c-qcom-geni.c:493:18: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
>   493 |         status = FIELD_GET(I2C_DMA_TX_IRQ_MASK, i2c_res->status);
>       |                  ^~~~~~~~~
> cc1: all warnings being treated as errors

sorry about that, will remove it.

Thanks,
Andi

linux-next: build failure after merge of the i2c-host tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Hi all,

After merging the i2c-host tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu14/smu_v14_0_2_ppt.c: In function 'smu_v14_0_2_i2c_control_init':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu14/smu_v14_0_2_ppt.c:1565:34: error: 'I2C_CLASS_SPD' undeclared (first use in this function); did you mean 'I2C_CLASS_HWMON'?
 1565 |                 control->class = I2C_CLASS_SPD;
      |                                  ^~~~~~~~~~~~~
      |                                  I2C_CLASS_HWMON

Caused by commit

  49b33f4b3a9e ("i2c: Remove I2C_CLASS_SPD")

interacting with commit

  3e55845c3983 ("drm/amd/swsmu: add smu v14_0_2 support")

from Linus' tree (in the current merge window).

I have used the i2c-host tree from next-20240521 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the i2c-host tree

[Heiner Kallweit]

On 22.05.2024 02:41, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the i2c-host tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu14/smu_v14_0_2_ppt.c: In function 'smu_v14_0_2_i2c_control_init':
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu14/smu_v14_0_2_ppt.c:1565:34: error: 'I2C_CLASS_SPD' undeclared (first use in this function); did you mean 'I2C_CLASS_HWMON'?
>  1565 |                 control->class = I2C_CLASS_SPD;
>       |                                  ^~~~~~~~~~~~~
>       |                                  I2C_CLASS_HWMON
> 
> Caused by commit
> 
>   49b33f4b3a9e ("i2c: Remove I2C_CLASS_SPD")
> 
> interacting with commit
> 
>   3e55845c3983 ("drm/amd/swsmu: add smu v14_0_2 support")
> 
> from Linus' tree (in the current merge window).
> 
> I have used the i2c-host tree from next-20240521 for today.
> 
This conflict has been resolved by:
e22e0e483b2c ("drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2")

Re: linux-next: build failure after merge of the i2c-host tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

Hi Heiner,

On Wed, 22 May 2024 07:33:03 +0200 Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> This conflict has been resolved by:
> e22e0e483b2c ("drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2")

Sure, but that patch is not in the i2c-host tree (or a branch that the
i2c-host tree includes), so I am still getting this failure.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the i2c-host tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

Hi all,

On Wed, 22 May 2024 10:41:28 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the i2c-host tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu14/smu_v14_0_2_ppt.c: In function 'smu_v14_0_2_i2c_control_init':
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu14/smu_v14_0_2_ppt.c:1565:34: error: 'I2C_CLASS_SPD' undeclared (first use in this function); did you mean 'I2C_CLASS_HWMON'?
>  1565 |                 control->class = I2C_CLASS_SPD;
>       |                                  ^~~~~~~~~~~~~
>       |                                  I2C_CLASS_HWMON
> 
> Caused by commit
> 
>   49b33f4b3a9e ("i2c: Remove I2C_CLASS_SPD")
> 
> interacting with commit
> 
>   3e55845c3983 ("drm/amd/swsmu: add smu v14_0_2 support")
> 
> from Linus' tree (in the current merge window).
> 
> I have used the i2c-host tree from next-20240521 for today.

This is now a failure after the merge of the i2c tree :-(

I have used the i2c tree from next-20240523 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the i2c-host tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hi all,

After merging the i2c-host tree, today's linux-next build (i386 defconfig)
failed like this:

drivers/i2c/busses/i2c-i801.c: In function 'i801_probe_optional_targets':
drivers/i2c/busses/i2c-i801.c:1180:54: error: 'struct i801_priv' has no member named 'mux_pdev'
 1180 |         if (!IS_ENABLED(CONFIG_I2C_I801_MUX) || !priv->mux_pdev) {
      |                                                      ^~

Caused by commit

  27f4a0d6938a ("i2c: i801: don't instantiate spd5118 under SPD Write Disable")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the i2c-host tree

[Andi Shyti]

Hi Stephen,

On Tue, May 06, 2025 at 07:11:14PM +1000, Stephen Rothwell wrote:
> After merging the i2c-host tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe_optional_targets':
> drivers/i2c/busses/i2c-i801.c:1180:54: error: 'struct i801_priv' has no member named 'mux_pdev'
>  1180 |         if (!IS_ENABLED(CONFIG_I2C_I801_MUX) || !priv->mux_pdev) {

uh yes, priv->mux_pdev is defined under CONFIG_I2C_I801_MUX.

Thanks Stephen! I will add this conditional compile test in my
flow.

I will revert the commit for now, as well.

Thank you,
Andi

linux-next: build failure after merge of the i2c-host tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2064 bytes --]

Hi all,

After merging the i2c-host tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from <command-line>:
drivers/i2c/busses/i2c-st.c: In function 'st_i2c_rd_fill_tx_fifo':
include/linux/compiler_types.h:568:45: error: call to '__compiletime_assert_369' declared with attribute error: min(max, 0x8 - tx_fstat) signedness error
  568 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |                                             ^
include/linux/compiler_types.h:549:25: note: in definition of macro '__compiletime_assert'
  549 |                         prefix ## suffix();                             \
      |                         ^~~~~~
include/linux/compiler_types.h:568:9: note: in expansion of macro '_compiletime_assert'
  568 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   93 |         BUILD_BUG_ON_MSG(!__types_ok(ux, uy),           \
      |         ^~~~~~~~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
   98 |         __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
      |         ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
  105 | #define min(x, y)       __careful_cmp(min, x, y)
      |                         ^~~~~~~~~~~~~
drivers/i2c/busses/i2c-st.c:453:13: note: in expansion of macro 'min'
  453 |         i = min(max, SSC_TXFIFO_SIZE - tx_fstat);
      |             ^~~

Caused by commit

  cbae4d3dd2f7 ("i2c: busses: Use min() to improve code")

I have used the i2c-host tree from next-20250703 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the i2c-host tree

[Qianfeng Rong]

在 2025/7/4 10:02, Stephen Rothwell 写道:
> Hi all,
>
> After merging the i2c-host tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from <command-line>:
> drivers/i2c/busses/i2c-st.c: In function 'st_i2c_rd_fill_tx_fifo':
> include/linux/compiler_types.h:568:45: error: call to '__compiletime_assert_369' declared with attribute error: min(max, 0x8 - tx_fstat) signedness error
>    568 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>        |                                             ^
> include/linux/compiler_types.h:549:25: note: in definition of macro '__compiletime_assert'
>    549 |                         prefix ## suffix();                             \
>        |                         ^~~~~~
> include/linux/compiler_types.h:568:9: note: in expansion of macro '_compiletime_assert'
>    568 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>        |         ^~~~~~~~~~~~~~~~~~~
> include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
>     39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>        |                                     ^~~~~~~~~~~~~~~~~~
> include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
>     93 |         BUILD_BUG_ON_MSG(!__types_ok(ux, uy),           \
>        |         ^~~~~~~~~~~~~~~~
> include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
>     98 |         __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
>        |         ^~~~~~~~~~~~~~~~~~
> include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
>    105 | #define min(x, y)       __careful_cmp(min, x, y)
>        |                         ^~~~~~~~~~~~~
> drivers/i2c/busses/i2c-st.c:453:13: note: in expansion of macro 'min'
>    453 |         i = min(max, SSC_TXFIFO_SIZE - tx_fstat);
>        |             ^~~
>
> Caused by commit
>
>    cbae4d3dd2f7 ("i2c: busses: Use min() to improve code")
>
> I have used the i2c-host tree from next-20250703 for today.

Hi all,

I'm sorry, I made a mistake,  can anyone help to roll back this patch?
But I want to ask if it's because I didn't compile with W=1 and didn't 
find this compilation error locally？
Anyway, I will learn from this lesson and be more careful in subsequent 
submissions.

Best regards,
Qianfeng
>

Re: linux-next: build failure after merge of the i2c-host tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Hi Qianfeng,

On Fri, 4 Jul 2025 10:16:08 +0800 Qianfeng Rong <rongqianfeng@vivo.com> wrote:
>
> I'm sorry, I made a mistake,  can anyone help to roll back this patch?
> But I want to ask if it's because I didn't compile with W=1 and
> didn't find this compilation error locally？ Anyway, I will learn
> from this lesson and be more careful in subsequent submissions.

I just did an arm multi_v7_defconfig build.  Building this file depends
on CONFIG_I2C_ST which in turn depend on ARCH_STI || COMPILE_TEST.  I
don't use W=1.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the i2c-host tree

[Qianfeng Rong]

Hi Stephen Rothwell，

在 2025/7/4 10:36, Stephen Rothwell 写道:
> Hi Qianfeng,
>
> On Fri, 4 Jul 2025 10:16:08 +0800 Qianfeng Rong <rongqianfeng@vivo.com> wrote:
>> I'm sorry, I made a mistake,  can anyone help to roll back this patch?
>> But I want to ask if it's because I didn't compile with W=1 and
>> didn't find this compilation error locally？ Anyway, I will learn
>> from this lesson and be more careful in subsequent submissions.
> I just did an arm multi_v7_defconfig build.  Building this file depends
> on CONFIG_I2C_ST which in turn depend on ARCH_STI || COMPILE_TEST.  I
> don't use W=1.
Thank you for your feedback. I did report this problem when I compiled
locally with 'make allyesconfig'.
This was caused by my carelessness and insufficient compilation locally.
I wonder if anyone can roll back this patch in time, or I can send a
'min_t(int, ...' version to fix this compilation error immediately.

Best regards,
Qianfeng