From: James Clark <james.clark@arm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Jonathan Corbet <corbet@lwn.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the jc_docs tree
Date: Fri, 7 Jan 2022 10:25:14 +0000 [thread overview]
Message-ID: <c13988e1-fd85-03e5-a05d-7bfee16d4c8d@arm.com> (raw)
In-Reply-To: <20220107103649.53774b30@canb.auug.org.au>
On 06/01/2022 23:36, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> e94f43ea200a ("docs: automarkup.py: Fix invalid HTML link output and broken URI fragments")
>
> Fixes tag
>
> Fixes: d18b01789ae5 ("docs: Add automatic cross-reference for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
Hi Stephen,
Which validator are you using for this output? checkpatch.pl has a validator for commit references
and it actually complains _more_ if it's not wrapped at 75 chars. At least for ones in the
body of the commit rather than the fixes reference. Which is a bit confusing if there is
a difference in the rule.
>
> Please do not split Fixes tags across more than one line.
>
Is this just for the fixes tag and not for the one in the body? Would you consider adding
this check to checkpatch.pl and submitting-patches.rst as I don't see that rule mentioned there.
@Jonathan, I'm happy to resubmit with the changes, but it might be easier if you just
make the fix in place.
Thanks
James
next prev parent reply other threads:[~2022-01-07 10:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 23:36 linux-next: Fixes tag needs some work in the jc_docs tree Stephen Rothwell
2022-01-07 10:25 ` James Clark [this message]
2022-01-07 16:19 ` Randy Dunlap
2022-01-10 10:30 ` James Clark
2022-01-07 16:35 ` Jonathan Corbet
-- strict thread matches above, loose matches on Subject: below --
2023-07-03 23:46 Stephen Rothwell
2023-07-04 14:32 ` Jonathan Corbet
2023-07-03 21:54 Stephen Rothwell
2022-03-28 20:58 Stephen Rothwell
2021-02-25 21:34 Stephen Rothwell
2021-02-25 21:39 ` Jonathan Corbet
2021-02-25 22:01 ` Stephen Rothwell
2021-02-25 22:35 ` Andrew Donnellan
2021-01-21 20:57 Stephen Rothwell
2019-05-20 21:44 Stephen Rothwell
2019-05-20 21:54 ` Jonathan Corbet
2019-05-21 7:18 ` Sven Eckelmann
2019-05-21 15:31 ` Jonathan Corbet
2019-05-21 18:23 ` Sven Eckelmann
2019-05-21 18:46 ` Jonathan Corbet
2019-05-21 18:52 ` Sven Eckelmann
2019-05-21 19:04 ` Jonathan Corbet
2019-05-21 19:05 ` Sven Eckelmann
2019-05-21 7:12 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c13988e1-fd85-03e5-a05d-7bfee16d4c8d@arm.com \
--to=james.clark@arm.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).