From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 737FB38DF6 for ; Tue, 19 Dec 2023 17:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nFqOwj5l" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40c3fe6c1b5so53145295e9.2 for ; Tue, 19 Dec 2023 09:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703008758; x=1703613558; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KN7dzTE7sSokESzZZ6AOq/Kgugkj07akzvWGzTORhac=; b=nFqOwj5l3cFPKESlbm+xd/SYDuNj56ogOZT1EtlY5WVzpCJSoaL+7nsNgqgwc0HltD xUsviHSz7trXK6yGbmt8r4atJCmkccaduh8Px9HyYVJD6sWF+wFyRmI+/wrNrWh7QsmX Uv9w0oH1k7J2MLhFk54HSAHbTaEZbolomz4X+3sszHeRlyT4KkjupIMOAVpNdKsliMn0 Ub5bWJmWl7/tHBAc7QSIZRXaYEJ60Krf/BKhV39nm/haaGLi6Ei9iywzNBQ+UUr4GEd5 niJv+b541bbhIkNw/ErnQbV98z7eykmorMITc413mNoxHNIYEeuJRnY+ATI5AIcGNWkZ feTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703008758; x=1703613558; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KN7dzTE7sSokESzZZ6AOq/Kgugkj07akzvWGzTORhac=; b=MtSFfISt88Jh+TLm2GzVsX1d21GYr62XdUj2WcfIDxcBp4fgdAlfOSUzp+ac6UJlTQ 95nOedpgKqMbPLYfNly20xJ1xE6x7oImVx/khKMiReveXSb0Xlsh1qcCKND7G63zmye7 ff3BNp6wBdkJL08o9IjzNwUbOkQaawqRELg1qWkoz48sECBqsKmVB8J5QlLmirhFrMge sbNfisdNQVXKJVTNaODkoNwm5qmEUbNmt+EfnBPAlpSonwI3bS8LgIJGkVDxclwjXzXm 9vojUY6TY69NQy8mBzJOtQveZomna0pYS7+TUEytAV1skSY1OcsPHFR/LwzZAP919COd 7g7g== X-Gm-Message-State: AOJu0Yys+7ckatLnVQJZBUKp2XKGzAawRNf7n+9qyXKtG8FwUxKtbMfP 4TDVfnfruWP3ZVKy9+0qLCMWXg== X-Google-Smtp-Source: AGHT+IEA1aPy4orFu8hYgiu7e0qrZnpoMLWlg4sYRg2lwRj2CDvRyJ7ChpR667R59lHN2eq1dGEpbQ== X-Received: by 2002:a05:600c:221a:b0:40b:5e1e:b3af with SMTP id z26-20020a05600c221a00b0040b5e1eb3afmr9988601wml.45.1703008758440; Tue, 19 Dec 2023 09:59:18 -0800 (PST) Received: from [192.168.10.46] ([37.170.14.102]) by smtp.googlemail.com with ESMTPSA id m39-20020a05600c3b2700b0040d23cea7bcsm1320165wms.1.2023.12.19.09.59.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 09:59:18 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 18:59:14 +0100 Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: build failure after merge of the thermal tree Content-Language: en-US To: Fabio Estevam , Stephen Rothwell Cc: Zhang Rui , Linux Kernel Mailing List , Linux Next Mailing List References: <20231219103457.4e034e9a@canb.auug.org.au> <68012fb93e0057f62c03a5d9b01237c4@denx.de> From: Daniel Lezcano In-Reply-To: <68012fb93e0057f62c03a5d9b01237c4@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 19/12/2023 03:10, Fabio Estevam wrote: > Hi Stephen, > > On 18/12/2023 20:34, Stephen Rothwell wrote: >> Hi all, >> >> After merging the thermal tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> ERROR: modpost: "__hw_protection_shutdown" >> [drivers/platform/chrome/cros_ec_lpcs.ko] undefined! >> >> Caused by commit >> >>   726edaad90f6 ("thermal/core: Prepare for introduction of thermal >> reboot") > > Thanks for reporting. > > Daniel, > > Could you please squash the following fix to the commit above? > > diff --git a/kernel/reboot.c b/kernel/reboot.c > index 07eb6537ed8b..f814568525f1 100644 > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, > int ms_until_forced, bool shut >         if (shutdown) >                 orderly_poweroff(true); >  } > +EXPORT_SYMBOL_GPL(__hw_protection_shutdown); Yeah, I've done it -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog