From mboxrd@z Thu Jan 1 00:00:00 1970 From: "=?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?=" Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k Date: Thu, 23 Oct 2008 18:51:35 +0200 Message-ID: References: <20081023213637.eff9b414.sfr@canb.auug.org.au> <49008D12.5090204@gmail.com> <4900B414.7090002@gmail.com> <20081023163433.GA3160@x200.localdomain> <20081023163850.GB16591@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from gv-out-0910.google.com ([216.239.58.184]:33921 "EHLO gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752927AbYJWQvj (ORCPT ); Thu, 23 Oct 2008 12:51:39 -0400 Received: by gv-out-0910.google.com with SMTP id e6so29681gvc.37 for ; Thu, 23 Oct 2008 09:51:35 -0700 (PDT) In-Reply-To: <20081023163850.GB16591@elte.hu> Content-Disposition: inline Sender: linux-next-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: Alexey Dobriyan , Geert Uytterhoeven , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt 2008/10/23 Ingo Molnar : > hm, zapped the commit then. > > the problem is most likely that none of these architectures is lockdep > enabled, hence they have no irqtrace wrappers, hence not all of the > tracers can be built on them? > > Ingo > But they should be able to use the tracing for several other tracers. One other problem is that you need CONFIG_TRACE_IRQFLAGS (is that a lockdep or just trace feature?) to use any tracer since the tracing_cpumask file is always created for all tracer. This file has tracing_cpumask_write() as a write operation, and this func uses raw_local_funcs.... Perhaps we should disable the tracing_cpu_mask related things if TRACE_IRQFLAGS in not configured?