From: Mikhail Zaslonko <zaslonko@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-next@vger.kernel.org, linux-s390@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
Alexander Egorenkov <egorenar@linux.ibm.com>,
Thomas Gleixner <tglx@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [linux-next][s390] Boot hang after merge c50f05bd3c4e (sched/hrtick)
Date: Thu, 5 Mar 2026 18:24:48 +0100 [thread overview]
Message-ID: <cfd76996-ecae-4ed9-add0-70ca2e59ef11@linux.ibm.com> (raw)
In-Reply-To: <20260305150210.7170D10-hca@linux.ibm.com>
On 05-Mar-26 16:02, Heiko Carstens wrote:
> On Thu, Mar 05, 2026 at 02:07:25PM +0100, Peter Zijlstra wrote:
>>>> Moving that before irq_enter_rcu() means it doesn't see HARDIRQ_OFFSET
>>>> in preempt_count(). As such, it might actually call into schedule() from
>>>> hardirq context.
>>>>
>>>> Or am I missing something?
>>>
>>> N/m, it turns into __this_cpu_add() and that doesn't have
>>> preempt_enable().
>>>
>>> 00d8b035eb71 ("s390/idle: Slightly optimize idle time accounting")
>>>
>>> Is actually a correctness fix afaict.
>
> Yes. Those dependencies become quite subtle when calling early into C code.
>
>> Another change is that you clear I and E in the PSW bit before
>> irq_enter_rcu(), which, per:
>>
>> 7e641e52cf5f ("softirq: Prepare for deferred hrtimer rearming")
>>
>> can re-arm the timer.
>>
>> So where previously it would re-arm and still have the I/E bits set, so
>> the timer could fire, they are now disabled.
>>
>> I really don't know if this is a problem; I'm clutching at s390 straws
>> here that I really don't know much about.
>
> That's the old PSW where the interrupt happened, not the one with which the
> CPU is running with, and shouldn't have any effect.
>
> ...but reverting that commit actually does fix it for me.
For me it doesn't. But reverting this one helps:
15dd3a948855 ("hrtimer: Push reprogramming timers into the interrupt return path")
next prev parent reply other threads:[~2026-03-05 17:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 18:31 [linux-next][s390] Boot hang after merge c50f05bd3c4e (sched/hrtick) Mikhail Zaslonko
2026-03-04 16:13 ` Mikhail Zaslonko
2026-03-05 7:49 ` Heiko Carstens
2026-03-05 12:12 ` Peter Zijlstra
2026-03-05 12:35 ` Peter Zijlstra
2026-03-05 12:45 ` Peter Zijlstra
2026-03-05 13:07 ` Peter Zijlstra
2026-03-05 15:02 ` Heiko Carstens
2026-03-05 17:24 ` Mikhail Zaslonko [this message]
2026-03-05 19:48 ` Heiko Carstens
2026-03-06 8:41 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd76996-ecae-4ed9-add0-70ca2e59ef11@linux.ibm.com \
--to=zaslonko@linux.ibm.com \
--cc=egorenar@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox