From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D454BC001B0 for ; Thu, 6 Jul 2023 23:26:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232055AbjGFX0d (ORCPT ); Thu, 6 Jul 2023 19:26:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231366AbjGFX02 (ORCPT ); Thu, 6 Jul 2023 19:26:28 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F3B31BD2; Thu, 6 Jul 2023 16:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=bDdj2ImLWq3orRh5mZ0i6CkrMO5thDbEKJP5vNXEszQ=; b=XOsOwJYXZVQ33w6XPomj04Renh yQFciK3I0zE9Zpzkq3abJrhB3iswgOvCHPxvjEYm27D9reaX9t91tKrcQRzF3ZEIg3mauARWtTTAq mkDRH/+DHf7c/IQjBIpMU4PFnWC9fZf/Mk4YhC1PQFDfKPMfiEuFAFgfkEk5RJRjPiB+/vzjoackT XUOGbqWSIFLQ12Va6M8GH4/uO7EvdbsNRrkafyM8Gy0Ocy6f6sDkMdBgAAnpJEndbyuC8i6sdMtKm oesPnV5GC8cZptTn4JM6aXCMsystUzju5zYlp/j7FmgU2bYHuhRANZ4BtXwvBvgDrM42R/4mR1FSe 7OmlOTMw==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qHYMh-002xMC-1W; Thu, 06 Jul 2023 23:26:23 +0000 Message-ID: Date: Thu, 6 Jul 2023 16:26:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs Content-Language: en-US To: Shannon Nelson , jasowang@redhat.com, mst@redhat.com, virtualization@lists.linux-foundation.org, brett.creeley@amd.com Cc: netdev@vger.kernel.org, drivers@pensando.io, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230706231718.54198-1-shannon.nelson@amd.com> From: Randy Dunlap In-Reply-To: <20230706231718.54198-1-shannon.nelson@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 7/6/23 16:17, Shannon Nelson wrote: > debugfs.h protects itself from an undefined DEBUG_FS, so it is > not necessary to check it in the driver code or the Makefile. > The driver code had been updated for this, but the Makefile had > missed the update. > > Link: https://lore.kernel.org/linux-next/fec68c3c-8249-7af4-5390-0495386a76f9@infradead.org/ > Fixes: a16291b5bcbb ("pds_vdpa: Add new vDPA driver for AMD/Pensando DSC") > Signed-off-by: Shannon Nelson Reviewed-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Thanks. > --- > drivers/vdpa/pds/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/vdpa/pds/Makefile b/drivers/vdpa/pds/Makefile > index 2e22418e3ab3..c2d314d4614d 100644 > --- a/drivers/vdpa/pds/Makefile > +++ b/drivers/vdpa/pds/Makefile > @@ -5,6 +5,5 @@ obj-$(CONFIG_PDS_VDPA) := pds_vdpa.o > > pds_vdpa-y := aux_drv.o \ > cmds.o \ > + debugfs.o \ > vdpa_dev.o > - > -pds_vdpa-$(CONFIG_DEBUG_FS) += debugfs.o -- ~Randy