Linux-Next discussions
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Markus Elfring <Markus.Elfring@web.de>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Damien Le Moal <dlemoal@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
	lkp@intel.com, oe-lkp@lists.linux.dev,
	Christian Brauner <brauner@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Christoph Hellwig <hch@lst.de>, Hillf Danton <hdanton@sina.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mark Brown <broonie@kernel.org>,
	Oliver Sang <oliver.sang@intel.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v7] loop: Fix NULL pointer dereference in lo_rw_aio()
Date: Mon, 31 Aug 2026 09:14:35 -0700	[thread overview]
Message-ID: <d7e26d4b-d9b9-47c0-9658-c241499209b5@acm.org> (raw)
In-Reply-To: <903a22a2-432c-4e72-bc09-7898becf2f3e@I-love.SAKURA.ne.jp>

On 8/28/26 10:17 PM, Tetsuo Handa wrote:
> Calling synchronize_rcu() makes sure that no more queue_work() calls are
> made from loop_queue_work() from loop_queue_rq(). Since loop_queue_rq() is
> called with RCU read lock, subsequent loop_queue_rq() calls which are made
> after synchronize_rcu() returned shall see lo->lo_state != Lo_bound and
> return with BLK_STS_IOERR.

Please add a comment above the synchronize_rcu() call that explains the
purpose of that call.

> That is OK. But after you agreed that my patch works as expected.
I appreciate your work and agree that this patch takes the right
direction. But I would appreciate it if you would take another look at
my review comments.

Thanks,

Bart.

  parent reply	other threads:[~2026-08-31 16:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260714043834.554-1-hdanton@sina.com>
2026-07-16  0:05 ` [PATCH v5] loop: Fix NULL pointer dereference in lo_rw_aio() Tetsuo Handa
2026-08-23 11:17   ` [PATCH v6] " Tetsuo Handa
2026-08-23 15:57     ` Markus Elfring
2026-08-24 22:06       ` Tetsuo Handa
2026-08-24 22:53         ` Bart Van Assche
2026-08-24 23:24           ` Bart Van Assche
2026-08-25 15:13             ` Tetsuo Handa
2026-08-25 22:18               ` Bart Van Assche
2026-08-25 23:28                 ` Tetsuo Handa
2026-08-25 23:16               ` Bart Van Assche
2026-08-26 10:37                 ` Tetsuo Handa
2026-08-26 17:44                   ` Bart Van Assche
2026-08-27 15:30                     ` Tetsuo Handa
2026-08-27 17:28                       ` Bart Van Assche
2026-08-28 15:53                         ` [PATCH v7] " Tetsuo Handa
2026-08-28 16:29                           ` Bart Van Assche
2026-08-29  5:17                             ` Tetsuo Handa
2026-08-29  5:55                               ` Tetsuo Handa
2026-08-31 14:11                                 ` Tao Cui
2026-08-31 15:49                                   ` Tetsuo Handa
2026-09-01 13:08                                     ` Tao Cui
2026-08-31 16:11                                   ` Bart Van Assche
2026-08-31 16:14                               ` Bart Van Assche [this message]
2026-09-03 23:15                                 ` [PATCH v7.1] " Tetsuo Handa
2026-09-03 23:50                                   ` [PATCH v8] " Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7e26d4b-d9b9-47c0-9658-c241499209b5@acm.org \
    --to=bvanassche@acm.org \
    --cc=Markus.Elfring@web.de \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=hdanton@sina.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox