Linux-Next discussions
 help / color / mirror / Atom feed
From: Bert Karwatzki <spasswolf@web.de>
To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
	 linux-rt-devel@lists.linux.dev, amd-gfx@lists.freedesktop.org,
	"# = v7 . 1" <stable@vger.kernel.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	Rafal Ostrowski <rafal.ostrowski@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	spasswwolf@web.de
Subject: Re: [PATCH] drm/amd/display: fix usage of DC_FPU_{BEGIN,END} with PREEMPT_RT
Date: Wed, 29 Jul 2026 19:46:30 +0200	[thread overview]
Message-ID: <df5f0d9bb8f11d098f086bd2ace5aa0cef4c77d7.camel@web.de> (raw)
In-Reply-To: <CABXGCsONHe2ST-==Gso2748i7W_POPiUAF2MrrmTuqoQr7z3gg@mail.gmail.com>

Am Dienstag, dem 28.07.2026 um 05:51 +0500 schrieb mikhail.v.gavrilov@gmail.com:
> One thing that may be worth adjusting in the commit message: this is
> not only a PREEMPT_RT problem.  183182235f6d was needed on a plain non-
> RT x86 kernel. There DC_FP_START() takes fpregs_lock(), which disables
> local softirqs, and dc_plane_state is around 335 KiB, so kvzalloc_obj()
> falls through to the vmalloc path and hits BUG_ON(in_interrupt()).  So
> on RT any allocation inside the FPU region is illegal, while on non-RT
> it is specifically the large ones - two failure modes, one root cause.

I think this was true when commit 
183182235f6d ("drm/amd/display: Wrap DCN32 phantom-plane allocation in DC_RUN_WITH_PREEMPTION_ENABLED")
was commited, but commit
04aa71da5f35 ("mm/vmalloc: do not trigger BUG() on BH disabled context")
changed the BUG_ON() in __get_vm_area_node():
diff --git a/mm/vmalloc.c b/mm/vmalloc.c

index c31a8615a832..bb6ae08d18f5 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3203,7 +3203,7 @@ struct vm_struct *__get_vm_area_node(unsigned long size,
        struct vm_struct *area;
        unsigned long requested_size = size;
 
-       BUG_ON(in_interrupt());
+       BUG_ON(in_nmi() || in_hardirq());
        size = ALIGN(size, 1ul << shift);
        if (unlikely(!size))
                return NULL;

so on non-PREEMPT_RT kernels DC_RUN_WITH_PREEMPTION_ENABLED is no
longer required for DCN32 phantom-plane allocation.

Bert Karwatzki

      reply	other threads:[~2026-07-29 17:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260723124353.13040-1-spasswolf@web.de>
2026-07-23 13:10 ` [Re] kernel panic during shutdown in v7.2-rc{3,4} and next-20260722 with PREEMPT_RT Bert Karwatzki
2026-07-23 13:23   ` Bert Karwatzki
2026-07-23 16:17     ` Bert Karwatzki
2026-07-23 22:51       ` [Re] kernel panic during shutdown in next-20260722 Bert Karwatzki
2026-07-24 15:08         ` Bert Karwatzki
2026-07-25 19:58           ` Bert Karwatzki
2026-07-25 23:16             ` Bert Karwatzki
2026-07-26 18:47               ` Bert Karwatzki
2026-07-26 22:52                 ` Bert Karwatzki
2026-07-27 10:06                   ` [Re] kernel panic during shutdown in v7.1+ with PREEMPT_RT Bert Karwatzki
2026-07-27 10:35                     ` Ostrowski, Rafal
2026-07-27 10:50                       ` [PATCH] drm/amd/display: fix usage of DC_FPU_{BEGIN,END} " Bert Karwatzki
2026-07-28  0:51                         ` mikhail.v.gavrilov
2026-07-29 12:35                           ` Bert Karwatzki
2026-07-29 14:39                             ` Mikhail Gavrilov
2026-07-29 17:46                               ` Bert Karwatzki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df5f0d9bb8f11d098f086bd2ace5aa0cef4c77d7.camel@web.de \
    --to=spasswolf@web.de \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mario.limonciello@amd.com \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=rafal.ostrowski@amd.com \
    --cc=spasswwolf@web.de \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox