public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Pratap Nirujogi <pratap.nirujogi@amd.com>
Cc: rdunlap@infradead.org, Hans de Goede <hdegoede@redhat.com>,
	 sfr@canb.auug.org.au, linux-next@vger.kernel.org,
	 platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	 benjamin.chan@amd.com, bin.du@amd.com,
	gjorgji.rosikopulos@amd.com,  king.li@amd.com, dantony@amd.com
Subject: Re: [PATCH 3/3] platform/x86: Use i2c adapter name to fix build errors
Date: Sat, 31 May 2025 08:11:48 +0300 (EEST)	[thread overview]
Message-ID: <ea615c2e-d306-06b2-10b0-2423ab59a8e9@linux.intel.com> (raw)
In-Reply-To: <20250530200234.1539571-4-pratap.nirujogi@amd.com>

On Fri, 30 May 2025, Pratap Nirujogi wrote:

> Use 'adapater->name' inplace of 'adapter->owner->name' to fix build issues
> when CONFIG_MODULES is not defined.
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")

This is the which should have this Fixes tag, the other commits should not 
have it as they're not really the fix (but this change just depends on 
them, but since stable is not in picture yet for this driver we don't 
need to indicate even those deps).

> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@amd.com>
> ---
>  drivers/platform/x86/amd/amd_isp4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/amd_isp4.c b/drivers/platform/x86/amd/amd_isp4.c
> index 0cc01441bcbb..80b57b58621a 100644
> --- a/drivers/platform/x86/amd/amd_isp4.c
> +++ b/drivers/platform/x86/amd/amd_isp4.c
> @@ -151,7 +151,7 @@ MODULE_DEVICE_TABLE(acpi, amdisp_sensor_ids);
>  
>  static inline bool is_isp_i2c_adapter(struct i2c_adapter *adap)
>  {
> -	return !strcmp(adap->owner->name, "i2c_designware_amdisp");
> +	return !strcmp(adap->name, "AMDISP DesignWare I2C adapter");

Since both are in-kernel code, share that name through a define in some 
header.

-- 
 i.


  reply	other threads:[~2025-05-31  5:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-30 19:59 [PATCH 0/3] Fix build issue when CONFIG_MODULES is not set Pratap Nirujogi
2025-05-30 19:59 ` [PATCH 1/3] i2c: designware: Initialize adapter name only when " Pratap Nirujogi
2025-05-31  5:14   ` Ilpo Järvinen
2025-06-03  3:18     ` Nirujogi, Pratap
2025-05-30 19:59 ` [PATCH 2/3] i2c: amd-isp: Initialize unique adpater name Pratap Nirujogi
2025-05-31  5:06   ` Ilpo Järvinen
2025-06-03  3:15     ` Nirujogi, Pratap
2025-05-30 19:59 ` [PATCH 3/3] platform/x86: Use i2c adapter name to fix build errors Pratap Nirujogi
2025-05-31  5:11   ` Ilpo Järvinen [this message]
2025-06-03  3:35     ` Nirujogi, Pratap
2025-06-03  4:46       ` Mario Limonciello
2025-06-03 15:50         ` Nirujogi, Pratap
2025-06-03  7:15       ` Ilpo Järvinen
2025-06-03 15:50         ` Nirujogi, Pratap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea615c2e-d306-06b2-10b0-2423ab59a8e9@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=benjamin.chan@amd.com \
    --cc=bin.du@amd.com \
    --cc=dantony@amd.com \
    --cc=gjorgji.rosikopulos@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=king.li@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pratap.nirujogi@amd.com \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox