From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
To: Miaohe Lin <linmiaohe@huawei.com>,
tj@kernel.org, hannes@cmpxchg.org, sfr@canb.auug.org.au,
lizefan.x@bytedance.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH] cgroup: put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED
Date: Tue, 11 Jul 2023 12:50:15 +0530 [thread overview]
Message-ID: <eafa31d1-9ead-75eb-a715-9012c233daa9@oracle.com> (raw)
In-Reply-To: <20230711023820.3854596-1-linmiaohe@huawei.com>
On 7/11/23 08:08, Miaohe Lin wrote:
> Put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED to fix the warning
> of 'cgroup_tryget_css' defined but not used [-Wunused-function] when
> CONFIG_CGROUP_SCHED is disabled.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> kernel/cgroup/cgroup.c | 44 +++++++++++++++++++++---------------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
Looks good to me, given that the only caller cgroup_extra_stat_show() is
guarded within CONFIG_CGROUP_SCHED (linux-next tree), it makes sense to,
also move cgroup_tryget_css() within the same ifdef block.
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
next prev parent reply other threads:[~2023-07-11 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 2:38 [PATCH] cgroup: put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED Miaohe Lin
2023-07-11 7:20 ` Kamalesh Babulal [this message]
2023-07-11 21:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eafa31d1-9ead-75eb-a715-9012c233daa9@oracle.com \
--to=kamalesh.babulal@oracle.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).