From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0A8C433DF for ; Wed, 29 Jul 2020 13:36:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 394ED208A9 for ; Wed, 29 Jul 2020 13:36:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MUEib7tF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbgG2NgC (ORCPT ); Wed, 29 Jul 2020 09:36:02 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:43688 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726391AbgG2NgC (ORCPT ); Wed, 29 Jul 2020 09:36:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596029761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UoAZNhHf1hQmOQfH+hbOw0J7WwqGHOBNlKUEao3PZkI=; b=MUEib7tFlEUUyxxpcbnRzIOWU6WpD7YocNkZqsVvHtnh3DyqaNRugj4taEpMu+U7s4QNgI PzcFibAbWq4+g007YydTz/CVsxoZedbAgQqsgNGCdo3ZsHPSJSfJeIwmetfwhuhBQEihO9 XUW6XbMp1qc4Q+BDgcfqP36/71JYVd8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-c2B0SQTRMF2tdMPs1dspbA-1; Wed, 29 Jul 2020 09:35:50 -0400 X-MC-Unique: c2B0SQTRMF2tdMPs1dspbA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1B141005504; Wed, 29 Jul 2020 13:35:47 +0000 (UTC) Received: from llong.remote.csb (ovpn-116-40.rdu2.redhat.com [10.10.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id C5F4F5DA7A; Wed, 29 Jul 2020 13:35:45 +0000 (UTC) Subject: Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop To: Herbert Xu , Stephen Rothwell Cc: Petr Mladek , Linux Next Mailing List , Linux Kernel Mailing List , Sergey Senozhatsky , Andy Shevchenko , "Steven Rostedt (VMware)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org References: <20200729210311.425d0e9b@canb.auug.org.au> <20200729114757.GA19388@gondor.apana.org.au> <20200729122807.GA7047@gondor.apana.org.au> From: Waiman Long Organization: Red Hat Message-ID: Date: Wed, 29 Jul 2020 09:35:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200729122807.GA7047@gondor.apana.org.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 7/29/20 8:28 AM, Herbert Xu wrote: > This miniseries breaks a header loop involving qspinlock_types.h. > The issue is that qspinlock_types.h includes atomic.h, which then > eventually includes kernel.h which could lead back to the original > file via spinlock_types.h. > > The first patch moves ATOMIC_INIT into linux/types.h while the second > patch actuallys breaks the loop by no longer including atomic.h > in qspinlock_types.h. > > Cheers, This patch series looks good to me. I just wonder if we should also move ATOMIC64_INIT() to types.h for symmetry purpose. Anyway, Acked-by: Waiman Long