From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F55DC433E0 for ; Thu, 11 Feb 2021 03:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D878F64EBB for ; Thu, 11 Feb 2021 03:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbhBKDab (ORCPT ); Wed, 10 Feb 2021 22:30:31 -0500 Received: from mga02.intel.com ([134.134.136.20]:31674 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbhBKDaa (ORCPT ); Wed, 10 Feb 2021 22:30:30 -0500 IronPort-SDR: RiF5eYBAqzJkLmTQS+l2l/cejBG+prbGwR79sbzAqDldW6jzRGYVv0S2SaHHe8P7c3KX/yidwt 5YigVXineFhg== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="169315031" X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="169315031" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 19:29:48 -0800 IronPort-SDR: MfbfcWjF2/AeA73asNEIFh0HW5OpiAC1h/QeeqZF7cTb1Lp0DvGX+0QM6mHzDd8YJo2WsR1JF8 jvqusn39GAlQ== X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="397071471" Received: from sliu49-mobl1.ccr.corp.intel.com (HELO [10.249.171.210]) ([10.249.171.210]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 19:29:46 -0800 Subject: Re: linux-next: Tree for Feb 10 (acrn) To: Randy Dunlap , Stephen Rothwell , Linux Next Mailing List Cc: Linux Kernel Mailing List , acrn-dev@lists.projectacrn.org References: <20210210224220.28657128@canb.auug.org.au> From: "Liu, Shuo A" Message-ID: Date: Thu, 11 Feb 2021 11:29:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 2/11/2021 01:52, Randy Dunlap wrote: > On 2/10/21 3:42 AM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20210209: >> > > ../drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’: > ../drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function ‘remove_cpu’; did you mean ‘register_cpu’? [-Werror=implicit-function-declaration] > remove_cpu(cpu); > > ../drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function ‘add_cpu’; did you mean ‘task_cpu’? [-Werror=implicit-function-declaration] > add_cpu(cpu); > > > Full randconfig file is attached. > Thanks. The vCPU removing depends on CONFIG_HOTPLUG_CPU. Below change could fix. --- diff --git a/drivers/virt/acrn/hsm.c b/drivers/virt/acrn/hsm.c index 1f6b7c54a1a4..e340788aacdf 100644 --- a/drivers/virt/acrn/hsm.c +++ b/drivers/virt/acrn/hsm.c @@ -372,6 +372,7 @@ static int acrn_dev_release(struct inode *inode, struct file *filp) return 0; } +#ifdef CONFIG_HOTPLUG_CPU static ssize_t remove_cpu_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -403,9 +404,12 @@ static ssize_t remove_cpu_store(struct device *dev, return ret; } static DEVICE_ATTR_WO(remove_cpu); +#endif static struct attribute *acrn_attrs[] = { +#ifdef CONFIG_HOTPLUG_CPU &dev_attr_remove_cpu.attr, +#endif NULL };