From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luciano Coelho Subject: Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS Date: Tue, 22 Jan 2019 12:15:03 +0200 Message-ID: References: <20190121233102.13705-1-okaya@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190121233102.13705-1-okaya@kernel.org> Sender: netdev-owner@vger.kernel.org To: Sinan Kaya , linux-next@vger.kernel.org Cc: Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , Kalle Valo , "David S. Miller" , "open list:INTEL WIRELESS WIFI LINK (iwlwifi)" , "open list:NETWORKING DRIVERS" , open list List-Id: linux-next.vger.kernel.org On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote: > There is an unresolved dependency as follows: > > IWLWIFI_LEDS selects MAC80211_LEDS. > MAC80211_LEDS depends on MAC80211. > > It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 > (n) > > WARNING: unmet direct dependencies detected for MAC80211_LEDS > Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && > LEDS_CLASS [=y] > Selected by [y]: > - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && > WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || > LEDS_CLASS [=y]=IWLWIFI [=y]) > > Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this > configuration. > > Signed-off-by: Sinan Kaya > --- Thanks for your patch! But we already have another patch to fix this issued queued for 5.0-rc4 (it's currently in wireless-drivers.git): https://patchwork.kernel.org/patch/10762079/