public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
To: Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
	sfrench@samba.org, pc@manguebit.org
Cc: skb99@linux.ibm.com, maddy@linux.ibm.com,
	linux-cifs@vger.kernel.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test
Date: Fri, 10 Apr 2026 23:53:43 +0800	[thread overview]
Message-ID: <f2beb294-1fa3-4370-906b-570616fc4b88@chenxiaosong.com> (raw)
In-Reply-To: <20260410150247.93178-2-venkat88@linux.ibm.com>

Looks good to me. Feel free to add:
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>

On 4/10/26 23:02, Venkat Rao Bagalkote wrote:
> On the latest linux-next following modpost warning is reported:
> 
>    WARNING: modpost: missing MODULE_DESCRIPTION() in
>    fs/smb/client/smb1maperror_test.o
> 
> Add MODULE_DESCRIPTION() to the test module to fix the warning.
> 
> Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---
> Changes in v3:
> - Update MODULE_DESCRIPTION as suggested in review
> 
>   fs/smb/client/smb1maperror_test.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
> index 820c0dd3bcce..2caaf11228ef 100644
> --- a/fs/smb/client/smb1maperror_test.c
> +++ b/fs/smb/client/smb1maperror_test.c
> @@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
>   kunit_test_suite(maperror_suite);
>   
>   MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("KUnit tests of SMB1 maperror");

-- 
ChenXiaoSong <chenxiaosong@kylinos.cn>
Chinese Homepage: chenxiaosong.com
English Homepage: chenxiaosong.com/en


  reply	other threads:[~2026-04-10 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 15:02 [PATCH v3] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test Venkat Rao Bagalkote
2026-04-10 15:53 ` ChenXiaoSong [this message]
2026-04-10 16:25   ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2beb294-1fa3-4370-906b-570616fc4b88@chenxiaosong.com \
    --to=chenxiaosong@chenxiaosong.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=pc@manguebit.org \
    --cc=sfrench@samba.org \
    --cc=skb99@linux.ibm.com \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox