linux-next: Signed-off-by missing for commit in the iio tree

linux-next: Signed-off-by missing for commit in the iio tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi all,

Commits

  a00cf70f16c9 ("iio: light: bd27008: Support BD27010 RGB")
  16a9947646f7 ("iio: light: bu27008: add chip info")
  ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the iio tree

[Matti Vaittinen]

Thanks Stephen!

On 8/8/23 01:39, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>    a00cf70f16c9 ("iio: light: bd27008: Support BD27010 RGB")
>    16a9947646f7 ("iio: light: bu27008: add chip info")
>    ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> 
> are missing a Signed-off-by from their committer.
> 

I am 99% sure I had SoB tags added in patches. Seems like they have been 
lost in the action.

Jonathan, do you need me to respin patches or how do you think we should 
fix this?

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Re: linux-next: Signed-off-by missing for commit in the iio tree

[Matti Vaittinen]

On 8/8/23 09:26, Matti Vaittinen wrote:
> Thanks Stephen!
> 
> On 8/8/23 01:39, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commits
>>
>>    a00cf70f16c9 ("iio: light: bd27008: Support BD27010 RGB")
>>    16a9947646f7 ("iio: light: bu27008: add chip info")
>>    ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering 
>> sensor")
>>
>> are missing a Signed-off-by from their committer.
>>
> 
> I am 99% sure I had SoB tags added in patches. 

100% sure now :)

https://lore.kernel.org/all/cover.1690958450.git.mazziesaccount@gmail.com/

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Re: linux-next: Signed-off-by missing for commit in the iio tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Hi Matti,

On Tue, 8 Aug 2023 09:26:08 +0300 Matti Vaittinen <mazziesaccount@gmail.com> wrote:
>
> Thanks Stephen!
> 
> On 8/8/23 01:39, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commits
> > 
> >    a00cf70f16c9 ("iio: light: bd27008: Support BD27010 RGB")
> >    16a9947646f7 ("iio: light: bu27008: add chip info")
> >    ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> > 
> > are missing a Signed-off-by from their committer.
> >   
> 
> I am 99% sure I had SoB tags added in patches. Seems like they have been lost in the action.

The missing SOB is from the committer not the author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the iio tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

Hi all,

Commit

  6ed193ca529e ("iio: amplifiers: hmc425a: Add Support HMC540S 4-bit Attenuator")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Signed-off-by missing for commit in the iio tree

[Hennerich, Michael]

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Dienstag, 12. September 2023 01:06
> To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Cusco, Ana-
> Maria <Ana-Maria.Cusco@analog.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> next@vger.kernel.org>
> Subject: linux-next: Signed-off-by missing for commit in the iio tree
> 
> 
> Hi all,
> 
> Commit
> 
>   6ed193ca529e ("iio: amplifiers: hmc425a: Add Support HMC540S 4-bit
> Attenuator")
> 
> is missing a Signed-off-by from its author.

Replied and added my Signed-off-by to the original patch.
 
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>

> 
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the iio tree

[Jonathan Cameron]

On Tue, 12 Sep 2023 06:37:17 +0000
"Hennerich, Michael" <Michael.Hennerich@analog.com> wrote:

> > -----Original Message-----
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Sent: Dienstag, 12. September 2023 01:06
> > To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Cusco, Ana-
> > Maria <Ana-Maria.Cusco@analog.com>; Linux Kernel Mailing List <linux-  
> > kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> > next@vger.kernel.org>  
> > Subject: linux-next: Signed-off-by missing for commit in the iio tree
> > 
> > 
> > Hi all,
> > 
> > Commit
> > 
> >   6ed193ca529e ("iio: amplifiers: hmc425a: Add Support HMC540S 4-bit
> > Attenuator")
> > 
> > is missing a Signed-off-by from its author.  
> 
> Replied and added my Signed-off-by to the original patch.
>  
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>

Hi Michael,

You missed and replied to the DT binding patch that followed this one.
I've taken above combined with that to be good enough confirmation that
you meant this one and added the sign off.  Great if you could confirm
that for the record though!

+CC linux-iio to keep the two discussions together.
+CC Krzysztof who asked about that rather odd looking SoB as well.

Jonathan

> 
> > 
> > --
> > Cheers,
> > Stephen Rothwell  

RE: linux-next: Signed-off-by missing for commit in the iio tree

[Hennerich, Michael]

> -----Original Message-----
> From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Sent: Dienstag, 12. September 2023 11:20
> To: Hennerich, Michael <Michael.Hennerich@analog.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>; Cusco, Ana-Maria <Ana-
> Maria.Cusco@analog.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> next@vger.kernel.org>; linux-iio@vger.kernel.org; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>
> Subject: Re: linux-next: Signed-off-by missing for commit in the iio tree
> 
> [External]
> 
> On Tue, 12 Sep 2023 06:37:17 +0000
> "Hennerich, Michael" <Michael.Hennerich@analog.com> wrote:
> 
> > > -----Original Message-----
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Sent: Dienstag, 12. September 2023 01:06
> > > To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> > > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Cusco, Ana-
> > > Maria <Ana-Maria.Cusco@analog.com>; Linux Kernel Mailing List
> > > <linux- kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> > > next@vger.kernel.org>
> > > Subject: linux-next: Signed-off-by missing for commit in the iio
> > > tree
> > >
> > >
> > > Hi all,
> > >
> > > Commit
> > >
> > >   6ed193ca529e ("iio: amplifiers: hmc425a: Add Support HMC540S 4-bit
> > > Attenuator")
> > >
> > > is missing a Signed-off-by from its author.
> >
> > Replied and added my Signed-off-by to the original patch.
> >
> > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> 
> Hi Michael,
> 
> You missed and replied to the DT binding patch that followed this one.
> I've taken above combined with that to be good enough confirmation that
> you meant this one and added the sign off.  Great if you could confirm that
> for the record though!

Sorry - my fault.

The Signed-off-by tag should have been for patch "iio: amplifiers: hmc425a: Add Support HMC540S 4-bit Attenuator"

Regards,
Michael

 

> 
> +CC linux-iio to keep the two discussions together.
> +CC Krzysztof who asked about that rather odd looking SoB as well.
> 
> Jonathan
> 
> >
> > >
> > > --
> > > Cheers,
> > > Stephen Rothwell

linux-next: Signed-off-by missing for commit in the iio tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

Hi all,

Commit

  1a521690c060 ("iio: adc: ad7606: explicit timestamp alignment")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the iio tree

[David Lechner]

On 5/4/25 4:48 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   1a521690c060 ("iio: adc: ad7606: explicit timestamp alignment")
> 
> is missing a Signed-off-by from its author.
> 

Thanks for reporting this. The oversight has been fixed.