* [PATCH] platform/x86/tuxedo: Prevent invalid Kconfig state
@ 2025-05-12 10:50 Werner Sembach
2025-05-12 10:57 ` Ilpo Järvinen
0 siblings, 1 reply; 3+ messages in thread
From: Werner Sembach @ 2025-05-12 10:50 UTC (permalink / raw)
To: rdunlap, sfr, linux-next, W_Armin, Werner Sembach, Hans de Goede,
Ilpo Järvinen
Cc: platform-driver-x86, linux-kernel
It was possible to create a uncompileable config, because of missing
"Depends on" statements in the new Kconfig of the TUXEDO platform driver.
For reference:
https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
drivers/platform/x86/tuxedo/nbxx/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/tuxedo/nbxx/Kconfig b/drivers/platform/x86/tuxedo/nbxx/Kconfig
index 1701374a039d2..9eecbe8127df7 100644
--- a/drivers/platform/x86/tuxedo/nbxx/Kconfig
+++ b/drivers/platform/x86/tuxedo/nbxx/Kconfig
@@ -7,6 +7,8 @@
config TUXEDO_NBXX_ACPI_TUXI
tristate "TUXEDO NBxx ACPI TUXI Platform Driver"
+ depends on ACPI_WMI
+ depends on HID
help
This driver implements the ACPI TUXI device found on some TUXEDO
notebooks. This enables the control of built-in fans via HWMON.
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86/tuxedo: Prevent invalid Kconfig state
2025-05-12 10:50 [PATCH] platform/x86/tuxedo: Prevent invalid Kconfig state Werner Sembach
@ 2025-05-12 10:57 ` Ilpo Järvinen
2025-05-12 11:16 ` Werner Sembach
0 siblings, 1 reply; 3+ messages in thread
From: Ilpo Järvinen @ 2025-05-12 10:57 UTC (permalink / raw)
To: Werner Sembach
Cc: rdunlap, sfr, linux-next, W_Armin, Hans de Goede,
platform-driver-x86, LKML
On Mon, 12 May 2025, Werner Sembach wrote:
> It was possible to create a uncompileable config, because of missing
> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
>
> For reference:
> https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
Please add a Reported-by tag and you can put that URL into Link: tag.
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/platform/x86/tuxedo/nbxx/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/tuxedo/nbxx/Kconfig b/drivers/platform/x86/tuxedo/nbxx/Kconfig
> index 1701374a039d2..9eecbe8127df7 100644
> --- a/drivers/platform/x86/tuxedo/nbxx/Kconfig
> +++ b/drivers/platform/x86/tuxedo/nbxx/Kconfig
Eh, what's this path? There's only nb04/.
> @@ -7,6 +7,8 @@
>
> config TUXEDO_NBXX_ACPI_TUXI
> tristate "TUXEDO NBxx ACPI TUXI Platform Driver"
> + depends on ACPI_WMI
> + depends on HID
> help
> This driver implements the ACPI TUXI device found on some TUXEDO
> notebooks. This enables the control of built-in fans via HWMON.
>
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86/tuxedo: Prevent invalid Kconfig state
2025-05-12 10:57 ` Ilpo Järvinen
@ 2025-05-12 11:16 ` Werner Sembach
0 siblings, 0 replies; 3+ messages in thread
From: Werner Sembach @ 2025-05-12 11:16 UTC (permalink / raw)
To: Ilpo Järvinen
Cc: rdunlap, sfr, linux-next, W_Armin, Hans de Goede,
platform-driver-x86, LKML
Am 12.05.25 um 12:57 schrieb Ilpo Järvinen:
> On Mon, 12 May 2025, Werner Sembach wrote:
>
>> It was possible to create a uncompileable config, because of missing
>> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
>>
>> For reference:
>> https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
> Please add a Reported-by tag and you can put that URL into Link: tag.
Ok
>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>> drivers/platform/x86/tuxedo/nbxx/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/tuxedo/nbxx/Kconfig b/drivers/platform/x86/tuxedo/nbxx/Kconfig
>> index 1701374a039d2..9eecbe8127df7 100644
>> --- a/drivers/platform/x86/tuxedo/nbxx/Kconfig
>> +++ b/drivers/platform/x86/tuxedo/nbxx/Kconfig
> Eh, what's this path? There's only nb04/.
Sorry brainfail was on the wrong branch, just looks almost the same
>
>> @@ -7,6 +7,8 @@
>>
>> config TUXEDO_NBXX_ACPI_TUXI
>> tristate "TUXEDO NBxx ACPI TUXI Platform Driver"
>> + depends on ACPI_WMI
>> + depends on HID
>> help
>> This driver implements the ACPI TUXI device found on some TUXEDO
>> notebooks. This enables the control of built-in fans via HWMON.
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-12 11:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-12 10:50 [PATCH] platform/x86/tuxedo: Prevent invalid Kconfig state Werner Sembach
2025-05-12 10:57 ` Ilpo Järvinen
2025-05-12 11:16 ` Werner Sembach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox