linux-next: build failure after merge of the tty.current tree

linux-next: build failure after merge of the tty.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

Hi all,

After merging the tty.current tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
  804 |                 uart_unlock_and_check_sysrq_irqrestore(port, flags);
      |                                                              ^~~~~
drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")

I have used the tty.current tree from next-20230119 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the tty.current tree

[Marek Vasut]

On 1/19/23 21:58, Stephen Rothwell wrote:
> Hi all,

Hi,

> After merging the tty.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
> drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
>    804 |                 uart_unlock_and_check_sysrq_irqrestore(port, flags);
>        |                                                              ^~~~~
> drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>    f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")
> 
> I have used the tty.current tree from next-20230119 for today.

I already proposed a fix in the build robot report

[tty:tty-linus 4/7] drivers/tty/serial/stm32-usart.c:804:62: error: 
'flags' undeclared

Now waiting for Johan to confirm that's the correct approach.

Re: linux-next: build failure after merge of the tty.current tree

[Greg KH]

On Fri, Jan 20, 2023 at 07:58:32AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tty.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
> drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
>   804 |                 uart_unlock_and_check_sysrq_irqrestore(port, flags);
>       |                                                              ^~~~~
> drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>   f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")
> 
> I have used the tty.current tree from next-20230119 for today.

Should now be fixed up as I reverted this, thanks!

greg k-h

linux-next: build failure after merge of the tty.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

Hi Greg,

After merging the tty.current tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from drivers/tty/serial/imx.c:42:0:
drivers/tty/serial/imx.c: In function 'imx_start_tx':
drivers/tty/serial/imx.c:570:27: error: request for member 'state' in something not a structure or union
  if (uart_circ_empty(&port.state->xmit))
                           ^
include/linux/serial_core.h:336:34: note: in definition of macro 'uart_circ_empty'
 #define uart_circ_empty(circ)  ((circ)->head == (circ)->tail)
                                  ^
drivers/tty/serial/imx.c:570:27: error: request for member 'state' in something not a structure or union
  if (uart_circ_empty(&port.state->xmit))
                           ^
include/linux/serial_core.h:336:50: note: in definition of macro 'uart_circ_empty'
 #define uart_circ_empty(circ)  ((circ)->head == (circ)->tail)
                                                  ^

Caused by commit c557d392fbf5 ("serial: Test for no tx data on tx
restart").  That can't have been build tested :-(

I have used the tty.current tree from next-20140710 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the tty.current tree

[Peter Hurley]

On 07/10/2014 09:21 PM, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the tty.current tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
[...]
> Caused by commit c557d392fbf5 ("serial: Test for no tx data on tx
> restart").  That can't have been build tested :-(

Sorry about that. I don't have a full cross-compiler setup for
build testing. Looks like that's something I'm going to have to add.

Regards,
Peter Hurley

Re: linux-next: build failure after merge of the tty.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Hi Peter,

On Fri, 11 Jul 2014 11:06:56 -0400 Peter Hurley <peter@hurleysoftware.com> wrote:
>
> Sorry about that. I don't have a full cross-compiler setup for
> build testing. Looks like that's something I'm going to have to add.

see https://www.kernel.org/pub/tools/crosstool/

These are only good for building the kernel (no libc).

You don't necessarily need to build the whole kernel but often just
building the particular drivers is enough.  Especially if they are
directly modified ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the tty.current tree

[Peter Hurley]

On 07/11/2014 09:20 PM, Stephen Rothwell wrote:
> Hi Peter,
>
> On Fri, 11 Jul 2014 11:06:56 -0400 Peter Hurley <peter@hurleysoftware.com> wrote:
>>
>> Sorry about that. I don't have a full cross-compiler setup for
>> build testing. Looks like that's something I'm going to have to add.
>
> see https://www.kernel.org/pub/tools/crosstool/
>
> These are only good for building the kernel (no libc).
>
> You don't necessarily need to build the whole kernel but often just
> building the particular drivers is enough.  Especially if they are
> directly modified ...

Hi Stephen,

Thanks for the link. I had found Shuah Khan's slideshow pdf on cross-compiler
packages earlier and so have already started down that path.

Regards,
Peter Hurley

Re: linux-next: build failure after merge of the tty.current tree

[Peter Hurley]

On 07/12/2014 09:02 AM, Peter Hurley wrote:
> On 07/11/2014 09:20 PM, Stephen Rothwell wrote:
>> Hi Peter,
>>
>> On Fri, 11 Jul 2014 11:06:56 -0400 Peter Hurley <peter@hurleysoftware.com> wrote:
>>>
>>> Sorry about that. I don't have a full cross-compiler setup for
>>> build testing. Looks like that's something I'm going to have to add.
>>
>> see https://www.kernel.org/pub/tools/crosstool/
>>
>> These are only good for building the kernel (no libc).
>>
>> You don't necessarily need to build the whole kernel but often just
>> building the particular drivers is enough.  Especially if they are
>> directly modified ...
>
> Hi Stephen,
>
> Thanks for the link. I had found Shuah Khan's slideshow pdf on cross-compiler
> packages earlier and so have already started down that path.

Just an fyi,

The cross-compiler packages of the emdebian project in the unstable (aka, "sid")
distribution have broken dependencies.

So the instructions here
http://events.linuxfoundation.org/sites/events/files/slides/Shuah_Khan_cross_compile_linux.pdf
and here
http://linuxdriverproject.org/mediawiki/index.php/Cross-compiling_Linux_kernel_on_x86_64#Installation_Steps
are no longer applicable.

Regards,
Peter Hurley