linux-next: sysctl tree build failure

linux-next: sysctl tree build failure

[Stephen Rothwell]

Hi Eric,

Today's linux-next build (powerpc allnoconfig) failed like this:

kernel/built-in.o: In function `get_sysctl':
sysctl_binary.c:(.text+0x100d4): undefined reference to `dev_get_by_index'

Caused by commit 26a7034b40ba80f82f64fa251a2cbf49f9971c6a ("sysctl:
Reduce sys_sysctl to a compatibility wrapper around /proc/sys").

CONFIG_NET is not set for this build.

I have used this patch for today:
(It does produce this warning, though:

kernel/sysctl_binary.c:1253: warning: unused variable 'net'

so needs more work.)

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 12 Nov 2009 18:43:35 +1100
Subject: [PATCH] sysctl: fix build dependency on CONFIG_NET

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 kernel/sysctl_binary.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
index 471438b..4f58ea7 100644
--- a/kernel/sysctl_binary.c
+++ b/kernel/sysctl_binary.c
@@ -1270,6 +1270,7 @@ repeat:
 		if (ctl_name == table->ctl_name)
 			procname = table->procname;
 
+#ifdef CONFIG_NET
 		/*
 		 * For a wild card entry map from ifindex to network
 		 * device name.
@@ -1279,6 +1280,7 @@ repeat:
 			if (dev)
 				procname = dev->name;
 		}
+#endif
 		if (procname) {
 			int len;
 
-- 
1.6.5.2

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: sysctl tree build failure

[Eric W. Biederman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Eric,
>
> Today's linux-next build (powerpc allnoconfig) failed like this:
>
> kernel/built-in.o: In function `get_sysctl':
> sysctl_binary.c:(.text+0x100d4): undefined reference to `dev_get_by_index'
>
> Caused by commit 26a7034b40ba80f82f64fa251a2cbf49f9971c6a ("sysctl:
> Reduce sys_sysctl to a compatibility wrapper around /proc/sys").
>
> CONFIG_NET is not set for this build.
>
> I have used this patch for today:
> (It does produce this warning, though:
>
> kernel/sysctl_binary.c:1253: warning: unused variable 'net'
>
> so needs more work.)

Thank you, and my apologies.  I thought I had tried it with every
applicable compile option but apparently not.

Ugh.  It looks like I have a small refcount leak in that case as
well.  Blind I was.

Thank you very I will have this fixed shortly.

Eric

Re: linux-next: sysctl tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi Eric,

On Thu, 12 Nov 2009 00:08:59 -0800 ebiederm@xmission.com (Eric W. Biederman) wrote:
>
> Thank you, and my apologies.  I thought I had tried it with every
> applicable compile option but apparently not.
> 
> Ugh.  It looks like I have a small refcount leak in that case as
> well.  Blind I was.
> 
> Thank you very I will have this fixed shortly.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sysctl tree build failure

[Eric W. Biederman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Eric,
>
> On Thu, 12 Nov 2009 00:08:59 -0800 ebiederm@xmission.com (Eric W. Biederman) wrote:
>>
>> Thank you, and my apologies.  I thought I had tried it with every
>> applicable compile option but apparently not.
>> 
>> Ugh.  It looks like I have a small refcount leak in that case as
>> well.  Blind I was.
>> 
>> Thank you very I will have this fixed shortly.
>
> Thanks.

Any clue how all_noconfig happened to have CONFIG_SYSCTL_SYSCALL set?

Eric

Re: linux-next: sysctl tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hi Eric,

On Thu, 12 Nov 2009 01:11:34 -0800 ebiederm@xmission.com (Eric W. Biederman) wrote:
>
> Any clue how all_noconfig happened to have CONFIG_SYSCTL_SYSCALL set?

CONFIG_SYSCTL_SYSCALL defaults to y and only depends on
CONFIG_PROC_SYSCTL which also defaults to y and depends on CONFIG_PROC_FS
which also defaults to y.  All three are only selectable if
CONFIG_EMBEDDED is y (which it obviously isn't).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sysctl tree build failure

[Eric W. Biederman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Eric,
>
> On Thu, 12 Nov 2009 01:11:34 -0800 ebiederm@xmission.com (Eric W. Biederman) wrote:
>>
>> Any clue how all_noconfig happened to have CONFIG_SYSCTL_SYSCALL set?
>
> CONFIG_SYSCTL_SYSCALL defaults to y and only depends on
> CONFIG_PROC_SYSCTL which also defaults to y and depends on CONFIG_PROC_FS
> which also defaults to y.  All three are only selectable if
> CONFIG_EMBEDDED is y (which it obviously isn't).

Ah so.  An interesting twist of fate.  Thank you for satisfying my
curiosity.

Eric