* Re: linux-next: ftrace tree build warnings
From: Ingo Molnar @ 2008-11-25 8:00 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, H. Peter Anvin, linux-next, Steven Rostedt,
Alan Cox
In-Reply-To: <20081125133828.8f9b49df.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Today's linux-next build (x86_64 allmodconfig) produced lots of these
> warnings:
>
> include/linux/tty.h:330: warning: '______f' is static but declared in inline function 'tty_kref_get' which is not static
>
> Caused by commit 2bcd521a684cc94befbe2ce7d5b613c841b0d304 ("trace:
> profile all if conditionals"). Something needs to be done about
> this ... maybe tty_kref_get needs to be "static inline" instead of
> "extern inline"?
i've queued up the fix below, and pushed out a new ftrace-next tree.
Thanks,
Ingo
------------------>
From 14bfc987e395797dfe03e915e8b4c7fc9e5078e4 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 25 Nov 2008 08:58:11 +0100
Subject: [PATCH] tracing, tty: fix warnings caused by branch tracing and tty_kref_get()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Stephen Rothwell reported tht this warning started triggering in
linux-next:
In file included from init/main.c:27:
include/linux/tty.h: In function ‘tty_kref_get’:
include/linux/tty.h:330: warning: ‘______f’ is static but declared in inline function ‘tty_kref_get’ which is not static
Which gcc emits for 'extern inline' functions that nevertheless define
static variables. Change it to 'static inline', which is the norm
in the kernel anyway.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/tty.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 3b8121d..eaec37c 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -325,7 +325,7 @@ extern struct class *tty_class;
* go away
*/
-extern inline struct tty_struct *tty_kref_get(struct tty_struct *tty)
+static inline struct tty_struct *tty_kref_get(struct tty_struct *tty)
{
if (tty)
kref_get(&tty->kref);
^ permalink raw reply related
* Re: linux-next: ftrace tree build failure
From: Stephen Rothwell @ 2008-11-25 7:43 UTC (permalink / raw)
To: Ingo Molnar
Cc: Thomas Gleixner, H. Peter Anvin, linux-next, Steven Rostedt,
Luis R. Rodriguez, John W. Linville, David S. Miller
In-Reply-To: <20081125072801.GA15592@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
Hi Ingo,
On Tue, 25 Nov 2008 08:28:01 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> this fix is wrong - the intention of that line was to add a proper
> WARN(), not a WARN_ON(). Your change loses the message that WARN()
> prints.
>
> i posted a tested fix for this two days ago:
>
> http://marc.info/?l=linux-kernel&m=122745649425646&w=2
>
> see it also below.
Yeah, Steve told me. However, it might have been useful to tell the
wireless maintainer, the network maintainer and the original author (and
probably netdev - which I also left off).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Ingo Molnar @ 2008-11-25 7:28 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, H. Peter Anvin, linux-next, Steven Rostedt,
Luis R. Rodriguez, John W. Linville, David S. Miller
In-Reply-To: <20081125140719.03a8cdfb.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> net/wireless/reg.c:348:29: error: macro "if" passed 2 arguments, but takes just 1
> net/wireless/reg.c: In function 'ignore_request':
> net/wireless/reg.c:349: error: expected '(' before 'return'
>
> This is clearly a bug in in the above file and should be fixed there, so
> I have applied the following patch for today. I expect some patch to fix
> this to appear in the wireless-current or net-current tree very soon.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
> diff --git a/net/wireless/reg.c b/net/wireless/reg.c
> index 626dbb6..648c765 100644
> --- a/net/wireless/reg.c
> +++ b/net/wireless/reg.c
> @@ -343,9 +343,7 @@ static int ignore_request(struct wiphy *wiphy, enum reg_set_by set_by,
> return 0;
> return -EALREADY;
> }
> - if (WARN_ON(!is_alpha2_set(alpha2) || !is_an_alpha2(alpha2)),
> - "Invalid Country IE regulatory hint passed "
> - "to the wireless core\n")
> + if (WARN_ON(!is_alpha2_set(alpha2) || !is_an_alpha2(alpha2)))
this fix is wrong - the intention of that line was to add a proper
WARN(), not a WARN_ON(). Your change loses the message that WARN()
prints.
i posted a tested fix for this two days ago:
http://marc.info/?l=linux-kernel&m=122745649425646&w=2
see it also below.
Ingo
--------------->
>From de734ba59d249ee785a1ead600e5a6ea1dd62639 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Sun, 23 Nov 2008 20:09:54 +0100
Subject: [PATCH] net/wireless/reg.c: fix
fix:
net/wireless/reg.c:348:29: error: macro "if" passed 2 arguments, but takes just 1
triggered by the branch-tracer.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
# Please enter the commit message for your changes. Lines starting
---
net/wireless/reg.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 626dbb6..eb3b1a9 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -343,9 +343,9 @@ static int ignore_request(struct wiphy *wiphy, enum reg_set_by set_by,
return 0;
return -EALREADY;
}
- if (WARN_ON(!is_alpha2_set(alpha2) || !is_an_alpha2(alpha2)),
+ if (WARN(!is_alpha2_set(alpha2) || !is_an_alpha2(alpha2),
"Invalid Country IE regulatory hint passed "
- "to the wireless core\n")
+ "to the wireless core\n"))
return -EINVAL;
/* We ignore Country IE hints for now, as we haven't yet
* added the dot11MultiDomainCapabilityEnabled flag
^ permalink raw reply related
* Re: linux-next: ftrace tree build failure
From: Stephen Rothwell @ 2008-11-25 7:26 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Steven Rostedt, Thomas Gleixner, H. Peter Anvin, linux-next
In-Reply-To: <20081125071436.GA9660@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
Hi Ingo,
On Tue, 25 Nov 2008 08:14:36 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> i've applied the assembly constraint fix to the x86 tree and i've
> integrated a new version of auto-x86-next which includes the fix, and
> pushed it out.
Thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: [PATCH] use limited register constraint for setnz
From: Ingo Molnar @ 2008-11-25 7:22 UTC (permalink / raw)
To: Steven Rostedt
Cc: LKML, Thomas Gleixner, Andrew Morton, Linus Torvalds,
Stephen Rothwell, linux-next
In-Reply-To: <alpine.DEB.1.10.0811250040060.2977@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Impact: fix in compiling
>
> GCC can decide to use %dil when "r" is used, which is not valid for
> setnz.
>
> This bug was brought out by Stephen Rothwell's merging of the
> branch tracer into linux-next.
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
>
> diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
> index 0be77b3..c2121d2 100644
> --- a/arch/x86/boot/tty.c
> +++ b/arch/x86/boot/tty.c
> @@ -74,7 +74,7 @@ static int kbd_pending(void)
> {
> u8 pending;
> asm volatile("int $0x16; setnz %0"
> - : "=rm" (pending)
> + : "=Qm" (pending)
> : "a" (0x0100));
> return pending;
> }
applied to tip/x86/urgent, thanks Steve!
Ingo
^ permalink raw reply
* linux-next: manual merge of the firmware tree
From: Stephen Rothwell @ 2008-11-25 7:21 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-next, Matt Carlson, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
Hi David,
Today's linux-next merge of the firmware tree got a conflict in
drivers/net/tg3.c between commit d5fe488a7b59e41b98b91137805159466b7b49c2
("tg3: Embrace pci_ioremap_bar()") from the net tree and commit
aadd3ed38a6745e21dc8d2f388bbba42ead0a085 ("firmware: convert tg3 driver
to request_firmware()") from the firmware tree.
The former removed some code that the latter modified. I have fixed it
up (by removing the hunk of code) and can carry the fix as
necessary.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Ingo Molnar @ 2008-11-25 7:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Steven Rostedt, Thomas Gleixner, H. Peter Anvin, linux-next
In-Reply-To: <20081125175708.d28d08cd.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Steve,
>
> On Tue, 25 Nov 2008 00:44:16 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
> >
> > Yep, it was the wrong constraint used in the asm. Googling around, I
> > found a similar bug listed in gcc, which was not a bug.
>
> Amazing what we trip over :-(
>
> > Patch has been sent to fix this.
>
> Can you put that patch in your tree as well, or will it reach
> linux-next quickly enough anyway?
i've applied the assembly constraint fix to the x86 tree and i've
integrated a new version of auto-x86-next which includes the fix, and
pushed it out.
Thanks,
Ingo
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Stephen Rothwell @ 2008-11-25 6:57 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
In-Reply-To: <1227591856.7622.26.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
Hi Steve,
On Tue, 25 Nov 2008 00:44:16 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
>
> Yep, it was the wrong constraint used in the asm. Googling around, I
> found a similar bug listed in gcc, which was not a bug.
Amazing what we trip over :-(
> Patch has been sent to fix this.
Can you put that patch in your tree as well, or will it reach linux-next
quickly enough anyway?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* linux-next: manual merge of the kvm tree
From: Stephen Rothwell @ 2008-11-25 6:49 UTC (permalink / raw)
To: Avi Kivity
Cc: linux-next, H. Peter Anvin, Thomas Gleixner, Ingo Molnar,
Eduardo Habkost
[Resent to get past vgers filters]
Hi Avi,
Today's linux-next merge of the kvm tree got a conflict in
arch/x86/kernel/reboot.c between commit
14d7ca5c575853664d8fe4f225a77b8df1b7de7d ("x86: attempt reboot via port
CF9 if we have standard PCI ports") from the x86 tree and commit
87238e8d2a086678c246825bc1a9dd148bba77cb ("x86: disable VMX on all CPUs
on reboot") from the kvm tree.
Just a context change. I fixed it up (see below) and can carry the fix
as needed.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
diff --cc arch/x86/kernel/reboot.c
index 0acde8f,a8b9304..0000000
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@@ -39,10 -40,13 +40,16 @@@ int reboot_force
static int reboot_cpu = -1;
#endif
+ /* This is set if we need to go through the 'emergency' path.
+ * When machine_emergency_restart() is called, we may be on
+ * an inconsistent state and won't be able to do a clean cleanup
+ */
+ static int reboot_emergency;
+
-/* reboot=b[ios] | s[mp] | t[riple] | k[bd] | e[fi] [, [w]arm | [c]old]
+/* This is set by the PCI code if either type 1 or type 2 PCI is detected */
+bool port_cf9_safe = false;
+
+/* reboot=b[ios] | s[mp] | t[riple] | k[bd] | e[fi] [, [w]arm | [c]old] | p[ci]
warm Don't set the cold reboot flag
cold Set the cold reboot flag
bios Reboot by jumping through the BIOS (only for X86_32)
^ permalink raw reply
* linux-next: rr tree build failure
From: Stephen Rothwell @ 2008-11-25 6:45 UTC (permalink / raw)
To: Rusty Russell; +Cc: linux-next, Mike Travis
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hi Rusty,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
arch/powerpc/sysdev/mpic.c:809: error: conflicting types for 'mpic_set_affinity'
arch/powerpc/sysdev/mpic.h:39: error: previous declaration of 'mpic_set_affinity' was here
The declaration in the header file was missed.
Also, the x86_64 allmodconfig build failed like this:
ERROR: "hvc_resize" [drivers/char/virtio_console.ko] undefined!
hvc_resize is currently not exported to modules.
I have dropped the rr tree again.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: linux-next: Tree for November 14 (staging)
From: Greg KH @ 2008-11-25 5:50 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML
In-Reply-To: <491DC1CC.8020502@oracle.com>
On Fri, Nov 14, 2008 at 10:22:04AM -0800, Randy Dunlap wrote:
> Greg KH wrote:
> > On Fri, Nov 14, 2008 at 09:52:47AM -0800, Randy Dunlap wrote:
> >> On Fri, 14 Nov 2008 18:40:21 +1100 Stephen Rothwell wrote:
> >>
> >>> Hi all,
> >>>
> >>> Changes since 20081113:
> >>>
> >>> New tree:
> >>> staging
> >>
> >> drivers/staging/benet/mpu.c:146: error: implicit declaration of function 'udelay'
Thanks, got this one now.
greg k-h
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Steven Rostedt @ 2008-11-25 5:44 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
In-Reply-To: <20081125160935.2bd3dcb2.sfr@canb.auug.org.au>
On Tue, 2008-11-25 at 16:09 +1100, Stephen Rothwell wrote:
> Hi Steve,
>
> On Mon, 24 Nov 2008 23:31:33 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
> >
> > This may be a compiler bug, or something introduced by the compiler. I
> > compiled it fine first with gcc 4.0.2, but then tried with the same
> > compiler you used, and got the same error as you.
>
> A quick bisect points to this commit:
>
> commit 2bcd521a684cc94befbe2ce7d5b613c841b0d304
> Author: Steven Rostedt <srostedt@redhat.com>
> Date: Fri Nov 21 01:30:54 2008 -0500
>
> trace: profile all if conditionals
>
> I guess something in there is tickling the compiler ...
Yep, it was the wrong constraint used in the asm. Googling around, I
found a similar bug listed in gcc, which was not a bug.
Patch has been sent to fix this.
Ah, I forgot to Cc Peter on that patch.
I'll bounce it to him ;-)
-- Steve
^ permalink raw reply
* [PATCH] use limited register constraint for setnz
From: Steven Rostedt @ 2008-11-25 5:42 UTC (permalink / raw)
To: LKML
Cc: Ingo Molnar, Thomas Gleixner, Andrew Morton, Linus Torvalds,
Stephen Rothwell, linux-next
Impact: fix in compiling
GCC can decide to use %dil when "r" is used, which is not valid for
setnz.
This bug was brought out by Stephen Rothwell's merging of the
branch tracer into linux-next.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
index 0be77b3..c2121d2 100644
--- a/arch/x86/boot/tty.c
+++ b/arch/x86/boot/tty.c
@@ -74,7 +74,7 @@ static int kbd_pending(void)
{
u8 pending;
asm volatile("int $0x16; setnz %0"
- : "=rm" (pending)
+ : "=Qm" (pending)
: "a" (0x0100));
return pending;
}
^ permalink raw reply related
* linux-next: ocfs2 tree build failure
From: Stephen Rothwell @ 2008-11-25 5:42 UTC (permalink / raw)
To: Mark Fasheh; +Cc: linux-next, Jan Kara
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
Hi Mark,
Today's linux-next build (x86_64 allmodconfig) failed like this:
usr/include/linux/dqblk_v2.h:8: included file 'linux/dqblk_qtree.h' is not exported
make[4]: *** [/scratch/sfr/x86_64_allmodconfig/usr/include/linux/.check] Error 1
Caused by commit 603f68d0c2b66052093ea29bf1ff7a8a58667af6 ("quota: Split
off quota tree handling into a separate file"). dqblk_qtree.h needs to
be added to the Kbuild file.
I have added that just for today. I expect this to be fixed tomorrow.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Steven Rostedt @ 2008-11-25 5:24 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
In-Reply-To: <20081125151345.3f0ed493.sfr@canb.auug.org.au>
On Tue, 2008-11-25 at 15:13 +1100, Stephen Rothwell wrote:
> Hi Steve,
>
> On Mon, 24 Nov 2008 22:48:51 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
> >
> > Could you post a git branch that had this failure, so I can compile it
> > to see what happened?
>
> ssh://master.kernel.org/~sfr/ftrace master
>
> to get the failure, I did:
>
> make ARCH=x86_64 allmodconfig
> make ARCH=x86_64 arch/x86/boot/tty.o
>
> My machine is Debian sid.
>
> $ gcc --version
> gcc (Debian 4.3.2-1) 4.3.2
> $ ld --version
> GNU ld (GNU Binutils for Debian) 2.18.0.20080103
>
> The original failure was with a gcc 4.3.2 cross compiled for a powerpc
> host and a binutils 2.19.
>
> You can see which trees are merged by looking for commits by me.
I traced it down to this.
It compiles without -Os.
But I leave -Os in...
Doing a make arch/x86/boot/tty.i I get this:
static int kbd_pending(void)
{
u8 pending;
asm volatile("int $0x16; setnz %0"
: "=rm" (pending)
: "a" (0x0100));
return pending;
}
void kbd_flush(void)
{
for (;;) {
if (__builtin_constant_p((!kbd_pending())) ? !!(!kbd_pending()) :
({ int ______r; static struct ftrace_branch_data
__attribute__((__aligned__(4)))
__attribute__((section("_ftrace_branch"))) ______f = { .func =
__func__, .file = "arch/x86/boot/tty.c", .line = 85, }; ______r = !!(!
kbd_pending()); if (______r) ______f.hit++; else ______f.miss++;
______r; }))
break;
getchar();
}
}
By removing the "static" and "__attribute__((section...))" which is
needed to remove static. It compiles.
It also compiles if I only remove the "if (______r) ______f.hit++; else
______f.miss++;
There's something buggy with gcc where it can not handle -Os and this
combination of having this static variable in the if statement.
-- Steve
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Stephen Rothwell @ 2008-11-25 5:09 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
In-Reply-To: <1227587493.7622.14.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
Hi Steve,
On Mon, 24 Nov 2008 23:31:33 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
>
> This may be a compiler bug, or something introduced by the compiler. I
> compiled it fine first with gcc 4.0.2, but then tried with the same
> compiler you used, and got the same error as you.
A quick bisect points to this commit:
commit 2bcd521a684cc94befbe2ce7d5b613c841b0d304
Author: Steven Rostedt <srostedt@redhat.com>
Date: Fri Nov 21 01:30:54 2008 -0500
trace: profile all if conditionals
I guess something in there is tickling the compiler ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* linux-next: kbuild tree build failure
From: Stephen Rothwell @ 2008-11-25 4:47 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
Hi Sam,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
WARNING: modpost: Found 11 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
.tmp_kallsyms1.S:1:23: error: asm/types.h: No such file or directory
I have dropped the kbuild tree for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* linux-next: v4l-dvb tree build failure
From: Stephen Rothwell @ 2008-11-25 4:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-next, Devin Heitmueller
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
Hi Mauro,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/media/video/em28xx/em28xx-core.c: In function 'em28xx_set_audio_source':
drivers/media/video/em28xx/em28xx-core.c:372: error: 'video' undeclared (first use in this function)
drivers/media/video/em28xx/em28xx-core.c:372: error: 'disable' undeclared (first use in this function)
drivers/media/video/em28xx/em28xx-core.c:373: error: 'line' undeclared (first use in this function)
drivers/media/video/em28xx/em28xx-core.c:373: error: 'enable' undeclared (first use in this function)
Caused by a bad merge of commits
3f9b46c154da5ec4facca88f82d1820eb329fd3e ("V4L/DVB (9632): make em28xx
aux audio input work") and 2173b4ae6f8262d15fc933a13191cd6d5e789e8d
("V4L/DVB (9651): em28xx: Improve audio handling").
I have dropped the v4l-dvb tree for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Steven Rostedt @ 2008-11-25 4:31 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
In-Reply-To: <20081125151345.3f0ed493.sfr@canb.auug.org.au>
On Tue, 2008-11-25 at 15:13 +1100, Stephen Rothwell wrote:
> Hi Steve,
>
> On Mon, 24 Nov 2008 22:48:51 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
> >
> > Could you post a git branch that had this failure, so I can compile it
> > to see what happened?
>
> ssh://master.kernel.org/~sfr/ftrace master
>
> to get the failure, I did:
>
> make ARCH=x86_64 allmodconfig
> make ARCH=x86_64 arch/x86/boot/tty.o
>
> My machine is Debian sid.
>
> $ gcc --version
> gcc (Debian 4.3.2-1) 4.3.2
> $ ld --version
> GNU ld (GNU Binutils for Debian) 2.18.0.20080103
>
> The original failure was with a gcc 4.3.2 cross compiled for a powerpc
> host and a binutils 2.19.
>
> You can see which trees are merged by looking for commits by me.
This may be a compiler bug, or something introduced by the compiler. I
compiled it fine first with gcc 4.0.2, but then tried with the same
compiler you used, and got the same error as you.
I'll look more at it.
Thanks,
-- Steve
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Stephen Rothwell @ 2008-11-25 4:13 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
In-Reply-To: <1227584931.7622.11.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Hi Steve,
On Mon, 24 Nov 2008 22:48:51 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
>
> Could you post a git branch that had this failure, so I can compile it
> to see what happened?
ssh://master.kernel.org/~sfr/ftrace master
to get the failure, I did:
make ARCH=x86_64 allmodconfig
make ARCH=x86_64 arch/x86/boot/tty.o
My machine is Debian sid.
$ gcc --version
gcc (Debian 4.3.2-1) 4.3.2
$ ld --version
GNU ld (GNU Binutils for Debian) 2.18.0.20080103
The original failure was with a gcc 4.3.2 cross compiled for a powerpc
host and a binutils 2.19.
You can see which trees are merged by looking for commits by me.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Steven Rostedt @ 2008-11-25 3:48 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
In-Reply-To: <20081125142105.2b6d464a.sfr@canb.auug.org.au>
On Tue, 2008-11-25 at 14:21 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> arch/x86/boot/tty.c: Assembler messages:
> arch/x86/boot/tty.c:76: Error: bad register name `%dil'
>
> I have no idea what caused this (maybe a compiler option?) so I have
> dropped the ftrace tree for today.
>
Stephen,
Could you post a git branch that had this failure, so I can compile it
to see what happened?
Thanks,
-- Steve
^ permalink raw reply
* Re: linux-next: ftrace tree build failure
From: Steven Rostedt @ 2008-11-25 3:21 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next,
Luis R. Rodriguez, John W. Linville, David S. Miller
In-Reply-To: <20081125140719.03a8cdfb.sfr@canb.auug.org.au>
On Tue, 2008-11-25 at 14:07 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> net/wireless/reg.c:348:29: error: macro "if" passed 2 arguments, but takes just 1
> net/wireless/reg.c: In function 'ignore_request':
> net/wireless/reg.c:349: error: expected '(' before 'return'
>
> This is clearly a bug in in the above file and should be fixed there, so
> I have applied the following patch for today. I expect some patch to fix
> this to appear in the wireless-current or net-current tree very soon.
>
Ingo already has this in his queue too.
http://marc.info/?l=linux-kernel&m=122745649425646&w=2
-- Steve
^ permalink raw reply
* linux-next: ftrace tree build failure
From: Stephen Rothwell @ 2008-11-25 3:21 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin; +Cc: linux-next, Steven Rostedt
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
Hi all,
Today's linux-next build (x86_64 allmodconfig) failed like this:
arch/x86/boot/tty.c: Assembler messages:
arch/x86/boot/tty.c:76: Error: bad register name `%dil'
I have no idea what caused this (maybe a compiler option?) so I have
dropped the ftrace tree for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* linux-next: ftrace tree build failure
From: Stephen Rothwell @ 2008-11-25 3:07 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin
Cc: linux-next, Steven Rostedt, Luis R. Rodriguez, John W. Linville,
David S. Miller
Hi all,
Today's linux-next build (x86_64 allmodconfig) failed like this:
net/wireless/reg.c:348:29: error: macro "if" passed 2 arguments, but takes just 1
net/wireless/reg.c: In function 'ignore_request':
net/wireless/reg.c:349: error: expected '(' before 'return'
This is clearly a bug in in the above file and should be fixed there, so
I have applied the following patch for today. I expect some patch to fix
this to appear in the wireless-current or net-current tree very soon.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 626dbb6..648c765 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -343,9 +343,7 @@ static int ignore_request(struct wiphy *wiphy, enum reg_set_by set_by,
return 0;
return -EALREADY;
}
- if (WARN_ON(!is_alpha2_set(alpha2) || !is_an_alpha2(alpha2)),
- "Invalid Country IE regulatory hint passed "
- "to the wireless core\n")
+ if (WARN_ON(!is_alpha2_set(alpha2) || !is_an_alpha2(alpha2)))
return -EINVAL;
/* We ignore Country IE hints for now, as we haven't yet
* added the dot11MultiDomainCapabilityEnabled flag
^ permalink raw reply related
* Re: linux-next: ftrace tree build warnings
From: Steven Rostedt @ 2008-11-25 2:44 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next,
Alan Cox
In-Reply-To: <20081125133828.8f9b49df.sfr@canb.auug.org.au>
On Tue, 2008-11-25 at 13:38 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (x86_64 allmodconfig) produced lots of these
> warnings:
>
> include/linux/tty.h:330: warning: '______f' is static but declared in inline function 'tty_kref_get' which is not static
>
> Caused by commit 2bcd521a684cc94befbe2ce7d5b613c841b0d304 ("trace:
> profile all if conditionals"). Something needs to be done about
> this ... maybe tty_kref_get needs to be "static inline" instead of
> "extern inline"?
>
Is there a way to suppress this warning here? Since we are only
profiling, if it complies fine, then it should not be an issue.
Looking at the uses of this function, is there any reason that it is not
"static inline"?
-- Steve
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox