* Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors
From: Roland Dreier @ 2011-10-10 19:02 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Mike Marciniszyn, linux-rdma,
Andrew Morton
In-Reply-To: <4E8F77B8.3000805@xenotime.net>
On Fri, Oct 7, 2011 at 3:05 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> First I saw it was in today's linux-next (20111007).
Got it... a latent problem exposed by some include clean up, probably.
Applied, thanks.
^ permalink raw reply
* Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors
From: Randy Dunlap @ 2011-10-10 19:02 UTC (permalink / raw)
To: Mike Marciniszyn
Cc: Roland Dreier, Stephen Rothwell, linux-next@vger.kernel.org,
linux-kernel, Dept_Infinipath, linux-rdma@vger.kernel.org,
Andrew Morton
In-Reply-To: <35AAF1E4A771E142979F27B51793A48888433C0838@AVEXMB1.qlogic.org>
On 10/10/11 11:57, Mike Marciniszyn wrote:
> As do I.
>
> I've confirmed that patch does no harm, but I would like to see the error.
>
> Which of the github repos exposes the error?
I saw it in linux-next of 20111007.
> Mike
>
>> -----Original Message-----
>> From: Roland Dreier [mailto:roland@purestorage.com]
>> Sent: Friday, October 07, 2011 5:21 PM
>> To: Randy Dunlap
>> Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel;
>> Dept_Infinipath; linux-rdma@vger.kernel.org; Andrew Morton
>> Subject: Re: [PATCH -next] infiniband: fix ipath_chip_init.c build
>> errors
>>
>> On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap@xenotime.net>
>> wrote:
>>> Add <linux/stat.h> to fix build errors:
>>
>> When did this break? I build ipath in my test config all the time...
>>
>> - R.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply
* RE: [PATCH -next] infiniband: fix ipath_chip_init.c build errors
From: Mike Marciniszyn @ 2011-10-10 18:57 UTC (permalink / raw)
To: Roland Dreier, Randy Dunlap
Cc: Stephen Rothwell, linux-next@vger.kernel.org, linux-kernel,
Dept_Infinipath, linux-rdma@vger.kernel.org, Andrew Morton
In-Reply-To: <CAL1RGDXoiRfR1Ku67tRgbhxzyWQmDrjKCztnVd6wbwi0Uud90Q@mail.gmail.com>
As do I.
I've confirmed that patch does no harm, but I would like to see the error.
Which of the github repos exposes the error?
Mike
> -----Original Message-----
> From: Roland Dreier [mailto:roland@purestorage.com]
> Sent: Friday, October 07, 2011 5:21 PM
> To: Randy Dunlap
> Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel;
> Dept_Infinipath; linux-rdma@vger.kernel.org; Andrew Morton
> Subject: Re: [PATCH -next] infiniband: fix ipath_chip_init.c build
> errors
>
> On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap@xenotime.net>
> wrote:
> > Add <linux/stat.h> to fix build errors:
>
> When did this break? I build ipath in my test config all the time...
>
> - R.
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply
* [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Randy Dunlap @ 2011-10-10 17:40 UTC (permalink / raw)
To: Greg KH
Cc: Felipe Balbi, Stephen Rothwell, linux-next, LKML, linux-usb,
Andrew Morton, Michal Nazarewicz
In-Reply-To: <20111010171645.GA24628@kroah.com>
From: Randy Dunlap <rdunlap@xenotime.net>
Move function to fix langwell_udc.c build error:
drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
drivers/usb/gadget/langwell_udc.c: At top level:
drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Felipe Balbi <balbi@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: linux-usb@vger.kernel.org
---
drivers/usb/gadget/langwell_udc.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
--- next-2011-1007.orig/drivers/usb/gadget/langwell_udc.c
+++ next-2011-1007/drivers/usb/gadget/langwell_udc.c
@@ -1562,6 +1562,20 @@ static ssize_t show_function(struct devi
static DEVICE_ATTR(function, S_IRUGO, show_function, NULL);
+static inline enum usb_device_speed lpm_device_speed(u32 reg)
+{
+ switch (LPM_PSPD(reg)) {
+ case LPM_SPEED_HIGH:
+ return USB_SPEED_HIGH;
+ case LPM_SPEED_FULL:
+ return USB_SPEED_FULL;
+ case LPM_SPEED_LOW:
+ return USB_SPEED_LOW;
+ default:
+ return USB_SPEED_UNKNOWN;
+ }
+}
+
/* device "langwell_udc" sysfs attribute file */
static ssize_t show_langwell_udc(struct device *_dev,
struct device_attribute *attr, char *buf)
@@ -2634,20 +2648,6 @@ done:
dev_vdbg(&dev->pdev->dev, "<--- %s()\n", __func__);
}
-static inline enum usb_device_speed lpm_device_speed(u32 reg)
-{
- switch (LPM_PSPD(reg)) {
- case LPM_SPEED_HIGH:
- return USB_SPEED_HIGH;
- case LPM_SPEED_FULL:
- return USB_SPEED_FULL;
- case LPM_SPEED_LOW:
- return USB_SPEED_LOW;
- default:
- return USB_SPEED_UNKNOWN;
- }
-}
-
/* port change detect interrupt handler */
static void handle_port_change(struct langwell_udc *dev)
{
^ permalink raw reply
* Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Greg KH @ 2011-10-10 17:16 UTC (permalink / raw)
To: Felipe Balbi
Cc: Randy Dunlap, Stephen Rothwell, linux-next, LKML, linux-usb,
Andrew Morton, Michal Nazarewicz
In-Reply-To: <20111010050959.GA30935@legolas.emea.dhcp.ti.com>
On Mon, Oct 10, 2011 at 08:10:01AM +0300, Felipe Balbi wrote:
> Hi,
>
> On Sun, Oct 09, 2011 at 04:05:46PM -0700, Randy Dunlap wrote:
> > On 10/09/11 15:36, Felipe Balbi wrote:
> > > git log --pretty=oneline -S'lpm_device_speed' HEAD -- \
> > > drivers/usb/gadget/langwell_udc.c
> >
> > e538dfdae85244fd2c4231725d82cc1f1bc4942c usb: Provide usb_speed_string() function
>
> Aha, now I know why, that went straight througth Greg.
>
> Greg, can you pick this patch ? It's clearly needed. Meanwhile, I'll
> cherry-pick that commit from your tree and apply Randy's fix too.
>
> Here's my ack for $SUBJECT:
>
> Acked-by: Felipe Balbi <balbi@ti.com>
Um, pick what patch?
Randy, care to resend it to me with Felipe's ack?
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Felipe Balbi @ 2011-10-10 5:10 UTC (permalink / raw)
To: Randy Dunlap
Cc: balbi-l0cyMroinI0, Stephen Rothwell,
linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Andrew Morton,
Michal Nazarewicz
In-Reply-To: <4E9228CA.1060904-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
Hi,
On Sun, Oct 09, 2011 at 04:05:46PM -0700, Randy Dunlap wrote:
> On 10/09/11 15:36, Felipe Balbi wrote:
> > git log --pretty=oneline -S'lpm_device_speed' HEAD -- \
> > drivers/usb/gadget/langwell_udc.c
>
> e538dfdae85244fd2c4231725d82cc1f1bc4942c usb: Provide usb_speed_string() function
Aha, now I know why, that went straight througth Greg.
Greg, can you pick this patch ? It's clearly needed. Meanwhile, I'll
cherry-pick that commit from your tree and apply Randy's fix too.
Here's my ack for $SUBJECT:
Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Stephen Rothwell @ 2011-10-09 23:33 UTC (permalink / raw)
To: balbi; +Cc: Randy Dunlap, linux-next, LKML, linux-usb, Andrew Morton
In-Reply-To: <20111008100326.GA24633@legolas.emea.dhcp.ti.com>
[-- Attachment #1: Type: text/plain, Size: 2056 bytes --]
Hi,
On Sat, 8 Oct 2011 13:03:28 +0300 Felipe Balbi <balbi@ti.com> wrote:
>
> On Fri, Oct 07, 2011 at 01:57:42PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > Move function to fix langwell_udc.c build error:
> >
> > drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
> > drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
> > drivers/usb/gadget/langwell_udc.c: At top level:
> > drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
> > drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
>
> I don't have this compile error on my branch, did something go in
> without me noticing ?
>
> Can you blame a comit which introduced this ?
>
> btw, all I have is a warning.
The code in that file is structured like this (in linux-next and the usb
tree):
static ssize_t show_langwell_udc(struct device *_dev,
struct device_attribute *attr, char *buf)
{
...
t = scnprintf(next, size,
"Device LPM Control Reg:\n"
"Parallel Transceiver : %d\n"
"Serial Transceiver : %d\n"
"Port Speed: %s\n"
"Port Force Full Speed Connenct: %s\n"
"PHY Low Power Suspend Clock: %s\n"
"BmAttributes: %d\n\n",
LPM_PTS(tmp_reg),
(tmp_reg & LPM_STS) ? 1 : 0,
usb_speed_string(lpm_device_speed(tmp_reg)),
(tmp_reg & LPM_PFSC) ? "Force Full Speed" : "Not Force",
(tmp_reg & LPM_PHCD) ? "Disabled" : "Enabled",
LPM_BA(tmp_reg));
...
}
...
static inline enum usb_device_speed lpm_device_speed(u32 reg)
{
...
}
So this function is clearly used before it is declared. What does yours
look like?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* linux-next: no tree for today
From: Stephen Rothwell @ 2011-10-09 23:17 UTC (permalink / raw)
To: linux-next; +Cc: LKML
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
Hi all,
There will be no linux-next tree today due to a public holiday here.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Randy Dunlap @ 2011-10-09 23:05 UTC (permalink / raw)
To: balbi
Cc: Stephen Rothwell, linux-next, LKML, linux-usb, Andrew Morton,
Michal Nazarewicz
In-Reply-To: <20111009223638.GA29776@legolas.emea.dhcp.ti.com>
On 10/09/11 15:36, Felipe Balbi wrote:
> git log --pretty=oneline -S'lpm_device_speed' HEAD -- \
> drivers/usb/gadget/langwell_udc.c
e538dfdae85244fd2c4231725d82cc1f1bc4942c usb: Provide usb_speed_string() function
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply
* Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Felipe Balbi @ 2011-10-09 22:36 UTC (permalink / raw)
To: Randy Dunlap
Cc: balbi, Stephen Rothwell, linux-next, LKML, linux-usb,
Andrew Morton
In-Reply-To: <4E91DF00.8060107@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]
Hi,
On Sun, Oct 09, 2011 at 10:50:56AM -0700, Randy Dunlap wrote:
> On 10/08/11 03:03, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Oct 07, 2011 at 01:57:42PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@xenotime.net>
> >>
> >> Move function to fix langwell_udc.c build error:
> >>
> >> drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
> >> drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c: At top level:
> >> drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
> >
> > I don't have this compile error on my branch, did something go in
> > without me noticing ?
>
> probably not. What version of gcc are you using?
I believe it did, I don't have lpm_device_speed() at all.
> I'm using 4.5.1.
4.6.1
> > Can you blame a comit which introduced this ?
>
> I don't see such a commit.
$ git log --pretty=oneline -S'lpm_device_speed' HEAD -- \
drivers/usb/gadget/langwell_udc.c
what's the output ?
> > btw, all I have is a warning.
>
> What warning?
drivers/usb/gadget/langwell_udc.c: In function ‘langwell_ep_dequeue’:
drivers/usb/gadget/langwell_udc.c:919:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* (unknown),
From: MONEY GRAM CUSTOMER CARE @ 2011-10-09 20:56 UTC (permalink / raw)
MONEY GRAM SERVICE
My associate Mr Mark Jefferson has helped me to send your first payment of
$7,500 USD to you as instructed by the United Kingdom Government and Mr.
David Cameron the United Kingdom prime minister after the last G20
meeting, making you one of the beneficiaries through an email natural
simple ballot selection.
He told Allan Davis to keep sending you $7,500 USD via Money Gram twice a
week until the FULL payment of ($820,000.00 ) is completed.
MONEY TRANSFER REFERENCE:2116-3297
SENDER'S NAME: Mark Jefferson
AMOUNT: US $7,500
To track your funds forward money gram
Transfer agent Mr Allan Davis
Your Name.____________
Phone .______________
Country_______________
Contact Allan Davis for the funds clearance
certificate (FCC) necessary for the release of your funds
E-mail m_gram22@ozledim.net
D/L: + {44}70-45-78-97-78
You cannot pickup the money until the certificate is obtained by you.
Note: that if you are not the owner of this appropriate e-mail address
then kindly ignore this message.
Regards
Mr. Forlan Desmond.
^ permalink raw reply
* Re: linux-next: build failure after merge of the moduleh tree
From: Chris Ball @ 2011-10-09 18:01 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-next, linux-kernel, Per Forlin, Stephen Rothwell,
Akinobu Mita
In-Reply-To: <20111009050809.GS19986@windriver.com>
Hi Paul,
On Sun, Oct 09 2011, Paul Gortmaker wrote:
> I was wondering if you were going to apply this to the mmc tree. Since
> the module_param addition isn't in the module.h baseline, I'd be
> speculatively fixing an issue that hasn't been created yet, which isn't
> the end of the world, but it doesn't feel quite right to do that either.
Thanks, I've pushed both this patch and "Add module.h to drivers/mmc
users assuming implicit presence" to the mmc-next tree now.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply
* Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Randy Dunlap @ 2011-10-09 17:50 UTC (permalink / raw)
To: balbi; +Cc: Stephen Rothwell, linux-next, LKML, linux-usb, Andrew Morton
In-Reply-To: <20111008100326.GA24633@legolas.emea.dhcp.ti.com>
On 10/08/11 03:03, Felipe Balbi wrote:
> Hi,
>
> On Fri, Oct 07, 2011 at 01:57:42PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> Move function to fix langwell_udc.c build error:
>>
>> drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
>> drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
>> drivers/usb/gadget/langwell_udc.c: At top level:
>> drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
>> drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
>
> I don't have this compile error on my branch, did something go in
> without me noticing ?
probably not. What version of gcc are you using?
I'm using 4.5.1.
> Can you blame a comit which introduced this ?
I don't see such a commit.
> btw, all I have is a warning.
What warning?
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply
* Re: linux-next: build failure after merge of the moduleh tree
From: Paul Gortmaker @ 2011-10-09 5:08 UTC (permalink / raw)
To: Chris Ball
Cc: linux-next, linux-kernel, Per Forlin, Stephen Rothwell,
Akinobu Mita
In-Reply-To: <20110928181815.45f540034ddde2b206fc4e57@canb.auug.org.au>
[linux-next: build failure after merge of the moduleh tree] On 28/09/2011 (Wed 18:18) Stephen Rothwell wrote:
> Hi Paul,
>
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant
>
> Caused by commit b5a62f8be3af ("mmc: add module param to set fault
> injection attributes") from the mmc tree interacting with the module.h
> split up.
>
> I have applied the patch below for today (something similar could be
> applied to the mmc tree).
Hi Chris,
I was wondering if you were going to apply this to the mmc tree. Since
the module_param addition isn't in the module.h baseline, I'd be
speculatively fixing an issue that hasn't been created yet, which isn't
the end of the world, but it doesn't feel quite right to do that either.
If it is in the mmc tree, then the include fix will be guaranteed to be
present wherever the module_param usage is present.
Thanks,
Paul.
>From 00812c67db3d0ade3571684191781d866293f1ba Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 28 Sep 2011 18:09:12 +1000
Subject: [PATCH] mmc: using module_param requires the inclusion of
moduleparam.h
Commit "mmc: add module param to set fault injection attributes" adds
a module_param to this file. But it is relying on the old implicit
"module.h is everywhere" behaviour, and without the explicit include
of moduleparam.h, the pending module.h split up produces this error:
drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index 0a1e7cf..65138e0 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -7,6 +7,7 @@
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*/
+#include <linux/moduleparam.h>
#include <linux/debugfs.h>
#include <linux/fs.h>
#include <linux/export.h>
--
1.7.6
^ permalink raw reply related
* Re: [PATCH] drivers/media: fix dependencies in video mt9t001/mt9p031
From: Paul Gortmaker @ 2011-10-09 3:39 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Stephen Rothwell, Randy Dunlap, linux-next, linux-media
In-Reply-To: <4E902B89.7030004@redhat.com>
On Sat, Oct 8, 2011 at 6:52 AM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Em 06-10-2011 00:02, Stephen Rothwell escreveu:
>>
>> Hi Mauro,
>>
>> On Fri, 30 Sep 2011 15:38:13 -0700 Randy Dunlap<rdunlap@xenotime.net>
>> wrote:
>>>
>>> On 09/30/11 14:34, Paul Gortmaker wrote:
>>>>
>>>> Both mt9t001.c and mt9p031.c have two identical issues, those
>>>> being that they will need module.h inclusion for the upcoming
>>>> cleanup going on there, and that their dependencies don't limit
>>>> selection of configs that will fail to compile as follows:
>>>>
>>>> drivers/media/video/mt9p031.c:457: error: implicit declaration of
>>>> function ‘v4l2_subdev_get_try_crop’
>>>> drivers/media/video/mt9t001.c:787: error: ‘struct v4l2_subdev’ has no
>>>> member named ‘entity’
>>>>
>>>> The related config options are CONFIG_MEDIA_CONTROLLER and
>>>> CONFIG_VIDEO_V4L2_SUBDEV_API. Looking at the code, it appears
>>>> that the driver was never intended to work without these enabled,
>>>> so add a dependency on CONFIG_VIDEO_V4L2_SUBDEV_API, which in
>>>> turn already has a dependency on CONFIG_MEDIA_CONTROLLER.
>>>>
>>>> Reported-by: Randy Dunlap<rdunlap@xenotime.net>
>>>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>>>
>>> Acked-by: Randy Dunlap<rdunlap@xenotime.net>
>>
>> Ping?
>>
> Sorry, I was assuming that this patch would be going together with the
> other module.h trees. I'll apply it on my tree.
Thanks. Since the files in question don't exist on mainline, there is no real
way I can have it directly on the module.h tree. If your file(s) needed the
export.h file, (which my tree creates) then I'd have carried it as a post-merge
delta to get past the chicken-and-egg problem of who's new file comes 1st.
But since your file really just needs module.h -- you can add it to your tree
right away. Plus the Kconfig change I made really should be SOB by the
folks who know the driver restrictions; I just made an educated guess.
Paul.
>
> Thanks,
> Mauro
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: [PATCH] drivers/media: fix dependencies in video mt9t001/mt9p031
From: Mauro Carvalho Chehab @ 2011-10-08 10:52 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Randy Dunlap, Paul Gortmaker, linux-next, linux-media
In-Reply-To: <20111006140214.b64b22b77f2f831442d59794@canb.auug.org.au>
Em 06-10-2011 00:02, Stephen Rothwell escreveu:
> Hi Mauro,
>
> On Fri, 30 Sep 2011 15:38:13 -0700 Randy Dunlap<rdunlap@xenotime.net> wrote:
>>
>> On 09/30/11 14:34, Paul Gortmaker wrote:
>>> Both mt9t001.c and mt9p031.c have two identical issues, those
>>> being that they will need module.h inclusion for the upcoming
>>> cleanup going on there, and that their dependencies don't limit
>>> selection of configs that will fail to compile as follows:
>>>
>>> drivers/media/video/mt9p031.c:457: error: implicit declaration of function ‘v4l2_subdev_get_try_crop’
>>> drivers/media/video/mt9t001.c:787: error: ‘struct v4l2_subdev’ has no member named ‘entity’
>>>
>>> The related config options are CONFIG_MEDIA_CONTROLLER and
>>> CONFIG_VIDEO_V4L2_SUBDEV_API. Looking at the code, it appears
>>> that the driver was never intended to work without these enabled,
>>> so add a dependency on CONFIG_VIDEO_V4L2_SUBDEV_API, which in
>>> turn already has a dependency on CONFIG_MEDIA_CONTROLLER.
>>>
>>> Reported-by: Randy Dunlap<rdunlap@xenotime.net>
>>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>>
>> Acked-by: Randy Dunlap<rdunlap@xenotime.net>
>
> Ping?
>
Sorry, I was assuming that this patch would be going together with the
other module.h trees. I'll apply it on my tree.
Thanks,
Mauro
^ permalink raw reply
* Re: linux-pm tree back at kernel.org (Re: linux-next: temporary github repository)
From: Rafael J. Wysocki @ 2011-10-08 10:12 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: LKML, linux-next, Linus, Andrew Morton
In-Reply-To: <20111008102054.d542c3cccfc714b12b61e37b@canb.auug.org.au>
On Saturday, October 08, 2011, Stephen Rothwell wrote:
> Hi Rafael,
>
> On Fri, 7 Oct 2011 23:01:20 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> >
> > The linux-pm tree is back at kernel.org, so please use:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> >
> > from now on. I'm still planning to keep the tree at github up to date, though.
>
> OK, I will use the kernel.org tree from now on (linux-next branch, right?).
Yes, the linux-next branch.
Thanks,
Rafael
^ permalink raw reply
* Re: [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Felipe Balbi @ 2011-10-08 10:03 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Felipe Balbi, linux-usb,
Andrew Morton
In-Reply-To: <4E8F67C6.5020603@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
Hi,
On Fri, Oct 07, 2011 at 01:57:42PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Move function to fix langwell_udc.c build error:
>
> drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
> drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
> drivers/usb/gadget/langwell_udc.c: At top level:
> drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
> drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
I don't have this compile error on my branch, did something go in
without me noticing ?
Can you blame a comit which introduced this ?
btw, all I have is a warning.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors
From: Stephen Rothwell @ 2011-10-07 23:28 UTC (permalink / raw)
To: Roland Dreier
Cc: Randy Dunlap, linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
Mike Marciniszyn, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Andrew Morton
In-Reply-To: <4E8F77B8.3000805-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
Hi all,
On Fri, 07 Oct 2011 15:05:44 -0700 Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
>
> On 10/07/11 14:21, Roland Dreier wrote:
> > On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
> >> Add <linux/stat.h> to fix build errors:
> >
> > When did this break? I build ipath in my test config all the time...
>
> First I saw it was in today's linux-next (20111007).
Its probably associated with the module.h split up. But see Rule 1 in
Documentation/SubmitChecklist. Implicit inclusion of files can easily
break when built for a different architecture or config ...
--
Cheers,
Stephen Rothwell sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: linux-pm tree back at kernel.org (Re: linux-next: temporary github repository)
From: Stephen Rothwell @ 2011-10-07 23:20 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: LKML, linux-next, Linus, Andrew Morton
In-Reply-To: <201110072301.21087.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Hi Rafael,
On Fri, 7 Oct 2011 23:01:20 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> The linux-pm tree is back at kernel.org, so please use:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
>
> from now on. I'm still planning to keep the tree at github up to date, though.
OK, I will use the kernel.org tree from now on (linux-next branch, right?).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors
From: Randy Dunlap @ 2011-10-07 22:05 UTC (permalink / raw)
To: Roland Dreier
Cc: Stephen Rothwell, linux-next, LKML, Mike Marciniszyn, linux-rdma,
Andrew Morton
In-Reply-To: <CAL1RGDXoiRfR1Ku67tRgbhxzyWQmDrjKCztnVd6wbwi0Uud90Q@mail.gmail.com>
On 10/07/11 14:21, Roland Dreier wrote:
> On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> Add <linux/stat.h> to fix build errors:
>
> When did this break? I build ipath in my test config all the time...
First I saw it was in today's linux-next (20111007).
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply
* Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors
From: Roland Dreier @ 2011-10-07 21:21 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
Mike Marciniszyn, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Andrew Morton
In-Reply-To: <4E8F683D.9020604-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
On Fri, Oct 7, 2011 at 1:59 PM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
> Add <linux/stat.h> to fix build errors:
When did this break? I build ipath in my test config all the time...
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH -next] infiniband: fix ipath_chip_init.c build errors
From: Randy Dunlap @ 2011-10-07 20:59 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next-u79uwXL29TY76Z2rM5mHXA, LKML, Mike Marciniszyn,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Andrew Morton
In-Reply-To: <20111007174230.702f4a0bf1fe71dab5e10961-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Add <linux/stat.h> to fix build errors:
drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: 'S_IRUGO' undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:54:1: error: bit-field '<anonymous>' width not an integer constant
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: 'S_IWUSR' undeclared here (not in a function)
drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: bit-field '<anonymous>' width not an integer constant
Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Cc: Mike Marciniszyn <infinipath-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
drivers/infiniband/hw/ipath/ipath_init_chip.c | 1 +
1 file changed, 1 insertion(+)
--- next-2011-1007.orig/drivers/infiniband/hw/ipath/ipath_init_chip.c
+++ next-2011-1007/drivers/infiniband/hw/ipath/ipath_init_chip.c
@@ -35,6 +35,7 @@
#include <linux/netdevice.h>
#include <linux/moduleparam.h>
#include <linux/slab.h>
+#include <linux/stat.h>
#include <linux/vmalloc.h>
#include "ipath_kernel.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* linux-pm tree back at kernel.org (Re: linux-next: temporary github repository)
From: Rafael J. Wysocki @ 2011-10-07 21:01 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: LKML, linux-next, Linus, Andrew Morton
In-Reply-To: <201109181518.35788.rjw@sisk.pl>
Hi Stephen,
On Sunday, September 18, 2011, Rafael J. Wysocki wrote:
> Hi,
>
> On Sunday, September 18, 2011, Stephen Rothwell wrote:
> > Hi all,
> >
> > Since kernel.org has not returned yet, I have created a temporary
> > repository on github that will contain linux-next until the kernel.org
> > servers return. You can access it at
> > git://github.com/sfrothwell/linux-next.git
>
> OK, so the temporary location of the linux-pm tree's linux-next branch is at:
>
> git://github.com/rjwysocki/linux-pm.git linux-next
The linux-pm tree is back at kernel.org, so please use:
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
from now on. I'm still planning to keep the tree at github up to date, though.
Thanks,
Rafael
^ permalink raw reply
* [PATCH -next] usb gadget: fix langwell_udc.c build error
From: Randy Dunlap @ 2011-10-07 20:57 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next-u79uwXL29TY76Z2rM5mHXA, LKML, Felipe Balbi,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Andrew Morton
In-Reply-To: <20111007174230.702f4a0bf1fe71dab5e10961-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Move function to fix langwell_udc.c build error:
drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
drivers/usb/gadget/langwell_udc.c: At top level:
drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
drivers/usb/gadget/langwell_udc.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
--- next-2011-1007.orig/drivers/usb/gadget/langwell_udc.c
+++ next-2011-1007/drivers/usb/gadget/langwell_udc.c
@@ -1562,6 +1562,20 @@ static ssize_t show_function(struct devi
static DEVICE_ATTR(function, S_IRUGO, show_function, NULL);
+static inline enum usb_device_speed lpm_device_speed(u32 reg)
+{
+ switch (LPM_PSPD(reg)) {
+ case LPM_SPEED_HIGH:
+ return USB_SPEED_HIGH;
+ case LPM_SPEED_FULL:
+ return USB_SPEED_FULL;
+ case LPM_SPEED_LOW:
+ return USB_SPEED_LOW;
+ default:
+ return USB_SPEED_UNKNOWN;
+ }
+}
+
/* device "langwell_udc" sysfs attribute file */
static ssize_t show_langwell_udc(struct device *_dev,
struct device_attribute *attr, char *buf)
@@ -2634,20 +2648,6 @@ done:
dev_vdbg(&dev->pdev->dev, "<--- %s()\n", __func__);
}
-static inline enum usb_device_speed lpm_device_speed(u32 reg)
-{
- switch (LPM_PSPD(reg)) {
- case LPM_SPEED_HIGH:
- return USB_SPEED_HIGH;
- case LPM_SPEED_FULL:
- return USB_SPEED_FULL;
- case LPM_SPEED_LOW:
- return USB_SPEED_LOW;
- default:
- return USB_SPEED_UNKNOWN;
- }
-}
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox