From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A89C433FF for ; Mon, 29 Jul 2019 06:58:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0203020644 for ; Mon, 29 Jul 2019 06:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726048AbfG2G6C (ORCPT ); Mon, 29 Jul 2019 02:58:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:53306 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725957AbfG2G6C (ORCPT ); Mon, 29 Jul 2019 02:58:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 16BC5ACBA; Mon, 29 Jul 2019 06:58:01 +0000 (UTC) Date: Mon, 29 Jul 2019 08:58:00 +0200 Message-ID: From: Takashi Iwai To: Stephen Rothwell Cc: Johannes Berg , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build warning after merge of Linus' tree In-Reply-To: <20190729140404.37bac29e@canb.auug.org.au> References: <20190729140404.37bac29e@canb.auug.org.au> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, 29 Jul 2019 06:04:04 +0200, Stephen Rothwell wrote: > > Hi all, > > After merging the origin tree, today's linux-next build (powerpc > allyesconfig) produced this warning: > > sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get': > sound/aoa/codecs/onyx.c:377:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized] > ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity; > ^~~~~~~~~~~~ > > Introduced by commit > > f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") > > This warning has been around for a long time. It could possibly be > suppressed by checking for errors returned by onyx_read_register(). Yes, or simply zero-ing the variable in onyx_read_register(). The current code ignores the read error and it's been OK over a decade :) thanks, Takashi